pokehacks/pokecrystal-board
0
0
Fork 0
mirror of https://gitlab.com/xCrystal/pokecrystal-board.git synced 2024-11-16 11:27:33 -08:00
Code Issues Packages Projects Releases Wiki Activity
4,966 Commits 1 Branch 0 Tags 52 MiB
31c3c94d64
Commit Graph

1345 Commits

Author SHA1 Message Date
Rangi
40902ffe24 Verify data table sizes with table_width and assert_table_length macros 
This was discussed in #706

It also uncovered some off-by-one issues with defining some constants.

A few structs now use rsreset/_RS to define their offset constants, as discussed in #739
 2021-03-04 00:15:03 -05:00
Rangi
4401d24074 Identify link sync buffers, separate from link action bytes 
Fixes #803
 2021-02-22 12:02:52 -05:00
Rangi
287d893d22 Use PARTY_LENGTH and MAILBOX_CAPACITY constants 2021-02-10 08:50:39 -05:00
Rangi
5b9e6c0299 Identify label BattleTowerFade.loop 2021-02-05 14:56:29 -05:00
Rangi
4be482e587
Merge pull request #799 from FredrIQ/typo_fix 
Battle Tower: fix typo in constant (PROGESS -> PROGRESS)
 2021-02-05 09:45:11 -08:00
Rangi
4264d53eb6 Identify some more labels 2021-02-05 12:44:21 -05:00
Fredrik Ljungdahl
8f4dcbcb59 Battle Tower: fix typo in constant (PROGESS -> PROGRESS) 2021-02-04 12:42:56 +01:00
Rangi
7d3ea88611 Rename GetFarHalfword to GetFarWord 
Fixes #796
 2021-01-09 15:16:05 -05:00
Rangi
5db892782a Remove "Buffer" suffix from two HRAM labels 2020-12-23 16:54:28 -05:00
Rangi
99e66c2557 Rename some labels 
- Remove "Buffer" suffix from some byte and word quantities
- Change "Ptr" to "Pointer"

Fixes #789
 2020-12-23 16:29:30 -05:00
Rangi
6f226f584c Identify link.asm WRAM labels based on ax6's research notes <https://pastebin.com/NTxjzKGQ> 2020-12-08 21:24:48 -05:00
Rangi
9fea403be2 grey -> gray 2020-12-08 14:34:54 -05:00
Rangi
098903fc97 FarString -> PlaceFarString, and document a BrokenPlaceFarString bug 2020-12-07 13:32:08 -05:00
Rangi
4ef556cbc8 Document AI_Smart_Conversion2 bug (resolves #786) 2020-12-07 13:13:03 -05:00
aljohnston112
7b9d8767d4
Identified two magic numbers and cleaned up some comments (#783) 
Improve the audio engine's comments and replace some magic numbers with constants
 2020-12-07 12:44:16 -05:00
Rangi
5e9d43e39b text "<PARA>..." → text_start and para "..." 2020-12-04 22:28:31 -05:00
Rangi
4613bcfadf Use STRING_BUFFER_LENGTH for the wStringBuffers 2020-11-24 20:11:17 -05:00
Rangi
97e981985b Correct some filename comments 2020-11-17 11:12:21 -05:00
Rangi
9b3c45b14d Resolve some "???" comments 2020-11-17 11:09:02 -05:00
Rangi
fa3712ea34 Remove "XXX" comments (various "???+" still mark unclear code) 2020-11-09 16:38:11 -05:00
Rangi
6a5edc98e9 Terser damage calculation constants 2020-11-09 16:12:19 -05:00
Rangi
17894e5f39 Replace $0 with 0 for "ld l, a / ld h, 0" idiom 2020-11-09 15:20:40 -05:00
Rangi
03e149e559 Identify wBattleAnimTemp0-3 2020-11-09 15:05:14 -05:00
Rangi
62b756c46e Rename "dummy game" to "memory game" 2020-11-08 19:32:57 -05:00
Rangi
7254c10093 Identify remaining uses of wBuffer1-6 as general-purpose HP buffers or mobile 2020-11-03 23:25:22 -05:00
Rangi
a831b34e5c Identify some uses of wBuffer1-6 in new Crystal code 2020-11-03 22:52:50 -05:00
Rangi
9f62d7911b Identify some more uses of wBuffer1-6 2020-11-03 22:45:12 -05:00
Rangi
c88c4a8340 Identify more uses of wBuffer1-6 2020-11-03 19:53:07 -05:00
Rangi
826e070f04 More syncing with pokegold 2020-11-03 10:13:06 -05:00
Rangi
01d6e6c758 Group some link.asm code into "paragraphs" 2020-11-02 19:32:14 -05:00
Rangi
9ab9088a9f Identify wLinkBattleRNPreamble 2020-11-01 13:42:12 -05:00
Rangi
6220200f0f Identify some more labels, and make some more consistent 2020-11-01 12:36:38 -05:00
Rangi
4a323cf591 UnusedSpriteAnimGFX was to sprite anims as AnimObjGFX is to battle anims 2020-10-30 17:41:03 -04:00
Rangi
9b0002161b Extract more RGB data to .pal files 2020-10-30 16:12:25 -04:00
Rangi
fe1a58deea Identify wSpriteAnimDict key constants 2020-10-30 15:39:08 -04:00
Rangi
1237156948 Identify mobile Name Card exchange labels 2020-10-30 10:45:31 -04:00
Rangi
ba5bc304f9 Updates to more closely sync with pokegold 2020-10-29 23:23:57 -04:00
Rangi
7883e8f431 Define SERIAL_LINK_BYTE_TIMEOUT 2020-10-29 16:43:28 -04:00
Rangi
a51b1a2f13 Port more pokegold link engine symbols, and name an unused WRAM byte 2020-10-29 15:15:14 -04:00
Rangi
bcc0d633e9 Identify the remaining (non-mobile) uses of another WRAM union 2020-10-29 14:51:41 -04:00
Rangi
ea426a8879 Identify more WRAM labels, and start a <X>_DummyFunction label convention 2020-10-28 14:34:38 -04:00
Rangi
6d333bed5f Replace many '; unused' with '; unreferenced' 2020-10-28 10:21:10 -04:00
Rangi
446f1846b1 Identify remaining Mystery Gift labels and constants 
Source: https://projectpokemon.org/home/forums/topic/43930-mystery-gift-reverse-engineering-of-ir-protocol/
 2020-10-27 23:09:06 -04:00
Rangi
2738858985 Create data/collision/ for tile collision-related data 2020-10-27 10:00:56 -04:00
Rangi
c85ba78b77 Use more assertions to ensure correct code and data 2020-10-26 22:24:38 -04:00
Rangi
9dcdad5e60 Comment, remove, or revise many unreferenced labels 2020-10-26 20:29:58 -04:00
Rangi
a2b6befd7d Identify some more labels, mostly WRAM 2020-10-23 16:04:15 -04:00
Rangi
7991db972b Identify some more link.asm labels (syncing to pokegold) 2020-10-23 13:36:54 -04:00
Rangi
8a73bb9ab2 Identify remaining debug color picker labels 2020-10-23 12:38:07 -04:00
Rangi
bd3f634049 Identify remaining map object labels 2020-10-22 21:30:21 -04:00
Rangi
d8310c166d Identify some more map object labels and constants 2020-10-22 17:41:48 -04:00
Rangi
15f6a0af43 Identify a few more labels and data 2020-10-22 12:55:46 -04:00
Rangi
b9a74ff777 Identify more sprite graphics and map object labels, and have consistent anonymous jumptable labels 2020-10-22 10:54:53 -04:00
Rangi
ae4fe08084 Identify some more labels (a few link-related) 2020-10-22 00:53:54 -04:00
Rangi
3a2932cec1 Identify remaining two battle anim BG effect functions 2020-10-21 22:51:24 -04:00
Rangi
650686476c Identify remaining battle AI labels 2020-10-21 21:34:18 -04:00
Rangi
93dcc8b6eb Identify SwitchItemsInBag labels 
Thanks to FIQ for having done so in Polished Crystal
 2020-10-21 15:39:15 -04:00
Rangi
7b12060e6a Battle transition spin quadrants are like pokered's half circles 2020-10-19 20:27:19 -04:00
Rangi
406ac7afbb Identify some values as relative struct offsets in MoveScreenLoop 2020-10-14 18:32:41 -04:00
Rangi
2e90df15b7 Update battle anim bg function comments, and identify more unnamed labels 2020-10-06 18:09:33 -04:00
7Soul
cf26f55985
Identify battle bg effects functions and constants (#773) 
Identify battle bg effects functions and constants
 2020-10-06 15:45:09 -04:00
Rangi
fc08ff2c38 Identify some unnamed labels 2020-10-06 13:50:02 -04:00
Rangi
42d0a2567a Identify some more unnamed labels 2020-10-05 20:10:01 -04:00
Rangi
6b7ade66da Identify more unnamed labels 2020-10-05 16:15:57 -04:00
Rangi
ff2d850219 Identify some more unnamed labels 2020-10-05 12:02:56 -04:00
Rangi
d9603e3e33 Identify more unnamed labels 2020-10-04 22:34:50 -04:00
Rangi
306c85750e Identify some more unnamed labels 2020-10-04 20:10:39 -04:00
Rangi
5a546068a8 Identify SGB blk/pal packets 2020-10-04 18:32:33 -04:00
7Soul
2ffc5f907f
Identify battle animation functions (#771) 
Identify battle animation functions
 2020-10-03 21:54:02 -04:00
Rangi
1357e0d674 Fix #769: document the Heavy Ball weight bank bug 2020-09-27 12:39:27 -04:00
Rangi
cf37abd3ec Remove wKickCounter and wPresentPower aliases for wBattleAnimParam 2020-08-29 20:35:49 -04:00
mid-kid
3b43f79dc6 Use hex for tile IDs in engine/movie/splash.asm 2020-08-27 18:03:54 +02:00
mid-kid
353f78f493 GS_INTRO_STAR/SPARKLE -> GS_GAMEFREAK_LOGO_STAR/SPARKLE 
These two sprite animations are related to the Game Freak Logo splash
screen, not the actual intro.
 2020-08-27 15:13:41 +02:00
mid-kid
15c08ad8a3 Small changes to better match pokegold 2020-08-27 14:52:27 +02:00
mid-kid
13c4a93cea Fix some constants surrounding sprite animations 
Also commented the use of the field surrounding the struct
initialization functions.

SPRITEANIMSTRUCT_0C -> SPRITEANIMSTRUCT_VAR1
SPRITEANIMSTRUCT_0D -> SPRITEANIMSTRUCT_VAR2
SPRITEANIMSTRUCT_0E -> SPRITEANIMSTRUCT_VAR3
SPRITEANIMSTRUCT_0F -> SPRITEANIMSTRUCT_VAR4

BATTLEANIMSTRUCT_01 -> BATTLEANIMSTRUCT_OAMFLAGS
BATTLEANIMSTRUCT_ANON_JT_INDEX -> BATTLEANIMSTRUCT_JUMPTABLE_INDEX
BATTLEANIMSTRUCT_0F -> BATTLEANIMSTRUCT_VAR1
BATTLEANIMSTRUCT_10 -> BATTLEANIMSTRUCT_VAR2
 2020-08-27 13:59:33 +02:00
mid-kid
733664b18f Document splash screen animation 2020-08-27 13:59:33 +02:00
mid-kid
2b2c1ac649 Split engine/movie/intro.asm into itself and splash.asm 2020-08-27 13:59:31 +02:00
mid-kid
926e231849 Move all splash screen files to gfx/splash 2020-08-27 13:58:54 +02:00
mid-kid
e40f421ffb Document weird code involving link trades of mew and celebi 
This piece of code is frankly rather confusing, as it seemingly doesn't
serve much of a purpose. Documenting it here for future reference.
 2020-08-19 16:00:00 +02:00
Rangi
0b31d12dac
Merge pull request #756 from mid-kid/master 
Rub a dub dub, thanks for the grub
 2020-08-18 16:35:15 -04:00
mid-kid
315d6c665e Add wTitleScreenSelectedOption constants 2020-08-18 22:20:16 +02:00
Rangi
7729dcd204 Consistent constants for radio data table sizes (could still be better) 2020-08-13 13:47:50 -04:00
Rangi
f65448a4c0 Factor out gfx/pack/pack_menu.tilemap 2020-08-12 20:59:54 -04:00
Rangi
ed3e70b97c Identify some time-related data 2020-08-11 14:12:59 -04:00
mid-kid
8befc889ad Remove a verifiably false comment 
wSpriteAnimCount starts at 0, keeps incrementing and never decrements.
When it reaches $ff, the next value is 1.

Its purpose is unknown, as this value is used nowhere else.
 2020-08-05 16:02:48 +02:00
mid-kid
aabfc0b413 d is the multiplier for Sprites_Sine 2020-08-05 16:02:48 +02:00
mid-kid
b6055b1944 Use TRUE for hCGBPalUpdate 2020-08-05 16:02:48 +02:00
mid-kid
ac48d65498 Document wTitleScreenSelectedOption variable 2020-08-05 16:02:44 +02:00
mid-kid
2d2a7dec7d Label some mobile battle screen functions 2020-08-03 23:35:18 +02:00
mid-kid
58b45443e8 Minor title screen fixes 2020-08-03 23:35:18 +02:00
mid-kid
79bb2784e9 Better label 2D menu data 2020-08-03 22:56:49 +02:00
mid-kid
248763b238 Prevent OaksPKMNTalk from looping forever if NUM_GRASSMON is changed 
That should cause no real problems because of a range check right after
it.
 2020-08-03 22:56:49 +02:00
Rangi
0de7808ded Identify constant in NamingScreen_IsTargetBox 2020-08-03 15:22:28 -04:00
Rangi
35821ec58c Correct constants in DoNPCTrade 2020-07-25 18:36:49 -04:00
Rangi
dcb24bc724 Use def_* macros for automatic map event counts 
Resolves #742
 2020-07-24 09:57:16 -04:00
Rangi
dd369f3199 Move EngineFlags and SpecialsPointers into data/engine/ 2020-07-22 20:24:53 -04:00
Rangi
11dc805de0 Revert "Factor out tables into data/overworld/" 
This reverts commit b5a7e7de3e.
 2020-07-22 20:21:26 -04:00
Rangi
b5a7e7de3e Factor out tables into data/overworld/ 
Fixes #749
 2020-07-22 15:22:58 -04:00
Rangi
212846af57 Treat map setup commands like trade script commands 
Fixes #736
 2020-07-22 13:37:43 -04:00
Rangi
bb25c1074c Use LOAD/ENDL for OAM DMA code in HRAM (requires rgbds 0.4.1) 2020-07-21 19:45:25 -04:00