xCrystal
84d5bdb55d
Level selection menu: sprite anim data ( #12 )
2023-08-20 13:03:33 +02:00
xCrystal
fc2e757c57
Make level selection menu landmarks universal ( #4 ) ( #12 )
2023-08-20 12:08:24 +02:00
xCrystal
222b46896c
Level selection menu: init screen and bg layout, and preliminary landmarks data ( #12 )
2023-08-19 19:45:43 +02:00
xCrystal
fe4b54cece
Level selection menu: placeholder grahpics and cgb layout ( #12 )
2023-08-18 20:19:34 +02:00
xCrystal
d7ce3b27ab
Clean up some WRAM and SRAM involving unused mobile data ( #6 )
2023-08-18 12:04:53 +02:00
xCrystal
1f33436a64
Board menu ( #11 ) [Commit 1]
2023-08-14 20:09:23 +02:00
xCrystal
052d246ee3
Use overworld textbox in text printing functions, differentiating between 1bpp and 2bpp text ( #10 )
2023-08-11 12:28:14 +02:00
xCrystal
f64bbf700d
Consolidate behavior of fading to/from white in overworld ( #2 ), Fix naming screen tiles ( #3 ) (bug fix to 6e3c5fd008
)
2023-08-04 23:54:53 +02:00
xCrystal
6e3c5fd008
Expand tilesets from 192 to 255 tiles ( #2 ) [Commit 2], Reorganization of pokecrystal charmap and fonts layout ( #3 )
2023-08-02 19:52:51 +02:00
xCrystal
a1e095074c
Remove Japanese text and non-english fonts ( #1 ), Expand tilesets from 192 to 255 tiles ( #2 ) [Commit 1]
2023-08-02 18:21:34 +02:00
xCrystal
9df4cf6946
Create a fourth time of day ( #2 )
2023-07-31 12:27:53 +02:00
xCrystal
05448d7a7e
Remove RTC ( #1 ) and remove time of day dependence on RTC ( #7 ) [Commit #2 ]
2023-07-28 00:07:07 +02:00
xCrystal
0571144a7b
Remove RTC ( #1 ) and remove time of day dependence on RTC ( #7 ) [Commit 1]
2023-07-27 20:32:15 +02:00
xCrystal
59bda0b36b
Fix some pokecrystal bug and glitches ( #8 )
...
Credits sequence changes move selection menu behavior; Swimming NPCs aren't limited by their movement radius; No bump noise if standing on tile E; The unused phonecall script command may crash; ScriptCall can overflow wScriptStack and crash; LoadSpriteGFX does not limit the capacity of UsedSprites; ReadObjectEvents overflows into wObjectMasks; ClearWRAM only clears WRAM bank 1; BattleAnimCmd_ClearObjs only clears the first 6⅔ objects; Options menu fails to clear joypad state on initialization
2023-07-27 13:01:32 +02:00
xCrystal
d30b9dd60f
Further remove unnecessary DMG/SGB checking ( #7 ) and remove SGB layouts and palette data ( #1 )
2023-07-26 17:02:33 +02:00
xCrystal
acd022d765
Remove unnecessary DMG and SGB checking ( #7 )
2023-07-26 17:02:33 +02:00
xCrystal
2d5bd722cd
Clean up WRAM, SRAM, and HRAM space ( #6 )
2023-07-25 19:49:25 +02:00
xCrystal
5147904f78
Remove original maps and object events ( #1 )
2023-07-25 15:33:08 +02:00
xCrystal
60cacea4b0
Remove unreferenced content in bank 0 ( #1 )
2023-07-25 11:54:34 +02:00
xCrystal
fc7f2d4e0e
Remove Mobile, Battle Tower, Mystery Gift, and Odd Egg ( #1 )
2023-07-24 21:13:11 +02:00
vulcandth
cb8505e022
Define InitDefaultEZChatMsgs
and sEZChatMessages
( #1022 )
2022-12-26 13:55:01 -05:00
Andrew Cook
0f5540740b
Some Mobile code labeling and removed magic numbers ( #993 )
...
* Macro loop for EmptyAllSRAMBanks
* Many things labeled and magic numbers removed
* Conform to the style guide
* Rename URLs in mobile_46
* MOBILEAPI_19 -> MOBILEAPI_TELEPHONESTATUS
* Update engine/menus/empty_sram.asm
Co-authored-by: Rangi <35663410+Rangi42@users.noreply.github.com>
* Update ram/wram.asm
Co-authored-by: Rangi <35663410+Rangi42@users.noreply.github.com>
* Update mobile/mobile_46.asm
Co-authored-by: Rangi <35663410+Rangi42@users.noreply.github.com>
* Update mobile/mobile_46.asm
Co-authored-by: Rangi <35663410+Rangi42@users.noreply.github.com>
* Remove underscore from Set*DownloadURL symbols
* Begin Labeling TradeCornerHoldMon routines
* Add wMobileMon party_struct
* Add TRADE_CORNER_REQUEST_LENGTH constant
* Name battle tower action functions
* Label trade corner send/receive buffer
* Label the saved copy of the trade corner pokemon
also fix mailmsg_jp
* So many copies of decodeBase64Character
* Label another buffer
* Fix Alignment and use MOBILE_EMAIL_LENGTH
* `Function11ad8a` -> `MobileIncJumptableIndex`
* Apply Rangi Suggestions pass 1
Co-Authored-By: Rangi <35663410+Rangi42@users.noreply.github.com>
* Apply Suggestions 2
Co-authored-by: Rangi <35663410+Rangi42@users.noreply.github.com>
Co-authored-by: vulcandth <vulcandth@gmail.com>
2022-09-14 19:49:58 -05:00
Rangi
4883950318
Use for
loops to generate box pointer tables
...
Fixes #996
2022-08-31 18:03:49 -04:00
Rangi
7ef31d9889
Move non-Pokémon graphics out of gfx/icons
...
Fixes #987
2022-08-17 17:45:26 -04:00
The Void
38cd2155df
Bug Doc: Options menu fails to clear joypad state on initialization ( #984 )
2022-08-11 23:28:35 -05:00
Rangi
0d5cf5c8b9
Refer to "Rival", not "Silver" ( #983 )
...
Fixes #982
2022-08-10 21:24:56 -04:00
Rangi
7cac5b787b
Assert that there are NUM_FRAMES textbox frames
2022-08-06 12:24:40 -04:00
Rangi
974bb7bf33
Only use "; BUG:" comments for documented bugs
2022-07-17 14:08:56 -04:00
Colton G. Rushton
145d8dd5c2
wVirtualOAM -> wShadowOAM and hTransferVirtualOAM -> hTransferShadowOAM ( #971 )
2022-07-09 17:18:22 -04:00
vulcandth
3648afda16
RGBDS syntax updates ( #905 )
...
New MACRO and DEF syntax
2022-06-06 17:25:42 -04:00
vulcandth
a4d346cc8c
Improved Virtual Console patch identifiers ( #907 )
2022-06-06 17:22:48 -04:00
vulcandth
f9077c6db6
Additional vc_asserts ( #906 )
2022-04-16 20:42:06 -04:00
Rangi
f33a041930
Allow alternate labels for patch names
2022-03-12 22:38:29 -05:00
vulcandth
31c3c94d64
Build the Virtual Console patch with make crystal11_vc
( #882 )
...
Fixes #813
2022-03-12 18:34:04 -05:00
Rangi
e706b878d9
Use ~X instead of $ff ^ X
2021-11-23 20:37:18 -05:00
Rangi
ed0a0f7159
Move the dbbw, dbww, and dbwww macros to legacy
2021-05-30 15:51:49 -04:00
Rangi
316fa4b695
Use rgbds 0.5.0
2021-04-19 16:31:37 -04:00
Rangi
99e66c2557
Rename some labels
...
- Remove "Buffer" suffix from some byte and word quantities
- Change "Ptr" to "Pointer"
Fixes #789
2020-12-23 16:29:30 -05:00
Rangi
97e981985b
Correct some filename comments
2020-11-17 11:12:21 -05:00
Rangi
17894e5f39
Replace $0 with 0 for "ld l, a / ld h, 0" idiom
2020-11-09 15:20:40 -05:00
Rangi
c88c4a8340
Identify more uses of wBuffer1-6
2020-11-03 19:53:07 -05:00
Rangi
6220200f0f
Identify some more labels, and make some more consistent
2020-11-01 12:36:38 -05:00
Rangi
fe1a58deea
Identify wSpriteAnimDict key constants
2020-10-30 15:39:08 -04:00
Rangi
ea426a8879
Identify more WRAM labels, and start a <X>_DummyFunction label convention
2020-10-28 14:34:38 -04:00
Rangi
6d333bed5f
Replace many '; unused' with '; unreferenced'
2020-10-28 10:21:10 -04:00
Rangi
446f1846b1
Identify remaining Mystery Gift labels and constants
...
Source: https://projectpokemon.org/home/forums/topic/43930-mystery-gift-reverse-engineering-of-ir-protocol/
2020-10-27 23:09:06 -04:00
Rangi
9dcdad5e60
Comment, remove, or revise many unreferenced labels
2020-10-26 20:29:58 -04:00
Rangi
fc08ff2c38
Identify some unnamed labels
2020-10-06 13:50:02 -04:00
Rangi
d9603e3e33
Identify more unnamed labels
2020-10-04 22:34:50 -04:00
Rangi
306c85750e
Identify some more unnamed labels
2020-10-04 20:10:39 -04:00
mid-kid
13c4a93cea
Fix some constants surrounding sprite animations
...
Also commented the use of the field surrounding the struct
initialization functions.
SPRITEANIMSTRUCT_0C -> SPRITEANIMSTRUCT_VAR1
SPRITEANIMSTRUCT_0D -> SPRITEANIMSTRUCT_VAR2
SPRITEANIMSTRUCT_0E -> SPRITEANIMSTRUCT_VAR3
SPRITEANIMSTRUCT_0F -> SPRITEANIMSTRUCT_VAR4
BATTLEANIMSTRUCT_01 -> BATTLEANIMSTRUCT_OAMFLAGS
BATTLEANIMSTRUCT_ANON_JT_INDEX -> BATTLEANIMSTRUCT_JUMPTABLE_INDEX
BATTLEANIMSTRUCT_0F -> BATTLEANIMSTRUCT_VAR1
BATTLEANIMSTRUCT_10 -> BATTLEANIMSTRUCT_VAR2
2020-08-27 13:59:33 +02:00
mid-kid
733664b18f
Document splash screen animation
2020-08-27 13:59:33 +02:00
mid-kid
315d6c665e
Add wTitleScreenSelectedOption constants
2020-08-18 22:20:16 +02:00
mid-kid
ac48d65498
Document wTitleScreenSelectedOption variable
2020-08-05 16:02:44 +02:00
mid-kid
58b45443e8
Minor title screen fixes
2020-08-03 23:35:18 +02:00
Rangi
0de7808ded
Identify constant in NamingScreen_IsTargetBox
2020-08-03 15:22:28 -04:00
Rangi
e239aa4aba
Disassemble the final English debug ROM
2020-07-13 15:18:28 -04:00
Rangi
fce6243b43
Identify more labels, and use the jumptable macro when possible
2020-07-01 13:13:49 -04:00
Rangi
c3c18dd196
Comment more ROM labels as unreferenced
...
(Some unreferenced labels are above code which is still used via fallthrough!)
2020-06-21 18:33:31 -04:00
Rangi
91774f206e
Replace "Unreferenced" labels with "; unreferenced" comments
2020-06-21 16:27:43 -04:00
Rangi
98af69691d
Remove some more raw addresses
2020-06-21 12:21:47 -04:00
Rangi
ed3bcf6fa2
Harmonize engine/menus with pokegold
2020-06-18 10:11:12 -04:00
Rangi
cc460a17b0
Harmonize engine/{movie, pokemon} with pokegold (renames GetSRAMBank to OpenSRAM)
...
To do: engine/{menus, overworld}
2020-06-17 17:03:38 -04:00
Rangi
b9f2b93c17
Harmonize some more symbols with pokegold
2020-06-16 11:28:52 -04:00
Rangi
4342ced31f
Identify wObjectPriorities
2020-06-15 23:28:24 -04:00
Rangi
75035a71a5
Label some mobile addresses, and revise some comments
2020-06-13 18:48:26 -04:00
Lhivorde
4f49a1f2f0
Rename ScrollingMenu_UpdateDisplay.string_2485f ( #726 )
2020-05-29 11:16:49 +00:00
Rangi
fe42ef8a88
Some uses of SCREEN_WIDTH and SCREEN_HEIGHT
2020-05-25 21:05:52 -04:00
Rangi
e32cf1bfd1
Miscellaneous cleanup noted in #709
2020-05-17 20:59:15 -04:00
Rangi
395ebd8386
Format all CopyTilemapAtOnce variations the same way
2020-05-16 22:25:52 -04:00
Rangi
22615cecc5
More miscellaneous fixes (see #709 )
2020-04-17 10:52:59 -04:00
Rangi
0ef004a4db
dsprite y, ypx, x, xpx, off, attr
-> dbsprite x, y, xpx, ypx, off, attr
2020-04-04 16:00:30 -04:00
Rangi
79184bc718
Miscellaneous fixes:
...
- `hSecondsBackup` -> `hUnusedBackup`
- `ld bc, hBGMapAddress + 1` -> `bccoord -1, -2, 0`
- Identify some `.asm_XXX` labels
2020-04-04 15:43:10 -04:00
Rangi
6a6ba10315
rgbds supports 'X - 1' instead of 'X + -1'
2020-03-21 14:01:05 -04:00
Rangi
f09b68d945
Change how some PNG graphics are formatted
2020-03-01 17:00:57 -05:00
Rangi
447da80615
Identify remaining gfx/unknown files
2020-02-28 09:23:41 -05:00
Rangi
c3f389d615
Replace some "idiotic", "wtf", "stupid interns" comments with more common "useless", "pointless", "could have done X instead"
2020-02-23 18:51:32 -05:00
mid-kid
c22e268083
RTC -> UpdateTimeAndPals
...
Rename clear misnomer.
Most of the related functions in that file aren't really aptly named but
I don't know good names right now.
2020-02-21 18:21:29 +01:00
mid-kid
75a6bb5df6
PanicResetClock -> ClearClock
...
Funky name that only exists based on what it's used for, not so much
what it is.
2020-02-16 12:20:20 +01:00
mid-kid
26b8bf003e
Standardize on lowercase Tilemap and Attrmap
...
We used to have a mixture of TileMap and and Tilemap, as well as the
similar AttrMap. Standardize on one.
2020-02-13 18:31:10 +01:00
mid-kid
0d81f1c470
InitSpriteAnimStruct <-> _InitSpriteAnimStruct
...
These were the wrong way around, as the function in home should not be
prefixed
2020-02-13 18:31:10 +01:00
Rangi
4d32035d4f
Bit 6 of PrintNum left-aligns numbers
2019-11-03 20:17:04 -05:00
mid-kid
f4907040c9
Label some more WRAM/SRAM things
...
This should be all of the memory locations that are actually used, and
some more.
Removal of all addresses when?
2019-10-21 00:42:36 +02:00
mid-kid
e3e0bcd653
#641 fixes and additions. ( #646 )
...
Name a lot of text labels according to our conventions
2019-10-20 18:24:17 -04:00
mid-kid
c048b24d25
Create constants for ScrollingMenu item formats
...
...I should've done this quite a while ago.
2019-06-09 02:31:24 +02:00
Rangi
7890fae995
Some more GB Printer documentation
2019-05-11 13:01:59 -04:00
mid-kid
3e78e5b2b6
TextBox -> Textbox
...
Homogenizing names.
2019-04-09 16:09:18 +02:00
Fredrik Ljungdahl
e598e49edb
Fix wram labeling for wPCItems
2019-03-18 16:43:58 +01:00
Rangi
df337fc417
Update to rgbds 0.3.8
2019-02-16 12:17:55 -05:00
Rangi
1853e3d127
Say "BANK(Foo) ; aka BANK(Bar)" to clarify that Foo and Bar share a bank
2019-01-12 15:17:20 -05:00
Rangi
3202c4f3df
Resolve issue #575 : Rename text commands
2018-11-18 12:41:11 -05:00
mid-kid
940256569b
text_jump → text_far
...
The previous name for this was rather misleading. It isn't an actual
jump like you'd expect the `jp` instruction to behave as. Instead, it
behaves more like a `farcall`.
This also makes it consistent with its current command ID name of
`TX_FAR`.
2018-11-05 22:26:18 +01:00
Rangi
38bf21ae35
Naming screen constants
2018-09-22 12:39:17 -04:00
mid-kid
3540b2a2d6
wMonStatusFlags -> wDebugFlags
2018-09-16 02:15:55 +02:00
Rangi
3241c9cfaa
Use 0/1/2/3 for palettes, and rgbds opt feature for battle transition graphic
2018-09-09 18:15:54 -04:00
Rangi
bb4a6e5f55
wCursorCurTile -> wCursorCurrentTile
2018-09-09 17:15:49 -04:00
Rangi
603bcfe2ae
wPreviousLandmark → wPrevLandmark
2018-09-09 15:27:23 -04:00
Rangi
ae022e1420
Curr -> Cur
2018-09-09 15:09:51 -04:00
Rangi
7aa1c1f388
Remove HRAM label address comments
2018-08-25 14:39:24 -04:00
Rangi
eb1e3636bb
Use labels instead of constants for HRAM
...
Use explicit ldh instruction to access HRAM locations, don't rely on optimizing ld
2018-08-25 14:28:22 -04:00