Replace some "idiotic", "wtf", "stupid interns" comments with more common "useless", "pointless", "could have done X instead"

This commit is contained in:
Rangi 2020-02-23 15:30:21 -05:00
parent 62fccbbd99
commit c3f389d615
8 changed files with 10 additions and 11 deletions

View File

@ -225,7 +225,6 @@ Function24a6c:
ret
ItemSwitch_ConvertItemFormatToDW:
; This function is absolutely idiotic.
push hl
ld a, [wMenuData_ScrollingMenuItemFormat]
ld c, a

View File

@ -10,12 +10,11 @@ InitCrystalData:
ld [wd478], a
ld [wd002], a
ld [wd003], a
; could have done "ld a, [wd479] \ and %11111100", saved four operations
ld a, [wd479]
res 0, a
res 0, a ; ???
ld [wd479], a
ld a, [wd479]
res 1, a
res 1, a ; ???
ld [wd479], a
ret

View File

@ -122,9 +122,10 @@ RefreshPlayerCoords:
ld hl, wPlayerLastMapY
ld [hl], e
ld e, a
; the next three lines are useless
ld a, [wObjectFollow_Leader]
cp $0
ret nz ; wtf
ret nz
ret
CopyObjectStruct::

View File

@ -23,7 +23,7 @@ DelCellNum::
ret
CheckCellNum::
jp _CheckCellNum ; wtf
jp _CheckCellNum ; useless
_CheckCellNum:
ld hl, wPhoneList

View File

@ -60,7 +60,7 @@ StatsScreenInit_gotaddress:
StatsScreenMain:
xor a
ld [wJumptableIndex], a
; stupid interns
; ???
ld [wcf64], a
ld a, [wcf64]
and %11111100
@ -80,7 +80,7 @@ StatsScreenMain:
StatsScreenMobile:
xor a
ld [wJumptableIndex], a
; stupid interns
; ???
ld [wcf64], a
ld a, [wcf64]
and %11111100

View File

@ -592,7 +592,7 @@ ReadObjectEvents::
jr z, .skip
; jr c, .skip
; stupid waste of time and space
; could have done "inc hl" instead
ld bc, 1
add hl, bc
; Fill the remaining sprite IDs and y coords with 0 and -1, respectively.

View File

@ -6469,7 +6469,7 @@ Function102e07:
jr .okay
.link_battle
; this is idiotic
; the next three operations are pointless
hlcoord 3, 10
ld b, 1
ld c, 11

View File

@ -146,7 +146,7 @@ MobileMenu_InitMenuBuffers:
ld [hli], a
ld a, $20 ; w2DMenuCursorOffsets
ld [hli], a
; this is a stupid way to load $c3
; could have done "ld a, A_BUTTON | D_UP | D_DOWN | B_BUTTON" instead
ld a, A_BUTTON
add D_UP
add D_DOWN