mid-kid
4154f191e0
Anotate more of the battle anim subsystem
...
The X and Y flip flags can be applied through the stack consisting of:
- Object attributes
- Animation frame attributes
- OAM Data
Each of these negate eachother.
Confused yet? The same stack is traversed to obtain the final tile ID,
with an added layer on top for the base GFX offset and the offset for
the dynamically loaded GFX requested by the object!
wBattleAnimDelay is populated with the values passed to `anim_wait`.
2019-02-15 03:01:59 +01:00
mid-kid
469c51d086
dorepeat -> dowait for oam animations
...
Having the pic animation macros be the same as the oam animation macros
isn't really turning out so well... I wonder if we should split them up
eventually.
2019-02-15 02:54:35 +01:00
Rangi
d9d688df4e
Merge pull request #600 from mid-kid/master
...
Fix travis
2019-02-09 20:09:25 -05:00
mid-kid
fb8b8d7086
Fix travis
2019-02-10 01:56:48 +01:00
Rangi
8577d78f4d
Merge pull request #599 from mid-kid/master
...
Add tool to find unnamed symbols: Take 2
2019-02-09 18:35:39 -05:00
mid-kid
1bc1673794
Fix python 3.6 support for unnamed.py
2019-02-10 00:17:19 +01:00
Rangi
4819a54b16
Merge pull request #598 from mid-kid/temp
...
BATTLEANIMSTRUCT_0B -> BATTLEANIMSTRUCT_PARAM
2019-02-09 18:04:03 -05:00
Rangi
b791198f74
Merge pull request #596 from Rangi42/master
...
Remove the nested UNION within battle WRAM
2019-02-09 18:03:07 -05:00
Rangi
349664ec15
Clarify outer union's size
2019-02-08 15:40:32 -05:00
Rangi
32c34a3619
Separate the 200-byte c608-to-c6d0 union and the 280-byte c6d0-to-c7e8 union
2019-02-08 15:38:31 -05:00
Rangi
6cbdd245fc
$8 = HIGH(vTiles1 - vTiles0)
2019-02-06 23:52:50 -05:00
mid-kid
ffeae953ea
Document all possible values for ReinitBattleAnimFrameset
...
This is useful to know where a certain frameset is used, through `grep`
2019-02-06 10:16:40 +01:00
mid-kid
bfedd89308
BATTLEANIMSTRUCT_0B -> BATTLEANIMSTRUCT_PARAM
...
This structure member is used for storing the parameter passed to
`anim_obj`.
2019-02-06 08:12:52 +01:00
Rangi
60cdc65293
wc7e8 -> wUnusedC7E8 (similar to wUnusedD102)
2019-01-30 19:46:45 -05:00
Rangi
2fca32b6c8
Explain the c608 union size
2019-01-30 19:43:01 -05:00
Rangi
88465686cf
Remove the nested UNION within battle WRAM
2019-01-30 19:29:34 -05:00
Rangi
4fe0d93d4c
Fix some of the issues explained in #595
2019-01-27 14:00:21 -05:00
Rangi
9ecc991814
Merge pull request #593 from mid-kid/temp
...
More patches
2019-01-24 21:42:44 -05:00
Rangi
79ea091ff6
Use and define more WRAM constants
2019-01-24 21:41:14 -05:00
Rangi
68d4a53483
Use more constants
2019-01-24 21:15:30 -05:00
Rangi
84b6a084cb
Keep "paragraphs" of related code together
2019-01-24 21:10:45 -05:00
Rangi
a5c1d9572c
Fix: Clair can give TM24 Dragonbreath twice
2019-01-19 19:27:45 -05:00
Rangi
53c92b4792
Bug: Clair can give TM24 Dragonbreath twice
2019-01-19 19:11:38 -05:00
mid-kid
e288ef20d5
Fix map name frame calculation
2019-01-18 16:17:50 +01:00
mid-kid
0390728d44
Fix constants used with startbattle
2019-01-15 13:37:22 +01:00
mid-kid
a21507f22a
Document wSuicuneFrame
...
Also fixed inmediate in PlaceMapNameFrame.FillTopBottom to calculate the
amount of loops required. (It fills two tiles in the first iteration,
and four in the remaining, hence the `-2` and `+1` part).
2019-01-15 13:08:40 +01:00
mid-kid
5f60cc24cf
Fix some constants
...
Glass ting SFX were added in crystal.
PicAnimations and UnownAnimations are expected to be in the same bank as
their pointers, because the pointers are not BANK()-referenced
separately.
2019-01-15 13:06:16 +01:00
Rangi
1853e3d127
Say "BANK(Foo) ; aka BANK(Bar)" to clarify that Foo and Bar share a bank
2019-01-12 15:17:20 -05:00
Rangi
07374f02cc
Dif formatting typo
2019-01-07 19:36:56 -05:00
Rangi
fe04acad7b
Document bugfix: ScriptCall can overflow wScriptStack and crash
2019-01-07 18:28:47 -05:00
Rangi
1b1b0ac6ea
Document a bugfix: AI makes a false assumption about CheckTypeMatchup
2019-01-07 18:12:00 -05:00
Rangi
26fc7e2521
Consistent formatting in Function_SetEnemyMonAndSendOutAnimation and BattleStartMessage
2019-01-06 22:11:57 -05:00
Rangi
5207615cdc
Document a bugfix: 1/256 failure rate for 100% effect chance
2019-01-05 20:30:46 -05:00
Rangi
3650232398
Merge pull request #590 from Rangi42/master
...
Clean up some Odd Egg and Battle Tower code and data
2019-01-03 19:00:46 -05:00
Rangi
36ebcdd8fe
MON_NAME_LENGTH -> NAME_LENGTH
2019-01-03 07:30:44 -05:00
Rangi
b975f3e068
Clean up some Odd Egg and Battle Tower code and data
...
Fixes #589
2019-01-02 19:04:50 -05:00
mid-kid
f04f31ea85
Add travis webhook for unnamed.py
...
(still requires setup)
2019-01-01 12:13:54 +01:00
mid-kid
9fde0912c3
unnamed.py: Add completion percentage
...
People love percentages. Gotta show our powerlevel.
2019-01-01 11:41:48 +01:00
Rangi
583838a39d
Make tools/gfx.py executable
2018-12-31 18:55:35 -05:00
mid-kid
3b97a15ea3
Add tool to find unnamed symbols
...
This tool should help us identify which are the symbols that still need
proper names, and in which files they're located.
2019-01-01 00:28:51 +01:00
Rangi
9f82304186
Merge pull request #587 from Rangi42/master
...
Remove dependency on 'extras' submodule
2018-12-31 18:26:33 -05:00
Rangi
cae3af3e3a
Keep the most relevant data at the top of the Makefile (the built filenames)
2018-12-31 18:08:37 -05:00
Rangi
742df4fdb5
Remove the 'extras' submodule
2018-12-31 17:20:28 -05:00
Rangi
e3bc378492
Keep gfx.py with other tools, and remove its dependency on the 'extras' submodule
2018-12-31 17:17:55 -05:00
Rangi
4259e7051e
Merge pull request #585 from Rangi42/master
...
Refactor engine/phone/
2018-12-31 16:35:13 -05:00
Rangi
afbf1b3ffc
*PhoneScript1 -> *PhoneCalleeScript, and *PhoneScript2 -> *PhoneCallerScript
2018-12-31 16:32:04 -05:00
Rangi
f2785cdb71
Use battle menu flags
2018-12-31 14:25:53 -05:00
Rangi
8f60de5aba
Fix a typo
2018-12-31 01:03:38 -05:00
Rangi
22657f6078
Split generic phone caller+callee text into individual NPCs
2018-12-30 19:20:45 -05:00
Rangi
d3e0eda398
Distinguish "caller" and "called" phone scripts+text (NPCs call you automatically, you call them from the Pokégear)
2018-12-30 18:05:26 -05:00
