Rangi
cca2afe827
More fixes for fixes
2019-04-23 19:07:41 -04:00
mid-kid
9281233fc8
Fix Dragon Fang fix
2019-04-23 12:53:49 +02:00
mid-kid
3e78e5b2b6
TextBox -> Textbox
...
Homogenizing names.
2019-04-09 16:09:18 +02:00
Rangi
2184b60a0c
Identify and eliminate wEngineBuffer1-5
2019-04-08 19:42:55 -04:00
Rangi
179dc85ba1
Merge pull request #616 from Rangi42/master
...
Minor code+docs fixes
2019-03-14 18:56:39 -04:00
Rangi
2ffbde764e
Minor code+docs fixes
2019-03-12 22:55:40 -04:00
DeeDeeG
f4c0806eb8
bugs_and_glitches.md: Fix embedded image links
2019-03-12 14:37:24 -04:00
DeeDeeG
67ff4b0c94
bugs_and_glitches.md: Minor formatting fix
...
Moves newline to correct spot so diff can apply cleanly.
2019-03-10 23:40:21 -04:00
Rangi
6289232447
Second try at fixing doc links
2019-03-10 23:00:01 -04:00
Rangi
70ef2f3432
Fix documentation links to work with GitHub Pages
2019-03-10 22:43:57 -04:00
Rangi
e002b536af
Rename more script commands for consistency and predictability
...
Fixes #540
2019-03-10 16:00:19 -04:00
Rangi
6393ecb7e5
More consistent formatting
2019-03-03 19:55:28 -05:00
Rangi
9e9f43bce7
Merge pull request #610 from ISSOtm/pursuit_fix
...
Fix Confusion and Pursuit bugs in #603
2019-03-03 19:31:47 -05:00
ISSOtm
f6e94dfd79
Fix spaces
2019-03-04 00:21:30 +01:00
ISSOtm
d79fca8c6e
Add Pursuit-switching fainting no-status-clearing fix
...
Ridiculously long and stupid name for a bug that took a ridiculous and stupid amount of time to track. :')
2019-03-04 00:01:55 +01:00
ISSOtm
bc9d073501
Add confusion + items/selfdestruct fix
2019-03-03 21:49:52 +01:00
Eldred Habert
6b8abd1af1
Correct compatibility claims
2019-03-03 20:35:29 +01:00
Eldred Habert
64d8a2b8fe
Correct Thick Club overflow fix
...
Would, similarly as previous commit, cap incorrectly.
2019-03-03 18:48:24 +01:00
Eldred Habert
ce7e955d10
Correct Metal Powder fix
...
The cap would be applied when it shouldn't - if the high byte was below `HIGH(MAX_STAT_VALUE)` (and thus the value below the cap) but the low byte above `LOW(MAX_STAT_VALUE)`
2019-03-03 18:36:42 +01:00
Eldred Habert
c170810ad4
Correct indentation
...
Add spaces before unchanged lines
2019-03-03 18:10:03 +01:00
Eldred Habert
add58fb00d
Fix "100% secondary effect" fix, add compatibility
...
The original fix was bugged (example: erroneous `pop hl` if `.failed` was jumped to).
Replaced with a less invasive fix, keeping all side effects from the original function; it's less intuitive, but more performant - and the tricky bit has been commented.
Also the new fix is more friendly to the compatibility patch I also added, by request of ShinyDragonHunter.
2019-03-03 17:27:35 +01:00
Rangi
a999787cb8
Update documentation:
...
- Apply more edits from #595
- Move music ID behavior from the wiki to docs
- Move assembly programming links from docs to the wiki
- Describe why the TM item gaps exist
2019-02-17 13:18:38 -05:00
Rangi
1dad1b48d4
Fix indentation
2019-02-16 16:00:13 -05:00
Rangi
417f3c7c72
Bug fix: allow Surfing across map connections
2019-02-16 15:45:55 -05:00
Rangi
4ee7e027be
Fix link
2019-02-16 14:12:07 -05:00
Rangi
96bcf72d96
Document the BattleAnimCmd_ClearObjs bug
2019-02-16 13:31:23 -05:00
Rangi
4fe0d93d4c
Fix some of the issues explained in #595
2019-01-27 14:00:21 -05:00
Rangi
a5c1d9572c
Fix: Clair can give TM24 Dragonbreath twice
2019-01-19 19:27:45 -05:00
Rangi
53c92b4792
Bug: Clair can give TM24 Dragonbreath twice
2019-01-19 19:11:38 -05:00
Rangi
07374f02cc
Dif formatting typo
2019-01-07 19:36:56 -05:00
Rangi
fe04acad7b
Document bugfix: ScriptCall can overflow wScriptStack and crash
2019-01-07 18:28:47 -05:00
Rangi
1b1b0ac6ea
Document a bugfix: AI makes a false assumption about CheckTypeMatchup
2019-01-07 18:12:00 -05:00
Rangi
5207615cdc
Document a bugfix: 1/256 failure rate for 100% effect chance
2019-01-05 20:30:46 -05:00
Rangi
8f60de5aba
Fix a typo
2018-12-31 01:03:38 -05:00
Rangi
e025ab9db0
Merge pull request #578 from mid-kid/master
...
Fixes in the animation subsystem.
2018-12-09 17:44:09 -05:00
mid-kid
112667e773
Fix Belly Drum fix
2018-11-25 23:15:33 +01:00
Rangi
3202c4f3df
Resolve issue #575 : Rename text commands
2018-11-18 12:41:11 -05:00
Rangi
eb1e3636bb
Use labels instead of constants for HRAM
...
Use explicit ldh instruction to access HRAM locations, don't rely on optimizing ld
2018-08-25 14:28:22 -04:00
Rangi
33ff8f2aed
asm → diff
2018-08-23 10:07:05 -04:00
mid-kid
0e0f43747d
Fix docs
2018-08-19 12:17:54 +02:00
Rangi
20ffc8bd8b
Reformat some bugfix diffs
2018-07-29 00:27:13 -04:00
Thomas Winwood
533fdd8b4c
Add fix for battle transition bug
2018-07-28 19:01:02 +01:00
Rangi
cdfdfed17b
Crystal fixed TruncateHL_BC in single player
2018-07-27 21:32:14 -04:00
Rangi
a2f63043d4
Separate Beat Up bugs
2018-07-27 17:53:26 -04:00
Rangi
b58f82e12f
Reword bug docs now that they use diffs
2018-07-27 13:11:30 -04:00
mid-kid
0aac0f9cfc
"Explain" diff format in bugs_and_glitches
2018-07-27 11:25:29 +02:00
mid-kid
a91b59ab5d
Remove a documented bug that's not really a bug
...
I mean, technically, being able to read beyond a data table's size is
bad practice, but there's so many cases of this that it's not worth
mentioning.
For most of these cases, at least, it's safe to assume the index won't
ever get high enough to surpass such a table's length, because it's
either hardcoded or decided by the game without the use of
uncontrollable data. As such, they don't expose any actual bugs.
2018-07-26 23:34:05 +02:00
mid-kid
e43c89bc80
Consistently use the diff format in bugs_and_glitches
2018-07-26 23:34:03 +02:00
Rangi
60ffde3752
Merge pull request #489 from i0brendan0/i0brendan0-patch-5
...
Add Fix for Lock-On Bug
2018-07-26 16:20:52 -04:00
Rangi
dc1d0217a1
Merge pull request #522 from ketsuban/the-diffening
...
Convert code samples to diffs
2018-07-26 16:20:33 -04:00
i0brendan0
8755a88458
turns out none of the code is needed
2018-07-21 05:05:40 -05:00
i0brendan0
6e62eabb42
final change
2018-07-21 03:36:03 -05:00
IIMarckus
8aebc7ba56
Merge branch 'master' of hyperdriveguy/pokecrystal
2018-07-21 00:41:56 -06:00
Thomas Winwood
23ef2f50a7
Merge branch 'master' into the-diffening
2018-07-21 02:06:31 +01:00
Hyperdriveguy
57fc81d44e
Add Counter and Mirror Coat bugfix
2018-07-20 17:39:53 -07:00
Rangi
6e44095c2a
Remove address comments in docs
2018-06-24 21:45:12 -04:00
i0brendan0
57efc4b392
final fix
2018-06-18 00:32:36 -05:00
Rangi
fbe82a7fe0
Note which labels are only needed for locating banks (relevant to issue #485 )
2018-06-12 23:29:15 -04:00
Thomas Winwood
ff1c9f36da
Convert code samples in bugs_and_glitches.md to diffs
2018-06-09 23:35:50 +01:00
i0brendan0
158144f9cb
undo protect message bug
2018-06-02 01:12:52 -05:00
Rangi
3927bcdb9d
Function6ec1 → CanObjectMoveInDirection
2018-05-24 12:36:35 -04:00
Rangi
1840af8b4f
Identify more sprite move data flag bits
2018-05-23 22:01:21 -04:00
mid-kid
c82deab86f
fix-various-little-things
...
A compilation of suggestions from the discord that don't deserve
separate commits and are not questionable at all™.
2018-05-05 09:19:04 +02:00
Rangi
7307fc8dce
Use constants for bit/set/res more
2018-04-05 11:44:02 -04:00
yenatch
f750d4f418
Merge pull request #505 from mid-kid/battlecommands
...
Battle command fixes
2018-04-04 21:18:15 -04:00
mid-kid
38107209a6
Update docs and comments to reflect renames
2018-04-04 23:44:24 +02:00
mid-kid
2958188fc6
Document more Beat Up-related bugs
...
Two bugs related to not raising the substitute when it should, one bug
related to not running king's rock when it should, and the other related
to running king's rock when it shouldn't. Fun.
2018-04-04 22:41:18 +02:00
mid-kid
91a768b243
Update file paths in constants/ and docs/
2018-04-01 17:01:51 +02:00
Rangi
ab2677277e
201 -> 200
2018-03-04 02:30:31 -05:00
Rangi
159a0ef7b4
Bug docs match code
2018-03-04 02:29:39 -05:00
i0brendan0
51bbfee891
Reflect Rangi's suggestion
2018-03-01 04:06:46 -06:00
i0brendan0
82ffb584c8
Add Protect Bug and Fix
...
Moves 'miss' when opponent uses Protect.
2018-03-01 04:08:54 -06:00
Rangi
f0b01a4eea
Document more quirks and bugs
2018-02-26 13:41:48 -05:00
Rangi
5959548c01
Document HOF Master bug ( close #494 )
2018-02-26 11:51:16 -05:00
Rangi
335c2699f0
Merge branch 'master' of https://github.com/pret/pokecrystal
...
# Conflicts:
# constants/map_constants.asm
# constants/wram_constants.asm
# data/radio/oaks_pkmn_talk_routes.asm
# data/radio/pnp_hidden_places.asm
# engine/battle/core.asm
# engine/breeding.asm
# engine/phone/phone_scripts.asm
# engine/radio.asm
# maps/BattleTower1F.asm
# maps/OlivineLighthouse2F.asm
# maps/OlivineLighthouse6F.asm
# maps/PokemonFanClub.asm
# maps/RadioTower1F.asm
# maps/RadioTower2F.asm
# maps/Route30BerryHouse.asm
# maps/Route34IlexForestGate.asm
# maps/Route36NationalParkGate.asm
# maps/RuinsOfAlphKabutoChamber.asm
# maps/RuinsOfAlphResearchCenter.asm
# maps/VermilionPort.asm
# maps/VictoryRoad.asm
2018-02-25 20:39:54 -05:00
mid-kid
e8bc86d1fe
Pkmn -> Mon
...
Since we're aiming for consistency across the codebase, I believe it
includes a uniform way to refer to the creatures this game consists of
in the labels of the code.
The only exceptions to this rule are labels referring to things named
through the use of the <PK><MN> or <PKMN> characters, in which case PKMN
is used.
Most of this was already consistent enough™, I just picked the
convention with the most occurences and fixed the outliers.
2018-02-22 17:39:06 +01:00
i0brendan0
a99adb0e5a
Fix
...
I did a dumb and used the wrong check instruction. Should actually work.
2018-02-20 01:48:22 -06:00
i0brendan0
0e45563497
Add Fix for Lock On Status Moves
...
These changes should fix the status move and secondary effects not working if the opponent is flying or digging but has been locked on.
2018-02-19 02:54:13 -06:00
Rangi
96c058f0a7
No redundant item effect labels
2018-02-05 13:03:05 -05:00
Rangi
6c405e3859
Keep specials files together
2018-02-04 12:03:31 -05:00
Rangi
885080f213
"chances" → "probabilities", since other files use that term and "changes" exists right next to it
2018-02-04 11:46:53 -05:00
Rangi
ac15415949
Sync _
2018-02-03 22:57:57 -05:00
Rangi
271aa20b73
Keep documentation in sync with new WRAM labels
2018-02-03 20:40:21 -05:00
Rangi
e32e5212af
use "x + -1" not "x +- 1"
...
(TODO: use "x - 1" once rgbds allows it)
2018-02-02 22:55:38 -05:00
Rangi
1282405d4a
SPRITEMOVEDATA_LAPRAS → SPRITEMOVEDATA_SWIM_WANDER
...
(more precise, and encourages hacks to add more SWIM movements)
2018-01-30 22:42:41 -05:00
Rangi
f5ba69f5e5
Sync documentation with code
2018-01-26 14:36:59 -05:00
Rangi
0cf4eb6895
Move-unique effect commands consistently go in engine/battle/move_effects/
2018-01-26 11:36:00 -05:00
Rangi
d719d318e8
Remove Special_ prefix from special routines ( close #478 )
2018-01-24 11:17:05 -05:00
Rangi
0261bd2ff5
Daisy offers "grooming", not "massage"
2018-01-23 00:11:23 -05:00
Remy Oukaour
7f54df58bf
Group engine/pokedex files
2018-01-21 18:00:23 -05:00
Remy Oukaour
05382d3e3c
PARTY_LENGTH; MON_NAME; sgb_border.bin
2018-01-20 12:25:55 -05:00
Remy Oukaour
2acaa96cf1
More charmap and home/text.asm documentation for JP chars
2018-01-18 18:34:20 -05:00
Remy Oukaour
6d20cf3e80
"CryHeader" → "Cry"; "Cry" → "MonCry"
2018-01-16 23:47:45 -05:00
Remy Oukaour
fe605b2fa7
Document the Magikarp bug fix from PR #443
2017-12-28 14:08:29 -05:00
Remy Oukaour
97dd40284b
Document another Magikarp length bug. (to do: correct formula values)
2017-12-28 13:17:43 -05:00
Remy Oukaour
b5ffbfe2af
Specify which bugs are needed for backwards compatibility
2017-12-28 12:58:18 -05:00
Remy Oukaour
7167895612
Document another bug
...
Document fixes for design flaws
GetForestTreeFrame is more like a design flaw than a bug/glitch (though it's really just calling out humorously bad code)
2017-12-28 12:49:32 -05:00
Remy Oukaour
0ceee9696a
Explain what bugs, glitches, and flaws are
2017-12-28 11:50:02 -05:00
Remy Oukaour
7a4d641251
Remove redundant data/ filename prefixes
2017-12-27 01:29:15 -05:00
Remy Oukaour
86fd37af16
Move events/ to engine/events/
2017-12-27 00:09:12 -05:00
