pokehacks/pokecrystal-board
0
0
Fork 0
mirror of https://gitlab.com/xCrystal/pokecrystal-board.git synced 2024-09-09 09:51:34 -07:00
Code Issues Packages Projects Releases Wiki Activity

Bug docs match code

Browse Source
This commit is contained in:
Rangi 2018-03-04 02:29:39 -05:00
parent 7e9dbde549
commit 159a0ef7b4
1 changed files with 10 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
docs/bugs_and_glitches.md
View File

@ -903,18 +903,20 @@ StartTrainerBattle_DetermineWhichAnimation: ; 8c365 (23:4365)
([Video](https://www.youtube.com/watch?v=iHkWubvxmSg))
This is a bug with `HallOfFame` in [engine/events/halloffame.asm](/engine/events/halloffame.asm):
This is a bug with `_HallOfFamePC.DisplayMonAndStrings` in [engine/events/halloffame.asm](/engine/events/halloffame.asm):
```asm
ld hl, wHallOfFameCount
ld a, [hl]
cp HOF_MASTER_COUNT - 1 ; should be HOF_MASTER_COUNT
jr nc, .ok
inc [hl]
.ok
ld a, [wHallOfFameTempWinCount]
cp HOF_MASTER_COUNT + 1 ; should be HOF_MASTER_COUNT
jr c, .print_num_hof
ld de, .HOFMaster
hlcoord 1, 2
call PlaceString
hlcoord 13, 2
jr .finish
```
**Fix:** Change `HOF_MASTER_COUNT - 1` to `HOF_MASTER_COUNT`.
**Fix:** Change `HOF_MASTER_COUNT + 1` to `HOF_MASTER_COUNT`.
## Slot machine payout sound effects cut each other off