Commit Graph

341 Commits

Author SHA1 Message Date
xCrystal
88b6810a18 Implement talker events [commit 1] (#30) 2023-11-28 13:59:36 +01:00
xCrystal
6613cd5386 Add anchor points to support manual movement between spaces (#26) 2023-11-16 17:20:13 +01:00
xCrystal
29bea311fe Rename PAL_OW_EMOTE and PAL_NPC_EMOTE to *_GREY 2023-11-05 11:07:32 +01:00
xCrystal
2df937cbee Implement View Map mode [commit 5]: make View Map mode work from branch space (#29) 2023-11-04 17:17:08 +01:00
xCrystal
d2bb82bc3c Implement View Map mode [commit 2]: mock player object (#29) 2023-11-01 11:48:12 +01:00
xCrystal
147c9f2add Implement View Map mode [commit 1] (#29) 2023-10-31 20:25:56 +01:00
xCrystal
2d6618f431 Macro for data of branch spaces (#28) 2023-10-28 20:57:59 +02:00
xCrystal
29f98ccb8c Effects of branch (and union) space [Commit 2] (#28) 2023-10-28 19:09:58 +02:00
xCrystal
a52e7f4df5 Effects of branch space [Commit 1] (#28) 2023-10-24 20:36:23 +02:00
xCrystal
b0e2e7aef3 Rename wCurSpaceData and wTempSpaceData to *SpaceStruct and create space_struct macro 2023-10-20 20:16:10 +02:00
xCrystal
806b048a9f Add wMapSpacesPointer to the map attributes (#4); create basic space macro to define the space layout of maps (#23) 2023-10-17 18:27:28 +02:00
xCrystal
0795c02a9c Functional stub of title menus: clean up return from overworld loop [Commit 2] (#17) 2023-10-01 00:39:18 +02:00
xCrystal
d6001be90c Sync with pokecrystal up to 8873506b1 2023-09-24 14:21:42 +02:00
xCrystal
ca919cdf98 Board menu: implement preliminary Party, Bag, Pokegear, and Exit submenus (#11) 2023-09-22 23:12:05 +02:00
xCrystal
eb728d5151 Rename the concept of Money to Coins (#7) 2023-09-02 23:17:20 +02:00
xCrystal
98fa7a9538 Rename the concept of Coins to Chips (#7) 2023-09-02 18:23:25 +02:00
xCrystal
e866cdab48 Level selection menu: function to compute valid directions and directional arrows OAM (#12) 2023-08-22 12:42:53 +02:00
vulcandth
438c48daad
Rename PAL_NPC_SILVER to PAL_NPC_EMOTE (#1053) 2023-06-01 07:47:53 -05:00
Idain
8c6242a152 Fix macro definitiosn for unused commands 2023-05-06 20:12:45 -04:00
vulcandth
c01409be5a
Relabel some map_object struct fields (#1029) 2023-01-03 22:16:08 -05:00
Rangi
8e135931a6 Require rgbds 0.6.0 2022-10-02 22:03:53 -04:00
Andrew Cook
0f5540740b
Some Mobile code labeling and removed magic numbers (#993)
* Macro loop for EmptyAllSRAMBanks

* Many things labeled and magic numbers removed

* Conform to the style guide

* Rename URLs in mobile_46

* MOBILEAPI_19 -> MOBILEAPI_TELEPHONESTATUS

* Update engine/menus/empty_sram.asm

Co-authored-by: Rangi <35663410+Rangi42@users.noreply.github.com>

* Update ram/wram.asm

Co-authored-by: Rangi <35663410+Rangi42@users.noreply.github.com>

* Update mobile/mobile_46.asm

Co-authored-by: Rangi <35663410+Rangi42@users.noreply.github.com>

* Update mobile/mobile_46.asm

Co-authored-by: Rangi <35663410+Rangi42@users.noreply.github.com>

* Remove underscore from Set*DownloadURL symbols

* Begin Labeling TradeCornerHoldMon routines

* Add wMobileMon party_struct

* Add TRADE_CORNER_REQUEST_LENGTH constant

* Name battle tower action functions

* Label trade corner send/receive buffer

* Label the saved copy of the trade corner pokemon

also fix mailmsg_jp

* So many copies of decodeBase64Character

* Label another buffer

* Fix Alignment and use MOBILE_EMAIL_LENGTH

* `Function11ad8a` -> `MobileIncJumptableIndex`

* Apply Rangi Suggestions pass 1

Co-Authored-By: Rangi <35663410+Rangi42@users.noreply.github.com>

* Apply Suggestions 2

Co-authored-by: Rangi <35663410+Rangi42@users.noreply.github.com>
Co-authored-by: vulcandth <vulcandth@gmail.com>
2022-09-14 19:49:58 -05:00
Rangi
41d5ea0482
Rename the object_struct field labels and constants (#1005)
Fixes #990
2022-09-12 09:15:44 -04:00
vulcandth
4c239a6f65
Rename macros/wram.asm to macros/ram.asm (#1003) 2022-09-11 01:05:07 -04:00
vulcandth
8ed7c392cd Fix order of parameters in dsprite macro
The parameters of the legacy dsprite macros were in the wrong order.
Fixes #1002

Co-Authored-By: Idain <54337884+Idain@users.noreply.github.com>
Co-Authored-By: Fredrik Ljungdahl <fredde1994@gmail.com>
2022-09-07 19:25:20 -05:00
Rangi
8826d97ee4
Define scene constants alongside scene_scripts (#979)
Generic SCENE_DEFAULT and SCENE_FINISHED are legacy values
2022-07-29 17:43:10 -04:00
Rangi
a2e8f078a4 Split "gfx anims" into "pic anims" and "sprite anims"
Fixes #876
2022-07-04 01:11:42 -04:00
vulcandth
3648afda16
RGBDS syntax updates (#905)
New MACRO and DEF syntax
2022-06-06 17:25:42 -04:00
Rangi
4d102dcb3f Allow vc_const to work with charmap characters (necessary for pokegold) 2022-03-13 23:21:27 -04:00
vulcandth
31c3c94d64
Build the Virtual Console patch with make crystal11_vc (#882)
Fixes #813
2022-03-12 18:34:04 -05:00
Rangi
418c70a8af Don't require a boolean trainer flag for givepoke
Fixes #865
2022-01-10 21:16:34 -05:00
Rangi
ab0f9c287a Use compound assignment operators 2021-11-23 20:18:08 -05:00
Rangi
860585b0af Clarify documentation of maskbits 2021-10-29 17:33:52 -04:00
Rangi
e4d82e92d0 Rename prioritysjump to sdefer 2021-06-08 20:35:04 -04:00
Rangi
ed0a0f7159 Move the dbbw, dbww, and dbwww macros to legacy 2021-05-30 15:51:49 -04:00
Rangi
b1dbadbdd3 Require rgbds 0.5.1
Use some new features: \<10> macro args, SECTION UNION, SIZEOF/STARTOF, and CHARLEN/CHARSUB
2021-05-09 12:26:28 -04:00
Rangi
efd1006917
Use {interpolation} to generate sequences of RAM labels
This makes the table_width/assert_table_length usages unnecessary, and also keeps the labels automatically up to date if the length constants change.
2021-04-27 12:11:39 -04:00
Rangi
316fa4b695 Use rgbds 0.5.0 2021-04-19 16:31:37 -04:00
Rangi
94057c7726 Verify uneven list sizes with list_start, li, and assert_list_length macros
This was discussed in #815
2021-03-22 17:17:08 -04:00
Rangi
dbe2360ecd Miscellaneous cleanup 2021-03-22 16:41:17 -04:00
Rangi
5037adc55f Clean up some macro definitions 2021-03-21 20:09:34 -04:00
Rangi
4522162d45 Consistent labels for each nickname in RAM 2021-03-17 16:38:21 -04:00
Rangi
d132a20b7a Verify script command table sizes 2021-03-11 16:28:52 -05:00
Rangi
98da09b3e9 Define more struct offset constants with rsreset instead of const_def
This was discussed in #739
2021-03-04 18:15:38 -05:00
Rangi
ef20126fe5 Verify wild data sizes with def_grass/water_wildmons and end_grass/water_wildmons macros 2021-03-04 17:58:30 -05:00
Rangi
40902ffe24 Verify data table sizes with table_width and assert_table_length macros
This was discussed in #706

It also uncovered some off-by-one issues with defining some constants.

A few structs now use rsreset/_RS to define their offset constants, as discussed in #739
2021-03-04 00:15:03 -05:00
Rangi
99e66c2557 Rename some labels
- Remove "Buffer" suffix from some byte and word quantities
- Change "Ptr" to "Pointer"

Fixes #789
2020-12-23 16:29:30 -05:00
Rangi
e485280a8a Require rgbds 0.4.2
This allows [\1] to work when \1 is hl, bc, or de

The object file format has changed along with the version number
2020-12-09 12:21:46 -05:00
Rangi
03e149e559 Identify wBattleAnimTemp0-3 2020-11-09 15:05:14 -05:00
Rangi
ba5bc304f9 Updates to more closely sync with pokegold 2020-10-29 23:23:57 -04:00