Rangi
40902ffe24
Verify data table sizes with table_width and assert_table_length macros
...
This was discussed in #706
It also uncovered some off-by-one issues with defining some constants.
A few structs now use rsreset/_RS to define their offset constants, as discussed in #739
2021-03-04 00:15:03 -05:00
Rangi
0e818f8b8b
Define SCENE_ALWAYS EQU -1 for coord_events
2021-03-01 21:11:58 -05:00
Rangi
a539578006
Merge pull request #798 from CelestialAmber/master
...
Fix typo
2021-02-05 09:45:18 -08:00
Fredrik Ljungdahl
8f4dcbcb59
Battle Tower: fix typo in constant (PROGESS -> PROGRESS)
2021-02-04 12:42:56 +01:00
Amber Brault
b391b6cef0
Fix typo
2021-01-21 11:01:53 -05:00
Rangi
6f226f584c
Identify link.asm WRAM labels based on ax6's research notes < https://pastebin.com/NTxjzKGQ >
2020-12-08 21:24:48 -05:00
Rangi
9fea403be2
grey -> gray
2020-12-08 14:34:54 -05:00
Neil Basu
900dc1b41b
document unused male grunts
2020-11-27 13:36:53 -08:00
Rangi
4613bcfadf
Use STRING_BUFFER_LENGTH for the wStringBuffers
2020-11-24 20:11:17 -05:00
Rangi
9b3c45b14d
Resolve some "???" comments
2020-11-17 11:09:02 -05:00
Rangi
6a5edc98e9
Terser damage calculation constants
2020-11-09 16:12:19 -05:00
Rangi
03e149e559
Identify wBattleAnimTemp0-3
2020-11-09 15:05:14 -05:00
Rangi
62b756c46e
Rename "dummy game" to "memory game"
2020-11-08 19:32:57 -05:00
Rangi
826e070f04
More syncing with pokegold
2020-11-03 10:13:06 -05:00
Rangi
9ab9088a9f
Identify wLinkBattleRNPreamble
2020-11-01 13:42:12 -05:00
Rangi
4a323cf591
UnusedSpriteAnimGFX was to sprite anims as AnimObjGFX is to battle anims
2020-10-30 17:41:03 -04:00
Rangi
fe1a58deea
Identify wSpriteAnimDict key constants
2020-10-30 15:39:08 -04:00
Rangi
1237156948
Identify mobile Name Card exchange labels
2020-10-30 10:45:31 -04:00
Rangi
ba5bc304f9
Updates to more closely sync with pokegold
2020-10-29 23:23:57 -04:00
Rangi
7883e8f431
Define SERIAL_LINK_BYTE_TIMEOUT
2020-10-29 16:43:28 -04:00
Rangi
ea426a8879
Identify more WRAM labels, and start a <X>_DummyFunction label convention
2020-10-28 14:34:38 -04:00
Rangi
446f1846b1
Identify remaining Mystery Gift labels and constants
...
Source: https://projectpokemon.org/home/forums/topic/43930-mystery-gift-reverse-engineering-of-ir-protocol/
2020-10-27 23:09:06 -04:00
Rangi
2738858985
Create data/collision/ for tile collision-related data
2020-10-27 10:00:56 -04:00
Rangi
9dcdad5e60
Comment, remove, or revise many unreferenced labels
2020-10-26 20:29:58 -04:00
Rangi
bd3f634049
Identify remaining map object labels
2020-10-22 21:30:21 -04:00
Rangi
d8310c166d
Identify some more map object labels and constants
2020-10-22 17:41:48 -04:00
Rangi
650686476c
Identify remaining battle AI labels
2020-10-21 21:34:18 -04:00
Rangi
2e90df15b7
Update battle anim bg function comments, and identify more unnamed labels
2020-10-06 18:09:33 -04:00
7Soul
cf26f55985
Identify battle bg effects functions and constants ( #773 )
...
Identify battle bg effects functions and constants
2020-10-06 15:45:09 -04:00
7Soul
836da09f4e
Identify anim object constants ( #772 )
...
Identify anim object constants
2020-10-04 15:06:38 -04:00
7Soul
2ffc5f907f
Identify battle animation functions ( #771 )
...
Identify battle animation functions
2020-10-03 21:54:02 -04:00
Rangi
4246553f9d
Fix whitespace alignment of comments
2020-09-27 12:31:07 -04:00
mid-kid
353f78f493
GS_INTRO_STAR/SPARKLE -> GS_GAMEFREAK_LOGO_STAR/SPARKLE
...
These two sprite animations are related to the Game Freak Logo splash
screen, not the actual intro.
2020-08-27 15:13:41 +02:00
mid-kid
13c4a93cea
Fix some constants surrounding sprite animations
...
Also commented the use of the field surrounding the struct
initialization functions.
SPRITEANIMSTRUCT_0C -> SPRITEANIMSTRUCT_VAR1
SPRITEANIMSTRUCT_0D -> SPRITEANIMSTRUCT_VAR2
SPRITEANIMSTRUCT_0E -> SPRITEANIMSTRUCT_VAR3
SPRITEANIMSTRUCT_0F -> SPRITEANIMSTRUCT_VAR4
BATTLEANIMSTRUCT_01 -> BATTLEANIMSTRUCT_OAMFLAGS
BATTLEANIMSTRUCT_ANON_JT_INDEX -> BATTLEANIMSTRUCT_JUMPTABLE_INDEX
BATTLEANIMSTRUCT_0F -> BATTLEANIMSTRUCT_VAR1
BATTLEANIMSTRUCT_10 -> BATTLEANIMSTRUCT_VAR2
2020-08-27 13:59:33 +02:00
Rangi
7729dcd204
Consistent constants for radio data table sizes (could still be better)
2020-08-13 13:47:50 -04:00
Rangi
ed3e70b97c
Identify some time-related data
2020-08-11 14:12:59 -04:00
Rangi
dd369f3199
Move EngineFlags and SpecialsPointers into data/engine/
2020-07-22 20:24:53 -04:00
Rangi
11dc805de0
Revert "Factor out tables into data/overworld/"
...
This reverts commit b5a7e7de3e
.
2020-07-22 20:21:26 -04:00
Rangi
b5a7e7de3e
Factor out tables into data/overworld/
...
Fixes #749
2020-07-22 15:22:58 -04:00
Rangi
d96f914315
Define JOHTO_FLYPOINT like KANTO_FLYPOINT
2020-07-21 12:15:14 -04:00
Rangi
a9941e28cc
Define NUM_FLYPOINTS
2020-07-21 11:48:39 -04:00
Rangi
59d9932255
SPRITE_GYM_GUY -> SPRITE_GYM_GUIDE
2020-07-17 13:01:48 -04:00
Rangi
eca33ef190
Define map setup commands as macros like other script commands
2020-07-13 20:44:16 -04:00
Rangi
e239aa4aba
Disassemble the final English debug ROM
2020-07-13 15:18:28 -04:00
Rangi
c086de0c98
Use const_skip and const_next macros for brevity
2020-07-10 20:03:46 -04:00
Rangi
6ca82e5c86
Eliminate enum: use const instead, with case-by-case parallel const implementations
2020-07-08 15:30:23 -04:00
Rangi
43a9295789
add_tm, add_hm, and add_mt define TM##_MOVE, HM##_MOVE, and MT##_MOVE constants, to avoid repeating the move names in tmhm_moves.asm
2020-07-06 16:53:05 -04:00
Rangi
ddf1163a21
Define SERIAL_PREAMBLE_LENGTH
2020-07-06 15:49:01 -04:00
Rangi
7eef66af3f
Use MAX_NEUTRAL_DAMAGE in BattleCommand_DamageCalc
...
Also make .gitignore consistent with pokered
2020-07-05 15:12:53 -04:00
Rangi
f5ac9b0eb7
SCGB_PARTY_MENU_HP_PALS -> SCGB_PARTY_MENU_HP_BARS, and SCGB_RAM -> SCGB_DEFAULT
2020-07-04 16:18:16 -04:00