Commit Graph

221 Commits

Author SHA1 Message Date
Rangi
ec1fe073a3 $11 = wTempMonStructEnd - wTempMonLevel 2021-03-15 15:40:48 -04:00
Rangi
40902ffe24 Verify data table sizes with table_width and assert_table_length macros
This was discussed in #706

It also uncovered some off-by-one issues with defining some constants.

A few structs now use rsreset/_RS to define their offset constants, as discussed in #739
2021-03-04 00:15:03 -05:00
Rangi
4264d53eb6 Identify some more labels 2021-02-05 12:44:21 -05:00
Rangi
7d3ea88611 Rename GetFarHalfword to GetFarWord
Fixes #796
2021-01-09 15:16:05 -05:00
Rangi
5db892782a Remove "Buffer" suffix from two HRAM labels 2020-12-23 16:54:28 -05:00
Rangi
99e66c2557 Rename some labels
- Remove "Buffer" suffix from some byte and word quantities
- Change "Ptr" to "Pointer"

Fixes #789
2020-12-23 16:29:30 -05:00
Rangi
9fea403be2 grey -> gray 2020-12-08 14:34:54 -05:00
Rangi
4ef556cbc8 Document AI_Smart_Conversion2 bug (resolves #786) 2020-12-07 13:13:03 -05:00
Rangi
4613bcfadf Use STRING_BUFFER_LENGTH for the wStringBuffers 2020-11-24 20:11:17 -05:00
Rangi
9b3c45b14d Resolve some "???" comments 2020-11-17 11:09:02 -05:00
Rangi
6a5edc98e9 Terser damage calculation constants 2020-11-09 16:12:19 -05:00
Rangi
7254c10093 Identify remaining uses of wBuffer1-6 as general-purpose HP buffers or mobile 2020-11-03 23:25:22 -05:00
Rangi
9f62d7911b Identify some more uses of wBuffer1-6 2020-11-03 22:45:12 -05:00
Rangi
c88c4a8340 Identify more uses of wBuffer1-6 2020-11-03 19:53:07 -05:00
Rangi
826e070f04 More syncing with pokegold 2020-11-03 10:13:06 -05:00
Rangi
6220200f0f Identify some more labels, and make some more consistent 2020-11-01 12:36:38 -05:00
Rangi
ba5bc304f9 Updates to more closely sync with pokegold 2020-10-29 23:23:57 -04:00
Rangi
bcc0d633e9 Identify the remaining (non-mobile) uses of another WRAM union 2020-10-29 14:51:41 -04:00
Rangi
ea426a8879 Identify more WRAM labels, and start a <X>_DummyFunction label convention 2020-10-28 14:34:38 -04:00
Rangi
6d333bed5f Replace many '; unused' with '; unreferenced' 2020-10-28 10:21:10 -04:00
Rangi
c85ba78b77 Use more assertions to ensure correct code and data 2020-10-26 22:24:38 -04:00
Rangi
9dcdad5e60 Comment, remove, or revise many unreferenced labels 2020-10-26 20:29:58 -04:00
Rangi
bd3f634049 Identify remaining map object labels 2020-10-22 21:30:21 -04:00
Rangi
ae4fe08084 Identify some more labels (a few link-related) 2020-10-22 00:53:54 -04:00
Rangi
650686476c Identify remaining battle AI labels 2020-10-21 21:34:18 -04:00
Rangi
93dcc8b6eb Identify SwitchItemsInBag labels
Thanks to FIQ for having done so in Polished Crystal
2020-10-21 15:39:15 -04:00
Rangi
7b12060e6a Battle transition spin quadrants are like pokered's half circles 2020-10-19 20:27:19 -04:00
Rangi
2e90df15b7 Update battle anim bg function comments, and identify more unnamed labels 2020-10-06 18:09:33 -04:00
Rangi
fc08ff2c38 Identify some unnamed labels 2020-10-06 13:50:02 -04:00
Rangi
6b7ade66da Identify more unnamed labels 2020-10-05 16:15:57 -04:00
Rangi
ff2d850219 Identify some more unnamed labels 2020-10-05 12:02:56 -04:00
Rangi
306c85750e Identify some more unnamed labels 2020-10-04 20:10:39 -04:00
Rangi
cf37abd3ec Remove wKickCounter and wPresentPower aliases for wBattleAnimParam 2020-08-29 20:35:49 -04:00
Rangi
0b31d12dac
Merge pull request #756 from mid-kid/master
Rub a dub dub, thanks for the grub
2020-08-18 16:35:15 -04:00
Rangi
ed3e70b97c Identify some time-related data 2020-08-11 14:12:59 -04:00
mid-kid
b6055b1944 Use TRUE for hCGBPalUpdate 2020-08-05 16:02:48 +02:00
mid-kid
2d2a7dec7d Label some mobile battle screen functions 2020-08-03 23:35:18 +02:00
Rangi
bb25c1074c Use LOAD/ENDL for OAM DMA code in HRAM (requires rgbds 0.4.1) 2020-07-21 19:45:25 -04:00
Rangi
e239aa4aba Disassemble the final English debug ROM 2020-07-13 15:18:28 -04:00
Rangi
7eef66af3f Use MAX_NEUTRAL_DAMAGE in BattleCommand_DamageCalc
Also make .gitignore consistent with pokered
2020-07-05 15:12:53 -04:00
Rangi
f2efda1f68 Identify more unnamed labels 2020-06-29 12:25:58 -04:00
Rangi
91774f206e Replace "Unreferenced" labels with "; unreferenced" comments 2020-06-21 16:27:43 -04:00
Rangi
98af69691d Remove some more raw addresses 2020-06-21 12:21:47 -04:00
Rangi
273324e787 pushd/popd are bash-only 2020-06-20 22:44:01 -04:00
Rangi
cc460a17b0 Harmonize engine/{movie, pokemon} with pokegold (renames GetSRAMBank to OpenSRAM)
To do: engine/{menus, overworld}
2020-06-17 17:03:38 -04:00
Rangi
f76dabedcc Harmonize engine/{battle, battle_anims, events, games} with pokegold 2020-06-16 19:32:36 -04:00
Rangi
e3f07b9612 Undo incorrect comment 2020-06-15 10:26:10 -04:00
Rangi
ffbca4d5f3 Adding 0 is pointless in CheckMimicUsed 2020-06-15 08:43:40 -04:00
Rangi
75035a71a5 Label some mobile addresses, and revise some comments 2020-06-13 18:48:26 -04:00
Rangi
cdafd41ef0 Remove address-related comment 2020-06-10 16:45:04 -04:00