vulcandth
bceeea8e3b
Fix Typo: GoldenrodPokecomCenterSaveBeforeTradeCornetText -> GoldenrodPokecomCenterSaveBeforeTradeCornerText
2022-09-24 20:04:28 -05:00
Rangi
8fc3b8e6e3
Dance Theatre -> Dance Theater
...
Fixes #1008
2022-09-23 22:06:52 -04:00
Rangi
0d5cf5c8b9
Refer to "Rival", not "Silver" ( #983 )
...
Fixes #982
2022-08-10 21:24:56 -04:00
vulcandth
c3331eb7b1
Rename scene and callback labels ( #981 )
...
Co-authored-by: Rangi <35663410+Rangi42@users.noreply.github.com>
2022-08-09 18:04:18 -04:00
Rangi
8826d97ee4
Define scene constants alongside scene_scripts ( #979 )
...
Generic SCENE_DEFAULT and SCENE_FINISHED are legacy values
2022-07-29 17:43:10 -04:00
vulcandth
ef9b9bb437
Clean up bugs commented in the source code ( #912 )
...
Co-authored-by: Rangi <remy.oukaour+rangi42@gmail.com>
2022-07-09 16:12:02 -05:00
vulcandth
3648afda16
RGBDS syntax updates ( #905 )
...
New MACRO and DEF syntax
2022-06-06 17:25:42 -04:00
Idain
d0c8f63f25
Rename ENGINE_FISH_SWARM to ENGINE_QWILFISH_SWARM ( #879 )
2022-02-22 09:47:05 -05:00
vulcandth
145ab57aba
Fixed IlexForestKurtStepsDownMovement capitalization typo ( #877 )
2022-02-13 13:39:45 -05:00
Rangi
418c70a8af
Don't require a boolean trainer flag for givepoke
...
Fixes #865
2022-01-10 21:16:34 -05:00
Rangi
e4d82e92d0
Rename prioritysjump to sdefer
2021-06-08 20:35:04 -04:00
Rangi
90ce126139
Use numeric constants in text strings with "{d:interpolation}"
2021-03-21 18:14:31 -04:00
Rangi
6c8f8609cb
Assert some more table widths
2021-03-17 11:38:01 -04:00
Rangi
97a11c623e
Sync some files with pokegold
2021-03-11 17:43:20 -05:00
Rangi
3c3d87e765
Use NITE_HOUR constant for Buena's event
2021-02-16 15:58:09 -05:00
Rangi
d10b168c6f
Identify unreferenced Goldenrod Pokémon Center text labels
2021-02-05 13:56:39 -05:00
Rangi
4264d53eb6
Identify some more labels
2021-02-05 12:44:21 -05:00
Rangi
c88c4a8340
Identify more uses of wBuffer1-6
2020-11-03 19:53:07 -05:00
Rangi
826e070f04
More syncing with pokegold
2020-11-03 10:13:06 -05:00
Rangi
6d333bed5f
Replace many '; unused' with '; unreferenced'
2020-10-28 10:21:10 -04:00
Rangi
9dcdad5e60
Comment, remove, or revise many unreferenced labels
2020-10-26 20:29:58 -04:00
Rangi
7991db972b
Identify some more link.asm labels (syncing to pokegold)
2020-10-23 13:36:54 -04:00
Rangi
0e3857eac7
Identify unused Route 40 movement data
2020-10-21 16:09:56 -04:00
Rangi
3cd7b9e52e
Consistent (x, y) coordinates for ugdoor macro
2020-10-21 15:39:50 -04:00
Rangi
ff2d850219
Identify some more unnamed labels
2020-10-05 12:02:56 -04:00
Rangi
169470378a
Identify movement labels in map scripts
2020-10-04 18:15:38 -04:00
Rangi
51352aaa4d
Use EGG_LEVEL for Togepi egg
2020-09-27 12:31:39 -04:00
Rangi
dcb24bc724
Use def_* macros for automatic map event counts
...
Resolves #742
2020-07-24 09:57:16 -04:00
Rangi
59d9932255
SPRITE_GYM_GUY -> SPRITE_GYM_GUIDE
2020-07-17 13:01:48 -04:00
Rangi
ef452ccbc7
return → endcallback, reloadandreturn → reloadend
2020-07-17 08:37:03 -04:00
Rangi
c086de0c98
Use const_skip and const_next macros for brevity
2020-07-10 20:03:46 -04:00
Rangi
73d20afd15
Use pokepret account for committing to symbols branch
2020-06-22 17:25:42 -04:00
Rangi
61847b3596
Identify some more labels
2020-06-22 16:30:13 -04:00
Rangi
91774f206e
Replace "Unreferenced" labels with "; unreferenced" comments
2020-06-21 16:27:43 -04:00
Rangi
ac0025064f
Identify some more Unknown labels
2020-06-20 18:52:26 -04:00
Rangi
f2550fc3c2
ReplaceKrisSprite -> UpdatePlayerSprite
2020-06-16 19:38:00 -04:00
Rangi
7b2515d1e4
[in progress] Harmonize more constant and data files with pokegold
2020-06-16 14:32:57 -04:00
Rangi
b9f2b93c17
Harmonize some more symbols with pokegold
2020-06-16 11:28:52 -04:00
Rangi
401aa383e2
make DEBUG=1 logs all symbols in the .map and .sym files
2020-06-14 21:52:33 -04:00
Rangi
75035a71a5
Label some mobile addresses, and revise some comments
2020-06-13 18:48:26 -04:00
Rangi
518cee440e
Resolve #723 : treat std scripts like specials and predefs
2020-06-10 16:44:16 -04:00
Rangi
b69526a908
Miscellaneous fixes
...
Addresses the haircut brothers' probability comments in #709
2020-05-05 10:17:02 -04:00
Rangi
58b377f25b
Fix #709 miscellaneous issues
2020-04-16 09:30:50 -04:00
Rangi
0345e4fb0e
Add suffixes to some constants to avoid ambiguity
...
- `PSYCHIC` → `PSYCHIC_TYPE` (not the trainer `PSYCHIC_T` or the move `PSYCHIC_M`)
- `BLACKBELT` → `BLACKBELT_I` (not the trainer `BLACKBELT_T`)
- `CURSE_T` → `CURSE_TYPE` (not the move `CURSE`)
- `TOWN_MAP_D` → `TOWN_MAP_POSTER` (not the item `TOWN_MAP`)
This also uncovered a misidentified event: `EVENT_DECO_PLANT_4` → `EVENT_DECO_POSTER_1`. (There are three plants and four posters.)
2020-03-21 17:59:26 -04:00
mid-kid
317188b35f
Correct fash ship typos
2020-02-16 12:22:13 +01:00
mid-kid
d00167d6b8
Make all decorations use consistent names
...
If we're not going to prefix the decos, don't prefix any of them.
2019-11-18 18:21:08 +01:00
Rangi
9ebe549347
Merge pull request #654 from Rangi42/master
...
Miscellaneous cleanup issues
2019-11-04 19:40:58 -05:00
Rangi
fbe2494dc2
Miscellaneous label and comment corrections
2019-11-03 14:47:06 -05:00
Rangi
4aeab6b879
Rename buttonsound to promptbutton
2019-11-03 12:48:54 -05:00
DeeDeeG
3234cb1117
VioletPokecenter1F.asm: Rename an NPC constant
...
"VIOLETPOKECENTER1F_SCIENTIST" --> "VIOLETPOKECENTER1F_ELMS_AIDE"
2019-10-20 22:15:52 -04:00
