vulcandth
5f0597e944
Rename SLP to SLP_MASK ( #918 )
...
Co-authored-by: Rangi <35663410+Rangi42@users.noreply.github.com>
2022-06-17 22:25:56 -04:00
vulcandth
a4d346cc8c
Improved Virtual Console patch identifiers ( #907 )
2022-06-06 17:22:48 -04:00
vulcandth
31c3c94d64
Build the Virtual Console patch with make crystal11_vc ( #882 )
...
Fixes #813
2022-03-12 18:34:04 -05:00
Rangi
0ffdb65210
Better comments for enemy health percentage code
2022-01-10 21:25:43 -05:00
Idain
67207fab94
Identify why five of six enemy mon base stats are copied ( #866 )
...
Co-authored-by: Rangi <35663410+Rangi42@users.noreply.github.com>
2022-01-08 13:42:40 -05:00
Rangi
1f9e688b76
MON_PKRUS -> MON_POKERUS
2021-06-07 20:00:21 -04:00
Rangi
efd1006917
Use {interpolation} to generate sequences of RAM labels
...
This makes the table_width/assert_table_length usages unnecessary, and also keeps the labels automatically up to date if the length constants change.
2021-04-27 12:11:39 -04:00
Rangi
dbe2360ecd
Miscellaneous cleanup
2021-03-22 16:41:17 -04:00
Rangi
4522162d45
Consistent labels for each nickname in RAM
2021-03-17 16:38:21 -04:00
Rangi
ec1fe073a3
$11 = wTempMonStructEnd - wTempMonLevel
2021-03-15 15:40:48 -04:00
Rangi
4264d53eb6
Identify some more labels
2021-02-05 12:44:21 -05:00
Rangi
5db892782a
Remove "Buffer" suffix from two HRAM labels
2020-12-23 16:54:28 -05:00
Rangi
99e66c2557
Rename some labels
...
- Remove "Buffer" suffix from some byte and word quantities
- Change "Ptr" to "Pointer"
Fixes #789
2020-12-23 16:29:30 -05:00
Rangi
9fea403be2
grey -> gray
2020-12-08 14:34:54 -05:00
Rangi
9b3c45b14d
Resolve some "???" comments
2020-11-17 11:09:02 -05:00
Rangi
7254c10093
Identify remaining uses of wBuffer1-6 as general-purpose HP buffers or mobile
2020-11-03 23:25:22 -05:00
Rangi
9f62d7911b
Identify some more uses of wBuffer1-6
2020-11-03 22:45:12 -05:00
Rangi
c88c4a8340
Identify more uses of wBuffer1-6
2020-11-03 19:53:07 -05:00
Rangi
6220200f0f
Identify some more labels, and make some more consistent
2020-11-01 12:36:38 -05:00
Rangi
bcc0d633e9
Identify the remaining (non-mobile) uses of another WRAM union
2020-10-29 14:51:41 -04:00
Rangi
ea426a8879
Identify more WRAM labels, and start a <X>_DummyFunction label convention
2020-10-28 14:34:38 -04:00
Rangi
c85ba78b77
Use more assertions to ensure correct code and data
2020-10-26 22:24:38 -04:00
Rangi
9dcdad5e60
Comment, remove, or revise many unreferenced labels
2020-10-26 20:29:58 -04:00
Rangi
ae4fe08084
Identify some more labels (a few link-related)
2020-10-22 00:53:54 -04:00
Rangi
2e90df15b7
Update battle anim bg function comments, and identify more unnamed labels
2020-10-06 18:09:33 -04:00
Rangi
6b7ade66da
Identify more unnamed labels
2020-10-05 16:15:57 -04:00
mid-kid
2d2a7dec7d
Label some mobile battle screen functions
2020-08-03 23:35:18 +02:00
Rangi
f2efda1f68
Identify more unnamed labels
2020-06-29 12:25:58 -04:00
Rangi
91774f206e
Replace "Unreferenced" labels with "; unreferenced" comments
2020-06-21 16:27:43 -04:00
Rangi
98af69691d
Remove some more raw addresses
2020-06-21 12:21:47 -04:00
Rangi
273324e787
pushd/popd are bash-only
2020-06-20 22:44:01 -04:00
Rangi
cc460a17b0
Harmonize engine/{movie, pokemon} with pokegold (renames GetSRAMBank to OpenSRAM)
...
To do: engine/{menus, overworld}
2020-06-17 17:03:38 -04:00
Rangi
f76dabedcc
Harmonize engine/{battle, battle_anims, events, games} with pokegold
2020-06-16 19:32:36 -04:00
Rangi
75035a71a5
Label some mobile addresses, and revise some comments
2020-06-13 18:48:26 -04:00
Rangi
5f197c53f4
Clean up some percentage values
2020-05-07 14:21:24 -04:00
Rangi
b50dd57cbb
Miscellaneous updates and corrections
2020-04-23 16:14:50 -04:00
mid-kid
2a8c969bc7
Fix some comments and inmediates
2020-02-21 21:10:55 +01:00
mid-kid
26b8bf003e
Standardize on lowercase Tilemap and Attrmap
...
We used to have a mixture of TileMap and and Tilemap, as well as the
similar AttrMap. Standardize on one.
2020-02-13 18:31:10 +01:00
mid-kid
34ceaac71d
Call_LoadTempTileMapToTileMap → SafeLoadTempTileMapToTileMap
...
Stupid name is stupid smh tbh fam.
2020-02-13 18:31:10 +01:00
Rangi
80cf859cd3
PHONE_DISPLAY_HEIGHT is 4, the number of visible phone entries
2020-01-19 14:10:10 -05:00
bbbbbbbbba
0d48d829d4
Document Special Defense badge boost glitch ( #651 )
...
Document Special Defense badge boost glitch
2019-10-20 18:25:34 -04:00
mid-kid
e3e0bcd653
#641 fixes and additions. ( #646 )
...
Name a lot of text labels according to our conventions
2019-10-20 18:24:17 -04:00
mid-kid
3e78e5b2b6
TextBox -> Textbox
...
Homogenizing names.
2019-04-09 16:09:18 +02:00
ISSOtm
c57ed5775c
Rename PlayerMonFaintHappinessMod
...
Seriously, mini-rant here: we were three to spend a couple hours trying to find something in this function
that was completely unrelated to happiness... and apparently there's been far worse. :')
Props to you guys for having been through this =D
2019-03-03 23:55:24 +01:00
Rangi
a999787cb8
Update documentation:
...
- Apply more edits from #595
- Move music ID behavior from the wiki to docs
- Move assembly programming links from docs to the wiki
- Describe why the TM item gaps exist
2019-02-17 13:18:38 -05:00
Rangi
1853e3d127
Say "BANK(Foo) ; aka BANK(Bar)" to clarify that Foo and Bar share a bank
2019-01-12 15:17:20 -05:00
Rangi
26fc7e2521
Consistent formatting in Function_SetEnemyMonAndSendOutAnimation and BattleStartMessage
2019-01-06 22:11:57 -05:00
Rangi
f2785cdb71
Use battle menu flags
2018-12-31 14:25:53 -05:00
mid-kid
930d285fab
Fix comments around BANK() statements
...
Found a couple BANK()s that reference multiple labels.
2018-12-26 21:58:13 +01:00
Rangi
f6ecb681d5
Fix issue #581 (random stuff ax6 noticed)
2018-12-23 03:45:41 -05:00
