vulcandth
|
ef9b9bb437
|
Clean up bugs commented in the source code (#912)
Co-authored-by: Rangi <remy.oukaour+rangi42@gmail.com>
|
2022-07-09 16:12:02 -05:00 |
|
Rangi
|
9dcdad5e60
|
Comment, remove, or revise many unreferenced labels
|
2020-10-26 20:29:58 -04:00 |
|
Rangi
|
dcb24bc724
|
Use def_* macros for automatic map event counts
Resolves #742
|
2020-07-24 09:57:16 -04:00 |
|
Rangi
|
ef452ccbc7
|
return → endcallback, reloadandreturn → reloadend
|
2020-07-17 08:37:03 -04:00 |
|
Rangi
|
4aeab6b879
|
Rename buttonsound to promptbutton
|
2019-11-03 12:48:54 -05:00 |
|
Rangi
|
745339014c
|
"object_const_def" instead of "const_def 2"
|
2019-04-21 17:42:25 -04:00 |
|
Rangi
|
f5c9958aea
|
Rename some call/jump script commands to avoid confusion with jr/jp asm instructions
Fixes #580
|
2019-03-10 16:39:31 -04:00 |
|
Rangi
|
e002b536af
|
Rename more script commands for consistency and predictability
Fixes #540
|
2019-03-10 16:00:19 -04:00 |
|
Rangi
|
3202c4f3df
|
Resolve issue #575: Rename text commands
|
2018-11-18 12:41:11 -05:00 |
|
Rangi
|
5a6e43e72a
|
Label more map scripts
|
2018-02-28 16:50:43 -05:00 |
|
Rangi
|
43b5f90457
|
Replace "Map<MapName>Signpost<#>Script" labels
|
2018-02-27 19:33:38 -05:00 |
|
Rangi
|
f964d04a87
|
* loadmenuheader -> loadmenu (ead103d )
* objectface -> turnobject (c834bda )
|
2018-02-25 20:05:37 -05:00 |
|
Rangi
|
32ed487a47
|
Merge branch 'master' of https://github.com/pret/pokecrystal
# Conflicts:
# audio/engine.asm
# constants/gfx_constants.asm
# constants/map_data_constants.asm
# constants/pokemon_data_constants.asm
# constants/sprite_constants.asm
# constants/wram_constants.asm
# data/maps/data.asm
# engine/battle/ai/scoring.asm
# engine/battle/core.asm
# engine/battle/effect_commands.asm
# engine/battle/misc.asm
# engine/battle_anims/getpokeballwobble.asm
# engine/breeding.asm
# engine/buy_sell_toss.asm
# engine/decorations.asm
# engine/events/battle_tower/battle_tower.asm
# engine/events/battle_tower/rules.asm
# engine/events/buena.asm
# engine/events/bug_contest/contest_2.asm
# engine/events/daycare.asm
# engine/events/dratini.asm
# engine/events/halloffame.asm
# engine/events/happiness_egg.asm
# engine/events/kurt.asm
# engine/events/lucky_number.asm
# engine/events/magnet_train.asm
# engine/events/overworld.asm
# engine/events/pokerus/pokerus.asm
# engine/events/print_unown.asm
# engine/events/print_unown_2.asm
# engine/events/unown_walls.asm
# engine/item_effects.asm
# engine/link.asm
# engine/mon_menu.asm
# engine/player_object.asm
# engine/routines/playslowcry.asm
# engine/scripting.asm
# engine/search.asm
# engine/search2.asm
# engine/specials.asm
# engine/start_menu.asm
# engine/timeset.asm
# home/battle_vars.asm
# home/map.asm
# maps/GoldenrodUndergroundSwitchRoomEntrances.asm
# maps/IlexForest.asm
# maps/KrissHouse2F.asm
# maps/Route39Barn.asm
# mobile/mobile_12_2.asm
# mobile/mobile_40.asm
# mobile/mobile_5f.asm
# wram.asm
|
2018-02-03 19:42:56 -05:00 |
|
Rangi
|
c834bdadf2
|
spriteface → objectface, consistent with the other script commands
|
2018-02-02 21:50:43 -05:00 |
|
Rangi
|
68d855c213
|
Script commands don't have underscores
|
2018-02-02 21:09:17 -05:00 |
|
Rangi
|
48f4f2366e
|
Align map event coordinate columns
|
2018-02-01 22:22:07 -05:00 |
|
Rangi
|
3088a77a21
|
warp_event x, y, map, warp_id
|
2018-02-01 21:54:00 -05:00 |
|
Rangi
|
fcfe77bc3d
|
Meaningful scene constant names
(Two common patterns: 0=default event and 1=nothing; and 0=nothing and 1=some event)
|
2018-02-01 13:03:21 -05:00 |
|
Rangi
|
a17623d96b
|
Add scene ID constants (TODO: meaningful names)
|
2018-01-31 23:16:51 -05:00 |
|
Rangi
|
08891da822
|
const_def N
|
2018-01-31 11:38:45 -05:00 |
|
Rangi
|
50a78c0876
|
Forgot the person→object rename
|
2018-01-31 11:08:47 -05:00 |
|
Rangi
|
a2607623d3
|
Comment the person constants sections, like the others
|
2018-01-31 11:04:17 -05:00 |
|
Rangi
|
cb733954c6
|
SPRITEMOVEDATA_ITEM_TREE → SPRITEMOVEDATA_STILL (it's used for other things like Azalea's Slowpokes, not just items and trees)
|
2018-01-30 22:12:53 -05:00 |
|
Rangi
|
65480605e9
|
Remove unreferenced map script heading labels
|
2018-01-30 14:15:47 -05:00 |
|
Rangi
|
477adc72af
|
grep -rl warp_def . | xargs sed -i s/warp_def/warp_event/g
|
2018-01-28 13:20:04 -05:00 |
|
Rangi
|
d719d318e8
|
Remove Special_ prefix from special routines (close #478)
|
2018-01-24 11:17:05 -05:00 |
|
Rangi
|
505a6595bc
|
EVENT_TEMPORARY_UNTIL_MAP_RELOAD_[1-8] (close issue #481)
|
2018-01-24 10:46:49 -05:00 |
|
luckytyphlosion
|
a1951cefc0
|
Prefix wram labels with w, part 2.
|
2018-01-23 17:39:09 -05:00 |
|
Rangi
|
8f2878c37e
|
trainers put the class and id first: trainer YOUNGSTER, JOEY1, ...
|
2018-01-23 13:08:48 -05:00 |
|
Rangi
|
dea26c6639
|
hiddenitem, like itemball and object_event, puts the item first and the event last
|
2018-01-23 12:59:21 -05:00 |
|
Remy Oukaour
|
bf074f3598
|
map_header → map_def; map_header_2 → map_data
|
2018-01-16 23:25:00 -05:00 |
|
Remy Oukaour
|
5a3822fe86
|
Introduce callback, hiddenitem, conditional_event, and cmdqueue macros for map scripts
|
2018-01-13 00:47:38 -05:00 |
|
Remy Oukaour
|
d83aefb30a
|
Use more constants in scripts
|
2018-01-12 02:27:42 -05:00 |
|
Remy Oukaour
|
2f0973f3e0
|
Clean up some hex values in map scripts
|
2018-01-09 18:45:25 -05:00 |
|
Remy Oukaour
|
84e22eb578
|
Consistent (x, y) coordinate formatting in map scripts
|
2017-12-28 14:31:25 -05:00 |
|
Remy Oukaour
|
c05b7f41dd
|
Renaming: (fix #412)
- MapTriggers / maptrigger → SceneScripts / scene_script
- XYTriggers / xy_trigger → CoordEvents / coord_event
- Signposts / signpost → BGEvents / bg_event
- PersonEvents / person_event → ObjectEvents / object_event
|
2017-12-24 14:33:17 -05:00 |
|
Remy Oukaour
|
17058aaec2
|
Auto-label more map scripts
|
2017-12-17 20:56:35 -05:00 |
|
Remy Oukaour
|
047c8e4bc0
|
xy_trigger handles $0 padding, so map scripts are simpler
|
2017-12-12 14:11:23 -05:00 |
|
Remy Oukaour
|
b4261d27d8
|
Use new palette constants
|
2017-12-10 20:50:08 -05:00 |
|
Remy Oukaour
|
62f5913943
|
All map triggers use the maptrigger macro, not dw
.MapTriggers and .MapCallbacks lists are formatted consistently with .Warps, .XYTriggers, .Signposts, and .PersonEvents
|
2017-12-10 17:53:21 -05:00 |
|
Remy Oukaour
|
66527d861f
|
"Trainer*AfterBattleText" labels
|
2017-12-10 15:44:41 -05:00 |
|
pikalaxalt
|
1fa6aecbfc
|
Unify directional movement macros
|
2016-05-14 13:46:14 -04:00 |
|
PikalaxALT
|
ce019e6347
|
Map callback constants
|
2016-01-06 07:44:50 -05:00 |
|
PikalaxALT
|
80aba7fc13
|
maptrigger macro
|
2016-01-05 08:46:37 -05:00 |
|
PikalaxALT
|
efe3462f9a
|
Replaced SignpostItem with Hidden(ItemName)
|
2015-12-15 11:21:58 -05:00 |
|
PikalaxALT
|
bb2aba7da1
|
No more ItemFragment
|
2015-12-15 10:55:56 -05:00 |
|
PikalaxALT
|
3980d2d736
|
.TriggerX labels are now consistently 0-based
|
2015-12-10 22:28:46 -05:00 |
|
PikalaxALT
|
a5a8364c35
|
opentext and breeding
|
2015-12-09 18:25:44 -05:00 |
|
PikalaxALT
|
0c4bf512d0
|
itemfragment
|
2015-12-09 11:57:08 -05:00 |
|
PikalaxALT
|
92a8c491c3
|
Break up engine/sprites.asm; address yenatch's comments
|
2015-12-01 21:54:11 -05:00 |
|