Commit Graph

459 Commits

Author SHA1 Message Date
Rangi
fbe2494dc2 Miscellaneous label and comment corrections 2019-11-03 14:47:06 -05:00
Rangi
4aeab6b879 Rename buttonsound to promptbutton 2019-11-03 12:48:54 -05:00
mid-kid
e3e0bcd653 #641 fixes and additions. (#646)
Name a lot of text labels according to our conventions
2019-10-20 18:24:17 -04:00
Rangi
b24cd55f96 Correct the older+younger haircut brothers' labels and constants 2019-05-18 13:27:32 -04:00
DeeDeeG
80e89b5539 PokemonFanClub.asm: Update NPC names
Includes the following NPC constant renames:

POKEMONFANCLUB_PRESIDENT --> POKEMONFANCLUB_CHAIRMAN
POKEMONFANCLUB_FISHER --> POKEMONFANCLUB_CLEFAIRY_GUY

Also update the Clefairy doll and Bayleef text labels.
2019-04-28 01:31:58 -04:00
DeeDeeG
3d5467abc8 maps/PokemonFanClub.asm: Re-label UnknownText 2019-04-28 00:59:46 -04:00
DeeDeeG
51e6317164 SaffronMagnetTrainStation.asm: Re-label UnknownText, MovementData 2019-04-28 00:28:49 -04:00
DeeDeeG
099c01be3f GoldenrodPokecenter1F.asm: Re-label UnknownText, MovementData
Mostly gave non-placeholder labels for the unused GS Ball event.
Also did so for PokeFanF.

Left alone all the unused text about trading and news.
2019-04-28 00:02:37 -04:00
DeeDeeG
35d64c30d7 GoldenrodMagnetTrainStation.asm: Label UnknownText, MovementData 2019-04-27 22:52:32 -04:00
DeeDeeG
f1187dc860 GoldenrodCity.asm: label UnknownText, MovementData 2019-04-27 22:31:24 -04:00
DeeDeeG
82aea0f71e GoldenrodDeptStore5F.asm: Re-label UnknownText 2019-04-27 21:45:39 -04:00
DeeDeeG
318d042e6c Route35GoldenrodGate.asm: Rename an NPC
ROUTE35GOLDENRODGATE_OFFICER --> ROUTE35GOLDENRODGATE_RANDY
2019-04-27 21:45:32 -04:00
DeeDeeG
e47fbb22f2 Route35GoldenrodGate.asm: Re-label UnknownText 2019-04-27 21:44:24 -04:00
DeeDeeG
c6b19dfba2 GoldenrodFlowerShop.asm: Re-label UnknownText 2019-04-27 21:44:24 -04:00
DeeDeeG
f0cd72140a GoldenrodUnderground.asm: Rename some NPCs
GOLDENRODUNDERGROUND_SUPER_NERD5 --> GOLDENRODUNDERGROUND_OLDER_HAIRCUT_BROTHER
GOLDENRODUNDERGROUND_SUPER_NERD6 --> GOLDENRODUNDERGROUND_YOUNGER_HAIRCUT_BROTHER
2019-04-27 21:44:24 -04:00
DeeDeeG
a22d70f599 GoldenrodUnderground.asm: Re-label UnknownText 2019-04-27 21:44:24 -04:00
DeeDeeG
8758550960 PowerPlant.asm: Rename some NPCs
GymGuy3 --> Officer2
POWERPLANT_FISHER --> POWERPLANT_MANAGER
2019-04-27 21:44:24 -04:00
DeeDeeG
09194683b4 PowerPlant.asm: Re-label UnknownText, MovementData 2019-04-27 21:44:24 -04:00
Rangi
745339014c "object_const_def" instead of "const_def 2" 2019-04-21 17:42:25 -04:00
Rangi
689acb0e36 Try to identify more of maps/unused/Beta*.blk 2019-04-20 14:45:20 -04:00
Rangi
22cc0c25e9
Merge pull request #625 from pret/aus
Build Australian Crystal.
2019-04-14 15:30:51 -04:00
IIMarckus
9f7d30439e Build Australian Crystal. 2019-04-14 13:22:45 -06:00
DeeDeeG
31dc62ec5d Adding labels to placeholders (UnknownText, MovementData) in the maps folder (#618)
Adding labels to placeholders (UnknownText, MovementData) in the maps folder

* KurtsHouse.asm
* RadioTower[1/2/3]F.asm
* Route[35/36]NationalParkGate.asm
2019-04-13 11:49:42 -04:00
Rangi
f5c9958aea Rename some call/jump script commands to avoid confusion with jr/jp asm instructions
Fixes #580
2019-03-10 16:39:31 -04:00
Rangi
e002b536af Rename more script commands for consistency and predictability
Fixes #540
2019-03-10 16:00:19 -04:00
Rangi
f9a60cff7a Define constants for prices in maps' event scripts
Supersedes #592
2019-02-16 13:19:39 -05:00
mid-kid
0390728d44 Fix constants used with startbattle 2019-01-15 13:37:22 +01:00
Rangi
3202c4f3df Resolve issue #575: Rename text commands 2018-11-18 12:41:11 -05:00
Rangi
3eacab563d
Merge pull request #555 from Rangi42/ldh
Use real labels for HRAM instead of constants, and the ldh instruction
2018-08-25 22:23:45 -04:00
Rangi
89681d2316
Merge pull request #541 from igidrau/patch-2
Labeled everything
2018-08-25 22:23:25 -04:00
igidrau
f2ac3b96fa
Changed some labels according to Rangi's comments 2018-08-25 21:44:30 +02:00
Rangi
eb1e3636bb Use labels instead of constants for HRAM
Use explicit ldh instruction to access HRAM locations, don't rely on optimizing ld
2018-08-25 14:28:22 -04:00
Rangi
a09cfc0c36 Label some Unknown map text 2018-08-20 20:24:55 -04:00
IIMarckus
cf69876ae5 Better labels/constants for Move Tutor. 2018-08-16 08:05:21 -06:00
igidrau
4aed8ea922
There was an error in the previous commit 2018-08-08 10:56:14 +02:00
igidrau
88a563e6e7
Changed the labels accordingly to the standard style 2018-08-08 10:47:07 +02:00
Rangi
9dec80b07e Add meaningful aliases for wd265
Introduce MONICON_* constants
Introduce BATTLEPLAYERACTION_* constants
2018-07-29 00:25:52 -04:00
igidrau
1aa569b329
Changed some label according to Rangi's comment
I changed things from GitHub, so I hope this still works
2018-07-12 22:32:11 +02:00
igidrau
5d9cbfec53
Labeled everything 2018-07-12 20:21:55 +02:00
mid-kid
1d9a68dbdd Remove all address comments 2018-06-24 16:13:22 +02:00
Rangi
5c064746f6 Gme → Game 2018-05-21 21:54:56 -04:00
Rangi
d5fff8aa96 Constants for PC menu indexes
'db  ' -> 'db '
2018-05-18 22:18:00 -04:00
mid-kid
c82deab86f fix-various-little-things
A compilation of suggestions from the discord that don't deserve
separate commits and are not questionable at all™.
2018-05-05 09:19:04 +02:00
yenatch
4e4d9c9083 Merge remote-tracking branch 'surskitty/master' into master 2018-03-10 16:10:00 -05:00
surskitty
96dcc3c0ca Labels, labels. 2018-03-07 22:27:35 -05:00
surskitty
55c69c4871 Sprout Tower labels 2018-03-07 22:13:24 -05:00
surskitty
1de25bc957 Labelling Erika and Celadon Gym 2018-03-07 22:05:14 -05:00
surskitty
1494c79688 Labelling Whitney texts 2018-03-02 21:39:29 -05:00
Rangi
fb2ac9e210 Remaining map labels: UnknownText and MovementData 2018-03-01 17:33:43 -05:00
Rangi
2b40a1fb9c Label more map scripts (no more UnknownScripts) 2018-03-01 17:17:08 -05:00