Commit Graph

5081 Commits

Author SHA1 Message Date
vulcandth
c01409be5a
Relabel some map_object struct fields (#1029) 2023-01-03 22:16:08 -05:00
Daniel Harding
2d40e99d11
Ensure linked songs are in the same bank (#1027) 2022-12-29 07:59:32 -06:00
Rangi
ce99c9e93c Use rgbgfx -c embedded to extract palettes
Fixes #1026
2022-12-27 18:34:46 -05:00
vulcandth
cb8505e022
Define InitDefaultEZChatMsgs and sEZChatMessages (#1022) 2022-12-26 13:55:01 -05:00
vulcandth
25e12c9391
wUnlockedUnowns engine_flag constants (#1025) 2022-12-26 13:14:10 -05:00
vulcandth
f739f8b1ac Add table assert DoBattleAnimFrame.Jumptable 2022-12-23 18:48:14 -06:00
Rangi
4387298b2c Comment the Crystal 1.0 bugs as "BUG:" too 2022-12-14 22:30:20 -05:00
Rangi
8fd66c080f Use rgbds 0.6.1 (0.6.0 also still works) 2022-12-03 11:11:20 -05:00
Rangi
eb28b5ae56 Only patch Stadium data for a 2MB ROM 2022-12-03 11:10:55 -05:00
vulcandth
b232b4be5f
Bug: PRZ and BRN stat reductions don't apply to switched Pokémon (#1021)
Co-authored-by: Rangi <35663410+Rangi42@users.noreply.github.com>
2022-12-01 16:54:01 -05:00
vulcandth
c4e3f2bbc2
TrainerWalkToPlayer should reference wSeenTrainerDistance (#1020) 2022-11-22 21:03:24 -05:00
vulcandth
f7d26fbe9c .CheckNPC label and comment correction 2022-11-07 20:27:09 -06:00
mid-kid
8b429e2a54 Make sure tools are built before dependencies are generated
Avoids calling a program that doesn't exist yet (not actively harmful,
but yeah...)
2022-10-25 17:55:30 +02:00
mid-kid
0425018d1c Fix preinclude dependencies 2022-10-25 17:51:30 +02:00
Idain
a95336d9e7
Fix Spelling Typos in engine/battle_anims/functions.asm 2022-10-16 23:16:12 -05:00
Rangi
90bec40276 Fix LodePNG to avoid -Wcast-qual warnings
<https://github.com/lvandeve/lodepng/issues/160>
2022-10-14 16:17:52 -04:00
Rangi
89a888277a Revise macros in tools 2022-10-12 21:43:00 -04:00
Rangi
ce004be92c Revise constants in CheckShininess 2022-10-12 21:41:08 -04:00
mid-kid
1222ea7def Fix rgbdscheck running on older rgbds 2022-10-08 19:07:00 +02:00
vulcandth
770d2fc4cb
FAQ.md require 0.6.0 2022-10-02 23:29:47 -05:00
Rangi
c61bd0d5a7 Update tools/unnamed.py for rgbds 0.6.0 object files 2022-10-02 22:34:10 -04:00
Rangi
8e135931a6 Require rgbds 0.6.0 2022-10-02 22:03:53 -04:00
Rangi
70a3ec1acc startswith works with a tuple 2022-09-30 16:55:35 -04:00
Rangi
f76f5c3583 Fix array size 2022-09-30 16:55:09 -04:00
Rangi
38578cc34d
Generate the correct Stadium base data for every ROM (#1010) 2022-09-30 16:42:29 -04:00
Idain
a9869f1896
Replace hardcoded wMonType constants (#1011) 2022-09-28 19:51:39 -05:00
vulcandth
bceeea8e3b
Fix Typo: GoldenrodPokecomCenterSaveBeforeTradeCornetText -> GoldenrodPokecomCenterSaveBeforeTradeCornerText 2022-09-24 20:04:28 -05:00
Rangi
f7507b7782 $f -> BATTLEACTION_FORFEIT
(thanks, Vulcandth)
2022-09-23 23:10:24 -04:00
Rangi
8fc3b8e6e3 Dance Theatre -> Dance Theater
Fixes #1008
2022-09-23 22:06:52 -04:00
Idain
553a272e52
TYPO: NUM_MOVE_EFECTS > NUM_MOVE_EFFECTS (#1009) 2022-09-21 22:01:39 -05:00
Rangi
29fada7d8c Don't use removeprefix in tools/unnamed.py (it worked locally...) 2022-09-18 23:56:11 -04:00
Rangi
55ca2da25a Fix tools/unnamed.py and add tools/consts.py 2022-09-18 23:41:45 -04:00
Rangi
6c26e2617c Update and add more tool scripts 2022-09-18 23:08:56 -04:00
Rangi
711f5c87b3 Comment about the redundant event const_next 1900
Fixes #1006
2022-09-15 18:05:52 -04:00
Andrew Cook
0f5540740b
Some Mobile code labeling and removed magic numbers (#993)
* Macro loop for EmptyAllSRAMBanks

* Many things labeled and magic numbers removed

* Conform to the style guide

* Rename URLs in mobile_46

* MOBILEAPI_19 -> MOBILEAPI_TELEPHONESTATUS

* Update engine/menus/empty_sram.asm

Co-authored-by: Rangi <35663410+Rangi42@users.noreply.github.com>

* Update ram/wram.asm

Co-authored-by: Rangi <35663410+Rangi42@users.noreply.github.com>

* Update mobile/mobile_46.asm

Co-authored-by: Rangi <35663410+Rangi42@users.noreply.github.com>

* Update mobile/mobile_46.asm

Co-authored-by: Rangi <35663410+Rangi42@users.noreply.github.com>

* Remove underscore from Set*DownloadURL symbols

* Begin Labeling TradeCornerHoldMon routines

* Add wMobileMon party_struct

* Add TRADE_CORNER_REQUEST_LENGTH constant

* Name battle tower action functions

* Label trade corner send/receive buffer

* Label the saved copy of the trade corner pokemon

also fix mailmsg_jp

* So many copies of decodeBase64Character

* Label another buffer

* Fix Alignment and use MOBILE_EMAIL_LENGTH

* `Function11ad8a` -> `MobileIncJumptableIndex`

* Apply Rangi Suggestions pass 1

Co-Authored-By: Rangi <35663410+Rangi42@users.noreply.github.com>

* Apply Suggestions 2

Co-authored-by: Rangi <35663410+Rangi42@users.noreply.github.com>
Co-authored-by: vulcandth <vulcandth@gmail.com>
2022-09-14 19:49:58 -05:00
Rangi
41d5ea0482
Rename the object_struct field labels and constants (#1005)
Fixes #990
2022-09-12 09:15:44 -04:00
vulcandth
4c239a6f65
Rename macros/wram.asm to macros/ram.asm (#1003) 2022-09-11 01:05:07 -04:00
Rangi
53e1c48092 Link to the symbols branch 2022-09-10 13:53:53 -04:00
vulcandth
57a23299fb
Use DEF for constants in Music IDs design flaw doc 2022-09-09 10:26:05 -05:00
vulcandth
ae79200b1d
Remove duplicate BUG comment in bug doc diff 2022-09-08 20:33:56 -05:00
mid-kid
cff8aec3a7 mobile/mobile_45.asm -> lib/mobile/mail.asm
This file is part of the official mobile adapter SDK, although unlike
lib/mobile/main.asm, this file was included as source code the
developers could modify.
2022-09-08 12:55:14 +02:00
vulcandth
8ed7c392cd Fix order of parameters in dsprite macro
The parameters of the legacy dsprite macros were in the wrong order.
Fixes #1002

Co-Authored-By: Idain <54337884+Idain@users.noreply.github.com>
Co-Authored-By: Fredrik Ljungdahl <fredde1994@gmail.com>
2022-09-07 19:25:20 -05:00
vulcandth
39ba36cb92 Use RS Group offset constants for slot_reel
Co-Authored-By: Rangi <35663410+Rangi42@users.noreply.github.com>
2022-09-05 10:17:40 +00:00
Rangi
5d629f9b31 Fix diff 2022-08-31 19:14:20 -04:00
Idain
01dffba788
Document fish bug properly (#995) 2022-08-31 18:13:10 -05:00
Rangi
4883950318 Use for loops to generate box pointer tables
Fixes #996
2022-08-31 18:03:49 -04:00
Rangi
c7dee19a48 Match bug docs with source code
Fixes #997
2022-08-31 17:56:00 -04:00
vulcandth
9801b93906 Add Bug comment for fishing/surfing on NPCs
Also this re-orders `FishFunction:` and `SurfFunction:` in the bug doc, since `SurfFunction:` is encountered in the file first.
2022-08-31 00:43:12 -05:00
Rangi
b764a3a84d Document fix for fishing and Surfing on top of NPCs
Fixes #994
2022-08-30 17:06:12 -04:00
Fredrik Ljungdahl
40c899162b Replace numbers with constants in PlayHitSound 2022-08-24 12:17:31 +02:00