mid-kid
8befc889ad
Remove a verifiably false comment
...
wSpriteAnimCount starts at 0, keeps incrementing and never decrements.
When it reaches $ff, the next value is 1.
Its purpose is unknown, as this value is used nowhere else.
2020-08-05 16:02:48 +02:00
mid-kid
aabfc0b413
d is the multiplier for Sprites_Sine
2020-08-05 16:02:48 +02:00
mid-kid
b6055b1944
Use TRUE for hCGBPalUpdate
2020-08-05 16:02:48 +02:00
Rangi
bb25c1074c
Use LOAD/ENDL for OAM DMA code in HRAM (requires rgbds 0.4.1)
2020-07-21 19:45:25 -04:00
Rangi
f5ac9b0eb7
SCGB_PARTY_MENU_HP_PALS -> SCGB_PARTY_MENU_HP_BARS, and SCGB_RAM -> SCGB_DEFAULT
2020-07-04 16:18:16 -04:00
Rangi
91774f206e
Replace "Unreferenced" labels with "; unreferenced" comments
2020-06-21 16:27:43 -04:00
Rangi
cc460a17b0
Harmonize engine/{movie, pokemon} with pokegold (renames GetSRAMBank to OpenSRAM)
...
To do: engine/{menus, overworld}
2020-06-17 17:03:38 -04:00
Rangi
8019db3ea9
Harmonize engine/{gfx, items, link, math} with pokegold
2020-06-17 10:39:17 -04:00
Rangi
7b2515d1e4
[in progress] Harmonize more constant and data files with pokegold
2020-06-16 14:32:57 -04:00
Rangi
b9f2b93c17
Harmonize some more symbols with pokegold
2020-06-16 11:28:52 -04:00
Rangi
60c71add58
Define pokeanim setup commands like std scripts, predefs, and specials
...
No need for a macro workaround in rgbds 0.4.0
2020-06-10 17:15:53 -04:00
Rangi
4259b0f934
Separate UnusedBattleObjectPals from PartyMenuOBPals
2020-06-03 12:20:34 -04:00
Rangi
156f2cc3ef
Update some routine labels, including unreferenced ones
2020-05-18 11:59:48 -04:00
Rangi
e32cf1bfd1
Miscellaneous cleanup noted in #709
2020-05-17 20:59:15 -04:00
Rangi
20464d1bfb
Miscellaneous updates
...
- `PREDEFPAL_00` -> `PREDEFPAL_ROUTES` (observed from `LoadSGBLayout.GetMapPalsIndex.route`)
- `$0` -> `PLAYER` (standard person ID)
- Fix some whitespace formatting
2020-04-30 11:27:32 -04:00
Rangi
576cbf5b3e
Miscellaneous fixes, including one for the Pokédex design flaw by ax6
2020-04-18 17:31:51 -04:00
Rangi
865d623846
Remove unused nonmatching files for electro_ball.png and sgb_border.bin
...
electro_ball.png needed to preserve one whitespace tile which tools/gfx would normally remove. Preserving a list of tile indexes has been added as a general feature to tools/gfx.
sgb_border.bin needed to remove the 20x18 center area of $00 bytes. This is achievable with the standard tr utility.
2020-04-08 12:14:37 -04:00
Rangi
3144b54bd1
Enable rgbds warnings and remove CFLAGS=-O2 (default is now -O3)
2020-04-06 12:41:07 -04:00
Rangi
6a6ba10315
rgbds supports 'X - 1' instead of 'X + -1'
2020-03-21 14:01:05 -04:00
Rangi
447da80615
Identify remaining gfx/unknown files
2020-02-28 09:23:41 -05:00
Rangi
81eaf83cd7
Identify gfx/unknown/4985a.asm as gfx/tilesets/forest-tree/unused.png
2020-02-26 15:41:22 -05:00
mid-kid
26b8bf003e
Standardize on lowercase Tilemap and Attrmap
...
We used to have a mixture of TileMap and and Tilemap, as well as the
similar AttrMap. Standardize on one.
2020-02-13 18:31:10 +01:00
mid-kid
0d81f1c470
InitSpriteAnimStruct <-> _InitSpriteAnimStruct
...
These were the wrong way around, as the function in home should not be
prefixed
2020-02-13 18:31:10 +01:00
Rangi
4211886921
Use constants for quantities when copying SGB border tiles and palettes
2019-11-03 14:15:20 -05:00
Rangi
71db95dc34
Identify a few more WRAM label uses
2019-04-19 18:55:04 -04:00
mid-kid
3e78e5b2b6
TextBox -> Textbox
...
Homogenizing names.
2019-04-09 16:09:18 +02:00
Rangi
2ffbde764e
Minor code+docs fixes
2019-03-12 22:55:40 -04:00
Rangi
7c42452748
Standardize on $ff ^ X for bitwise negating 8-bit values
2019-02-16 13:52:19 -05:00
Rangi
771d2efd65
Merge pull request #601 from mid-kid/master
...
Exciting adventures down battle animation street!
2019-02-16 13:23:17 -05:00
mid-kid
7d6befa181
Fix issues in review
2019-02-16 19:08:34 +01:00
Rangi
df337fc417
Update to rgbds 0.3.8
2019-02-16 12:17:55 -05:00
mid-kid
5f60cc24cf
Fix some constants
...
Glass ting SFX were added in crystal.
PicAnimations and UnownAnimations are expected to be in the same bank as
their pointers, because the pointers are not BANK()-referenced
separately.
2019-01-15 13:06:16 +01:00
Rangi
1853e3d127
Say "BANK(Foo) ; aka BANK(Bar)" to clarify that Foo and Bar share a bank
2019-01-12 15:17:20 -05:00
Rangi
2e7e5ca67b
PREDEFPAL_4D -> PREDEFPAL_GAMEFREAK_LOGO_OB
2018-09-22 13:40:37 -04:00
Rangi
03cb8c53f1
Identify some Spaceworld beta content
2018-09-16 13:40:47 -04:00
Rangi
ae022e1420
Curr -> Cur
2018-09-09 15:09:51 -04:00
Rangi
557ce82073
hQuotient is a four-byte buffer ( fixes #558 )
2018-08-26 13:49:38 -04:00
Rangi
1c0fff7668
hLabel - $ff00 -> LOW(hLabel)
2018-08-25 14:34:25 -04:00
Rangi
eb1e3636bb
Use labels instead of constants for HRAM
...
Use explicit ldh instruction to access HRAM locations, don't rely on optimizing ld
2018-08-25 14:28:22 -04:00
Rangi
9dec80b07e
Add meaningful aliases for wd265
...
Introduce MONICON_* constants
Introduce BATTLEPLAYERACTION_* constants
2018-07-29 00:25:52 -04:00
Rangi
d5b98f5206
wPokeAnimStruct matches wPokeAnimStructEnd
2018-07-23 00:37:48 -04:00
Rangi
a1806d6e81
Consistent routine naming convention: 'Foo' wraps '_Foo'
2018-07-23 00:13:43 -04:00
Rangi
bdde60c64b
ANIM_MON_UNUSED → ANIM_MON_HOF
2018-07-22 23:42:50 -04:00
Rangi
8b06ff09eb
Use significant values 5, 6, and 7
2018-06-30 15:58:05 -04:00
Rangi
6306e590bd
No linebreak
2018-06-30 14:53:38 -04:00
Rangi
67d1364c7a
Fix triple newlines left over from removing address comments
2018-06-24 23:22:50 -04:00
Rangi
9afaed9b8f
Remove more address comments
2018-06-24 21:39:23 -04:00
mid-kid
5efce10789
Remove even more address comments
...
That should be all of them this time
2018-06-25 02:10:37 +02:00
mid-kid
1d9a68dbdd
Remove all address comments
2018-06-24 16:13:22 +02:00
yenatch
dbf05e48eb
Merge pull request #517 from mid-kid/master
...
Some fixes all around
2018-06-05 07:04:54 -04:00
