Remy Oukaour
2f9f2317a3
Document the meaning of hour and daytime values for person_events
2017-12-23 01:19:34 -05:00
Remy Oukaour
aa97752efe
Move NUM_BUENA_PRIZES to event/buena.asm (still hard-coded)
...
Buena_PrizeMenu has "rept NUM_BUENA_PRIZES", which needs NUM_BUENA_PRIZES to be already defined. BuenaPrizeItems and BuenaPrizeItemsEnd are needed to define NUM_BUENA_PRIZES; but BuenaPrizeItems is defined after Buena_PrizeMenu. I don't see a way to avoid hard-coding its value of 9.
Contrast that with the NUM_MOM_ITEMS constants, which are not used as "rept" arguments and so can be defined within their code file.
2017-12-23 00:31:04 -05:00
Remy Oukaour
daa071451d
More comments for constant<->table correspondences
2017-12-22 23:08:55 -05:00
Remy Oukaour
14a244ad3a
IsHM is not used within home/names.asm; group it with the other HM routines+data
2017-12-22 22:56:21 -05:00
Remy Oukaour
b423e3b90b
Split more code from home.asm into home/ files
2017-12-22 22:50:28 -05:00
Remy Oukaour
1ecbfc49f4
Correct directions
2017-12-22 18:01:06 -05:00
Remy Oukaour
ae3bef5596
Document one more graphical mistake
2017-12-22 17:59:50 -05:00
Remy Oukaour
763bd48141
Document a graphical error
2017-12-22 17:52:34 -05:00
Remy Oukaour
ff4d25eee3
Include bugfix in comments
2017-12-21 12:11:35 -05:00
Remy Oukaour
d6dccb7df5
Use NAME_LENGTH_JAPANESE more
2017-12-21 11:56:33 -05:00
Remy Oukaour
02609940db
Document one more bug
2017-12-21 11:43:41 -05:00
Remy Oukaour
2fa1e97aeb
Document two more bugs
2017-12-19 19:04:56 -05:00
Remy Oukaour
17058aaec2
Auto-label more map scripts
2017-12-17 20:56:35 -05:00
Remy Oukaour
3ed016f9e0
Auto-label more map scripts
2017-12-17 20:17:30 -05:00
Remy Oukaour
25a3960646
Move some more main.asm routines into individual files
2017-12-16 19:00:50 -05:00
Remy Oukaour
05d49f7d75
Move more code out of main.asm
2017-12-16 12:49:43 -05:00
Remy Oukaour
aa44ecfc4f
Consolidate duplicate graphics
2017-12-16 12:09:16 -05:00
Remy Oukaour
bd6dc94da0
Move tileset-specific palette code into tilesets/
2017-12-16 00:52:16 -05:00
Remy Oukaour
fbf931f5d3
Ad some more constants for meaningful audio WRAM bits
2017-12-16 00:50:03 -05:00
Remy Oukaour
cbde91d7ed
Only engine/decorations.asm uses PadCoords_de
2017-12-15 23:59:24 -05:00
Remy Oukaour
5aac8afae7
PLAYER_SLIP → PLAYER_SKATE (probably used for the beta skateboard; DoPlayerMovement.BikeCheck returns true for it)
2017-12-15 23:29:42 -05:00
Remy Oukaour
fa98c29fa4
Add more palettes to data/palettes/
2017-12-15 22:36:33 -05:00
Remy Oukaour
f96aab4014
Correct some documentation comments
2017-12-15 21:32:43 -05:00
Remy Oukaour
e44640b008
Move more main.asm code into individual files
2017-12-15 21:22:26 -05:00
Remy Oukaour
01bd8ac94c
Move old baserom.gbc 'compare' scripts to tools/
2017-12-15 20:12:00 -05:00
Remy Oukaour
1038ebca5e
Move more contiguous related code blocks from main.asm to engine/ and events/
2017-12-15 20:10:54 -05:00
Remy Oukaour
606817f18b
Add a map_connection_struct macro
2017-12-15 18:25:32 -05:00
Remy Oukaour
2cf5cc1dc7
Move more unknown graphics into real subfolders
2017-12-15 17:50:45 -05:00
Remy Oukaour
59fe407812
Copy pokered's organization some more, with further constant and data files
2017-12-15 17:22:52 -05:00
Remy Oukaour
dc76bf804f
Move all misc/ and unknown/ files to meaningful directories
2017-12-15 13:21:47 -05:00
Remy Oukaour
ebf3bfb6b2
Move some misc/ files into meaningful directories
2017-12-15 12:53:33 -05:00
Remy Oukaour
253c09949b
Move data/audio/ back into audio/
...
Keep trainer data together
2017-12-15 12:38:59 -05:00
Remy Oukaour
94722aa8f0
Move predef/ files into engine/
...
Get rid of single-file engine/ subdirectories
Move tilesets/ palettes unrelated to individual tilesets into data/palettes/ (more from engine/colors.asm can be moved here too)
2017-12-15 12:31:18 -05:00
Remy Oukaour
2b6dd505c1
Document another bug
...
Remove an unused file
2017-12-15 01:01:57 -05:00
Remy Oukaour
d334a331fa
Correct endturn value
2017-12-15 00:54:45 -05:00
Remy Oukaour
d6dc9351e9
Start documenting effect commands
2017-12-15 00:48:59 -05:00
Remy Oukaour
fecc5c339a
More comments for macros
2017-12-15 00:38:52 -05:00
Remy Oukaour
28aec67f6e
Document one more bug/oversight
...
Move FleeMons table into data/
2017-12-15 00:05:53 -05:00
Remy Oukaour
6ba30e593e
Macro-ify the unused palette map
2017-12-14 23:35:08 -05:00
Remy Oukaour
6ab1d028bb
Split items/ and trainers/ into their data/ and engine/ components
...
Move some data into a pokemon/ subdirectory
2017-12-14 23:00:54 -05:00
Remy Oukaour
9ba224e2e6
Document two more bugs
2017-12-14 21:45:35 -05:00
Remy Oukaour
232feca298
Consistent "(with <routine>) in <file>" phrasing
2017-12-14 19:07:06 -05:00
Remy Oukaour
68785d9996
Use absolute links within repository
2017-12-14 19:04:44 -05:00
Remy Oukaour
c5d482df20
Document two more bugs found by Crystal_
2017-12-14 16:28:16 -05:00
Remy Oukaour
b17db9b8b5
Friend Ball happiness for boxed Pokémon is not a bug
2017-12-14 14:18:33 -05:00
Remy Oukaour
7350c3708f
Replace two numbers with constants (found by pfero)
2017-12-14 12:19:26 -05:00
Remy Oukaour
2ff7f50584
Clarify which gfx anim commands are for oam
2017-12-14 00:38:08 -05:00
Remy Oukaour
e48a401290
Reorganize macros
2017-12-14 00:36:24 -05:00
Remy Oukaour
8745915dbd
Rename the Onix trade house to match the rest
2017-12-13 18:07:00 -05:00
Remy Oukaour
0e7a101e41
Use constants for gender ratios
2017-12-13 17:59:14 -05:00
