Commit Graph

1589 Commits

Author SHA1 Message Date
xCrystal
c99444d1b9 Documentation 2023-10-18 20:04:11 +02:00
xCrystal
fbfd582926 Do not reset wCurTurn and wCurSpace if entering from save in overworld [Bug fix to previous commit] (#24) 2023-10-18 18:07:46 +02:00
xCrystal
3291b82069 Implementation of basic navigation and movement across linear spaces (#24) 2023-10-18 17:46:57 +02:00
xCrystal
a31c114382 Separate disabling space events and tile events so they aren't mutually exclusive in the same step (#25) 2023-10-17 16:24:04 +02:00
xCrystal
7448da8380 Create BOARDEVENT_END_TURN as a transition between turns after landing on space (#25) 2023-10-14 21:45:48 +02:00
xCrystal
b9ac41feb6 Upkeep tasks in board menu: auto save game, increase turn, clear wTurnData (#11); also init wCurTurn and wCurSpace in EnterMap 2023-10-14 20:52:09 +02:00
xCrystal
645eef341b Fix typo in previous commit (#21) 2023-10-14 20:41:18 +02:00
xCrystal
47422a1adb Begin implementation of base effect of regular spaces (#21) 2023-10-14 19:28:35 +02:00
xCrystal
917db30e98 Save game and clear board menu cursor position during game menu (#17) 2023-10-07 19:08:54 +02:00
xCrystal
da956ed7e4 Detach PAL_OW_MISC from map palettes i.e. LoadMapPals (#3) 2023-10-07 12:47:37 +02:00
xCrystal
85a616e20e Create tileset and map in debug build for testing 2023-10-06 20:42:00 +02:00
xCrystal
a01f04e967 Implement common tileset portion at second half of vTiles5: palette maps (#19) 2023-10-04 17:20:48 +02:00
xCrystal
0d016cc8ee Change die roll SFX (#11) 2023-10-03 19:01:24 +02:00
xCrystal
8c7ee46065 Fix map anims not disabled outside of overworld (#17) 2023-10-02 17:39:10 +02:00
xCrystal
7d9b5bb279 Functional stub of title menus: minor clean up (#17) 2023-10-02 13:22:54 +02:00
xCrystal
0795c02a9c Functional stub of title menus: clean up return from overworld loop [Commit 2] (#17) 2023-10-01 00:39:18 +02:00
xCrystal
a16322350f Functional stub of title menus [Commit 1] (#17) 2023-10-01 00:10:44 +02:00
xCrystal
e53ae0eac9 Optimize some HRAM usage 2023-09-30 19:12:57 +02:00
xCrystal
336b3e77af Adjust duration of move die number animation (#11) [bugfix to 1f2be83ebc] 2023-09-30 19:06:54 +02:00
xCrystal
8967898bc9 Create function to update only secondary sprites to optimize die roll animation (#11) 2023-09-30 13:30:30 +02:00
xCrystal
1f2be83ebc Board menu: move die number animation (#11) 2023-09-27 19:25:47 +02:00
xCrystal
98d69d4e04 Board menu: break die and appear die number animations (#11) 2023-09-26 20:09:13 +02:00
xCrystal
db7d9c7063 Board menu: die roll input and animation (#11) 2023-09-25 21:57:47 +02:00
xCrystal
2cbe0e1764 Sync with pokecrystal up to aba1f14 2023-09-24 15:06:19 +02:00
xCrystal
5e78fd1ecc Sync with pokecrystal up to b0ddb07 2023-09-24 14:30:54 +02:00
xCrystal
d6001be90c Sync with pokecrystal up to 8873506b1 2023-09-24 14:21:42 +02:00
xCrystal
193882bc77 Constants for board menu gfx sizes (#11) 2023-09-23 11:50:25 +02:00
xCrystal
ca919cdf98 Board menu: implement preliminary Party, Bag, Pokegear, and Exit submenus (#11) 2023-09-22 23:12:05 +02:00
xCrystal
c11c53e0d7 Documentation (Overworld loop) 2023-09-15 20:04:16 +02:00
xCrystal
eb728d5151 Rename the concept of Money to Coins (#7) 2023-09-02 23:17:20 +02:00
xCrystal
5d95ff952a Replace ¥ font character with <COIN> (#7) 2023-09-02 23:17:21 +02:00
xCrystal
98fa7a9538 Rename the concept of Coins to Chips (#7) 2023-09-02 18:23:25 +02:00
xCrystal
ea31d254fb Relocate Board menu OAM to vTiles0 after outdoor sprites to leave room for overworld HUD tiles in vTiles1 (#11) 2023-09-02 13:21:57 +02:00
xCrystal
ea4ab28652 Enforce capacity limit of sprite list in VRAM (#2); actually fix LoadSpriteGFX (#8) [bugfix to 59bda0b36b] 2023-09-02 13:01:45 +02:00
xCrystal
74f2a55332 Add new map setup script MAPSETUP_ENTERLEVEL (#4), and integrate overworld HUD setup in the corresponding setup scripts (#15) 2023-08-31 19:27:39 +02:00
xCrystal
7bd940aeac Don't hide board menu objects behind the textbox (#11) [adapts Board menu to 2957bce0a9] 2023-08-31 18:51:37 +02:00
xCrystal
2957bce0a9 Don't hide sprites behind a 2BPP textbox if they are partially outside of it, and make 2BPP textboxes have priority over objects (#7); Generalize 1bpp/2bpp text state tracking (#10) [reworks 052d246e] 2023-08-31 18:41:05 +02:00
xCrystal
9f835560d7 Tinker with overworld HUD implementation in f386a63cf8 (#15) 2023-08-30 19:23:51 +02:00
xCrystal
f386a63cf8 Overworld HUD implementation (#15) 2023-08-29 18:33:20 +02:00
xCrystal
b275d642cd rename load_map_part.asm to load_screen_tilemap.asm following function name changes in fd6f02036e 2023-08-28 17:52:15 +02:00
xCrystal
f289d5621d Window HUD: Prevent more Window flickering in blocks that disable interrupts (#15) 2023-08-28 17:31:39 +02:00
xCrystal
fd6f02036e Improve some innacurate function names from pokecrystal 2023-08-28 13:30:13 +02:00
xCrystal
11db1300b2 Window HUD: Handle Window being fully shown during reanchor map (#15) 2023-08-28 12:03:32 +02:00
xCrystal
6e49bb9893 Implement the basics of the window HUD functionality (#15) 2023-08-27 19:18:52 +02:00
xCrystal
4ee4655e72 constants for rSTAT register 2023-08-27 16:27:11 +02:00
xCrystal
4dec74b770 Level selection menu: fading animations (#12) (#14) 2023-08-27 13:11:42 +02:00
xCrystal
4855dd9b70 RGB fade engine (#14) 2023-08-25 23:09:42 +02:00
xCrystal
f067112be6 Level selection menu: main logic of landmark transitions involving page change (#12) 2023-08-25 13:42:23 +02:00
xCrystal
d5dc7b38df Level selection menu: implement landmark transitions not involving page change (#12) 2023-08-23 12:50:22 +02:00
xCrystal
e866cdab48 Level selection menu: function to compute valid directions and directional arrows OAM (#12) 2023-08-22 12:42:53 +02:00
xCrystal
d7c59dcef1 Unlocked level flags 2023-08-21 01:45:06 +02:00
xCrystal
daf9e41557 Level selection menu: begin main loop, and landmark transitions (movements) data (#12) 2023-08-20 19:53:33 +02:00
xCrystal
84d5bdb55d Level selection menu: sprite anim data (#12) 2023-08-20 13:03:33 +02:00
xCrystal
fc2e757c57 Make level selection menu landmarks universal (#4) (#12) 2023-08-20 12:08:24 +02:00
xCrystal
222b46896c Level selection menu: init screen and bg layout, and preliminary landmarks data (#12) 2023-08-19 19:45:43 +02:00
xCrystal
fe4b54cece Level selection menu: placeholder grahpics and cgb layout (#12) 2023-08-18 20:19:34 +02:00
xCrystal
d7ce3b27ab Clean up some WRAM and SRAM involving unused mobile data (#6) 2023-08-18 12:04:53 +02:00
xCrystal
684c2eff78 Board menu (#11) [Commit 2] 2023-08-17 13:51:29 +02:00
xCrystal
1f33436a64 Board menu (#11) [Commit 1] 2023-08-14 20:09:23 +02:00
xCrystal
c405c955ba Load overworld font and frame via HDMA instead of copying to VRAM (#10) 2023-08-12 21:14:46 +02:00
xCrystal
052d246ee3 Use overworld textbox in text printing functions, differentiating between 1bpp and 2bpp text (#10) 2023-08-11 12:28:14 +02:00
xCrystal
25d112c0b0 Fix BG Map Mode bug in Pokedex graphics (#7) (bug fix to acd022d765) 2023-08-10 12:54:59 +02:00
xCrystal
e5171321a9 Fix overworld frame for non-speech textbox sizes (#10) 2023-08-09 10:17:43 +02:00
xCrystal
be5f3ad6e1 Remove unused map environment with index 0 (#7), Implement function to draw the overworld textbox (#10) 2023-08-07 13:23:57 +02:00
xCrystal
f64bbf700d Consolidate behavior of fading to/from white in overworld (#2), Fix naming screen tiles (#3) (bug fix to 6e3c5fd008) 2023-08-04 23:54:53 +02:00
xCrystal
55a38ff2de Make map environments more granular and make all map palettes except darkness depend on map environment (#7) 2023-08-04 18:45:50 +02:00
xCrystal
6e3c5fd008 Expand tilesets from 192 to 255 tiles (#2) [Commit 2], Reorganization of pokecrystal charmap and fonts layout (#3) 2023-08-02 19:52:51 +02:00
xCrystal
a1e095074c Remove Japanese text and non-english fonts (#1), Expand tilesets from 192 to 255 tiles (#2) [Commit 1] 2023-08-02 18:21:34 +02:00
xCrystal
dd04feb32a Remove map name sign feature (#1) 2023-07-31 19:30:40 +02:00
xCrystal
9df4cf6946 Create a fourth time of day (#2) 2023-07-31 12:27:53 +02:00
xCrystal
05448d7a7e Remove RTC (#1) and remove time of day dependence on RTC (#7) [Commit #2] 2023-07-28 00:07:07 +02:00
xCrystal
0571144a7b Remove RTC (#1) and remove time of day dependence on RTC (#7) [Commit 1] 2023-07-27 20:32:15 +02:00
xCrystal
59bda0b36b Fix some pokecrystal bug and glitches (#8)
Credits sequence changes move selection menu behavior; Swimming NPCs aren't limited by their movement radius; No bump noise if standing on tile E; The unused phonecall script command may crash; ScriptCall can overflow wScriptStack and crash; LoadSpriteGFX does not limit the capacity of UsedSprites; ReadObjectEvents overflows into wObjectMasks; ClearWRAM only clears WRAM bank 1; BattleAnimCmd_ClearObjs only clears the first 6â…” objects; Options menu fails to clear joypad state on initialization
2023-07-27 13:01:32 +02:00
xCrystal
d30b9dd60f Further remove unnecessary DMG/SGB checking (#7) and remove SGB layouts and palette data (#1) 2023-07-26 17:02:33 +02:00
xCrystal
acd022d765 Remove unnecessary DMG and SGB checking (#7) 2023-07-26 17:02:33 +02:00
xCrystal
15f452ff26 Remove indoor sprites (#7), and improve overworld sprite sorting in VRAM (#2) 2023-07-26 10:30:47 +02:00
xCrystal
2d5bd722cd Clean up WRAM, SRAM, and HRAM space (#6) 2023-07-25 19:49:25 +02:00
xCrystal
787caa2147 Get rid of LANDMARK_SPECIAL (#1) 2023-07-25 18:32:57 +02:00
xCrystal
473c23a727 Remove unnecessary event and engine flags (#1) 2023-07-25 18:24:38 +02:00
xCrystal
7bbe559252 Remove phone scripts data and text (#1) 2023-07-25 16:39:30 +02:00
xCrystal
5147904f78 Remove original maps and object events (#1) 2023-07-25 15:33:08 +02:00
xCrystal
60cacea4b0 Remove unreferenced content in bank 0 (#1) 2023-07-25 11:54:34 +02:00
xCrystal
fc7f2d4e0e Remove Mobile, Battle Tower, Mystery Gift, and Odd Egg (#1) 2023-07-24 21:13:11 +02:00
vulcandth
438c48daad
Rename PAL_NPC_SILVER to PAL_NPC_EMOTE (#1053) 2023-06-01 07:47:53 -05:00
Idain
5e983d32aa
Use NO_INPUT instead of magic number (#1051)
This is for the Virtual Console builds, where it disables the print functions of Unown and Mail.
2023-05-28 09:12:33 -05:00
mid-kid
354fefaefb Use time capsule label for time capsule copies 2023-04-19 19:12:14 +02:00
mid-kid
a1e711b80d Use more appropriate labels for link operations 2023-04-19 19:12:14 +02:00
mid-kid
4c4fd7258c Define SERIAL_PATCH_PREAMBLE_LENGTH 2023-04-19 19:12:14 +02:00
mid-kid
5ae35e5770 Label wOTLinkBattleRNData 2023-04-19 19:12:14 +02:00
mid-kid
08cfbbb1d9 Document link patch lists a little bit better 2023-04-19 19:12:14 +02:00
mid-kid
c8e9a82190 Make wMysteryGift*GameVersion constants consistent 2023-04-19 19:12:14 +02:00
mid-kid
a6ac67dea2 IsMailEuropean → ParseMailLanguage (and give it constants) 2023-04-19 19:12:14 +02:00
mid-kid
cfd432f468 Minor battle tower fixes 2023-03-08 13:52:47 +01:00
mid-kid
cf1c505555 GetNicknamenamePointer -> GetNicknamePointer
Found this commit on an old drive
2023-02-26 12:28:06 +01:00
vulcandth
c01409be5a
Relabel some map_object struct fields (#1029) 2023-01-03 22:16:08 -05:00
vulcandth
cb8505e022
Define InitDefaultEZChatMsgs and sEZChatMessages (#1022) 2022-12-26 13:55:01 -05:00
vulcandth
25e12c9391
wUnlockedUnowns engine_flag constants (#1025) 2022-12-26 13:14:10 -05:00
vulcandth
f739f8b1ac Add table assert DoBattleAnimFrame.Jumptable 2022-12-23 18:48:14 -06:00
Rangi
4387298b2c Comment the Crystal 1.0 bugs as "BUG:" too 2022-12-14 22:30:20 -05:00
vulcandth
b232b4be5f
Bug: PRZ and BRN stat reductions don't apply to switched Pokémon (#1021)
Co-authored-by: Rangi <35663410+Rangi42@users.noreply.github.com>
2022-12-01 16:54:01 -05:00
vulcandth
c4e3f2bbc2
TrainerWalkToPlayer should reference wSeenTrainerDistance (#1020) 2022-11-22 21:03:24 -05:00
vulcandth
f7d26fbe9c .CheckNPC label and comment correction 2022-11-07 20:27:09 -06:00
Idain
a95336d9e7
Fix Spelling Typos in engine/battle_anims/functions.asm 2022-10-16 23:16:12 -05:00
Rangi
ce004be92c Revise constants in CheckShininess 2022-10-12 21:41:08 -04:00
Rangi
8e135931a6 Require rgbds 0.6.0 2022-10-02 22:03:53 -04:00
Idain
a9869f1896
Replace hardcoded wMonType constants (#1011) 2022-09-28 19:51:39 -05:00
Rangi
f7507b7782 $f -> BATTLEACTION_FORFEIT
(thanks, Vulcandth)
2022-09-23 23:10:24 -04:00
Andrew Cook
0f5540740b
Some Mobile code labeling and removed magic numbers (#993)
* Macro loop for EmptyAllSRAMBanks

* Many things labeled and magic numbers removed

* Conform to the style guide

* Rename URLs in mobile_46

* MOBILEAPI_19 -> MOBILEAPI_TELEPHONESTATUS

* Update engine/menus/empty_sram.asm

Co-authored-by: Rangi <35663410+Rangi42@users.noreply.github.com>

* Update ram/wram.asm

Co-authored-by: Rangi <35663410+Rangi42@users.noreply.github.com>

* Update mobile/mobile_46.asm

Co-authored-by: Rangi <35663410+Rangi42@users.noreply.github.com>

* Update mobile/mobile_46.asm

Co-authored-by: Rangi <35663410+Rangi42@users.noreply.github.com>

* Remove underscore from Set*DownloadURL symbols

* Begin Labeling TradeCornerHoldMon routines

* Add wMobileMon party_struct

* Add TRADE_CORNER_REQUEST_LENGTH constant

* Name battle tower action functions

* Label trade corner send/receive buffer

* Label the saved copy of the trade corner pokemon

also fix mailmsg_jp

* So many copies of decodeBase64Character

* Label another buffer

* Fix Alignment and use MOBILE_EMAIL_LENGTH

* `Function11ad8a` -> `MobileIncJumptableIndex`

* Apply Rangi Suggestions pass 1

Co-Authored-By: Rangi <35663410+Rangi42@users.noreply.github.com>

* Apply Suggestions 2

Co-authored-by: Rangi <35663410+Rangi42@users.noreply.github.com>
Co-authored-by: vulcandth <vulcandth@gmail.com>
2022-09-14 19:49:58 -05:00
Rangi
41d5ea0482
Rename the object_struct field labels and constants (#1005)
Fixes #990
2022-09-12 09:15:44 -04:00
vulcandth
4c239a6f65
Rename macros/wram.asm to macros/ram.asm (#1003) 2022-09-11 01:05:07 -04:00
vulcandth
39ba36cb92 Use RS Group offset constants for slot_reel
Co-Authored-By: Rangi <35663410+Rangi42@users.noreply.github.com>
2022-09-05 10:17:40 +00:00
Idain
01dffba788
Document fish bug properly (#995) 2022-08-31 18:13:10 -05:00
Rangi
4883950318 Use for loops to generate box pointer tables
Fixes #996
2022-08-31 18:03:49 -04:00
vulcandth
9801b93906 Add Bug comment for fishing/surfing on NPCs
Also this re-orders `FishFunction:` and `SurfFunction:` in the bug doc, since `SurfFunction:` is encountered in the file first.
2022-08-31 00:43:12 -05:00
Fredrik Ljungdahl
40c899162b Replace numbers with constants in PlayHitSound 2022-08-24 12:17:31 +02:00
Idain
bc4fec0694
Fix AI_Smart_Rage comment (#988) 2022-08-21 22:39:08 -05:00
Rangi
7ef31d9889 Move non-Pokémon graphics out of gfx/icons
Fixes #987
2022-08-17 17:45:26 -04:00
The Void
38cd2155df
Bug Doc: Options menu fails to clear joypad state on initialization (#984) 2022-08-11 23:28:35 -05:00
Rangi
0d5cf5c8b9
Refer to "Rival", not "Silver" (#983)
Fixes #982
2022-08-10 21:24:56 -04:00
vulcandth
c3331eb7b1
Rename scene and callback labels (#981)
Co-authored-by: Rangi <35663410+Rangi42@users.noreply.github.com>
2022-08-09 18:04:18 -04:00
Rangi
07e8efee7e Fix some whitespace 2022-08-07 00:38:08 -04:00
Rangi
7cac5b787b Assert that there are NUM_FRAMES textbox frames 2022-08-06 12:24:40 -04:00
Rangi
8826d97ee4
Define scene constants alongside scene_scripts (#979)
Generic SCENE_DEFAULT and SCENE_FINISHED are legacy values
2022-07-29 17:43:10 -04:00
Rangi
51bfd31ea8 Use '$' for hex, not '0x' 2022-07-21 19:59:10 -04:00
Rangi
974bb7bf33 Only use "; BUG:" comments for documented bugs 2022-07-17 14:08:56 -04:00
Colton G. Rushton
145d8dd5c2
wVirtualOAM -> wShadowOAM and hTransferVirtualOAM -> hTransferShadowOAM (#971) 2022-07-09 17:18:22 -04:00
vulcandth
ef9b9bb437
Clean up bugs commented in the source code (#912)
Co-authored-by: Rangi <remy.oukaour+rangi42@gmail.com>
2022-07-09 16:12:02 -05:00
Rangi
a2e8f078a4 Split "gfx anims" into "pic anims" and "sprite anims"
Fixes #876
2022-07-04 01:11:42 -04:00
vulcandth
1853f70add VC ExchangeBytes Aliases
Co-Authored-By: aaaaaa123456789 <aaaaaa123456789@acidch.at>
2022-06-21 11:16:15 +02:00
Rangi
a1498e63e2 Rename search.asm and search2.asm 2022-06-17 23:27:53 -04:00
vulcandth
66d84ff021
MobileCheckOwnMonAnywhere & CheckOwnMonAnywhere Label, comments, formatting (#927)
Co-authored-by: Rangi <35663410+Rangi42@users.noreply.github.com>
2022-06-17 23:21:08 -04:00
Colton G. Rushton
84a3b335aa
Document that farcall returns c in a for some code (#937) 2022-06-17 22:30:53 -04:00
vulcandth
5f0597e944
Rename SLP to SLP_MASK (#918)
Co-authored-by: Rangi <35663410+Rangi42@users.noreply.github.com>
2022-06-17 22:25:56 -04:00
vulcandth
73c020074e
Remove redundant comments referencing labels (#921) 2022-06-06 17:34:54 -04:00
vulcandth
3648afda16
RGBDS syntax updates (#905)
New MACRO and DEF syntax
2022-06-06 17:25:42 -04:00
vulcandth
a4d346cc8c
Improved Virtual Console patch identifiers (#907) 2022-06-06 17:22:48 -04:00
Konrad Borowski
6e3f2a47bd Remove Heavy Ball never happens comment
It's not correct as Snorlax weights more than 409.6 kg.
2022-05-26 19:56:07 +00:00
Idain
dc121712fe
Fix misspelled label (#904) 2022-04-17 11:36:30 -04:00
vulcandth
f9077c6db6
Additional vc_asserts (#906) 2022-04-16 20:42:06 -04:00
Idain
b06cfe78fd Use NUM_BATTLE_STATS instead of raw numbers 2022-04-06 10:28:18 +00:00
mid-kid
1d97d41ea2 Tile constant makes more sense as negative 2022-04-05 21:22:46 +02:00
vulcandth
af7d328d66 Cleanup Magic Numbers 2022-04-05 19:14:39 +00:00
Idain
9b4ebe9400
Replace magic numbers with constants (#894) 2022-03-20 19:58:18 -04:00
Rangi
f33a041930 Allow alternate labels for patch names 2022-03-12 22:38:29 -05:00
vulcandth
31c3c94d64
Build the Virtual Console patch with make crystal11_vc (#882)
Fixes #813
2022-03-12 18:34:04 -05:00
Rangi
3a562f9896 Identify some wMenuJoypad-related button constants 2022-03-09 19:42:26 -05:00
Rangi
2910b9a6c2 Rename GetPokedexEntryBank to HeavyBall_GetDexEntryBank 2022-02-22 17:11:33 -05:00
Idain
d0c8f63f25
Rename ENGINE_FISH_SWARM to ENGINE_QWILFISH_SWARM (#879) 2022-02-22 09:47:05 -05:00
mid-kid
418b73bc6d Use constants for PartyAttr in move_effects/thief.asm 2022-02-15 18:30:57 +01:00
Rangi
e56a9f7962 Clear however many bytes are needed for wFruitTreeFlags 2022-02-14 17:28:08 -05:00