pokehacks/pokecrystal-board
0
0
Fork 0
mirror of https://gitlab.com/xCrystal/pokecrystal-board.git synced 2024-11-16 11:27:33 -08:00
Code Issues Packages Projects Releases Wiki Activity
5,313 Commits 1 Branch 0 Tags 52 MiB
f796199bab
Commit Graph

265 Commits

Author SHA1 Message Date
Rangi
9fea403be2 grey -> gray 2020-12-08 14:34:54 -05:00
Rangi
4ef556cbc8 Document AI_Smart_Conversion2 bug (resolves #786) 2020-12-07 13:13:03 -05:00
Rangi
4613bcfadf Use STRING_BUFFER_LENGTH for the wStringBuffers 2020-11-24 20:11:17 -05:00
Rangi
9b3c45b14d Resolve some "???" comments 2020-11-17 11:09:02 -05:00
Rangi
6a5edc98e9 Terser damage calculation constants 2020-11-09 16:12:19 -05:00
Rangi
7254c10093 Identify remaining uses of wBuffer1-6 as general-purpose HP buffers or mobile 2020-11-03 23:25:22 -05:00
Rangi
9f62d7911b Identify some more uses of wBuffer1-6 2020-11-03 22:45:12 -05:00
Rangi
c88c4a8340 Identify more uses of wBuffer1-6 2020-11-03 19:53:07 -05:00
Rangi
826e070f04 More syncing with pokegold 2020-11-03 10:13:06 -05:00
Rangi
6220200f0f Identify some more labels, and make some more consistent 2020-11-01 12:36:38 -05:00
Rangi
ba5bc304f9 Updates to more closely sync with pokegold 2020-10-29 23:23:57 -04:00
Rangi
bcc0d633e9 Identify the remaining (non-mobile) uses of another WRAM union 2020-10-29 14:51:41 -04:00
Rangi
ea426a8879 Identify more WRAM labels, and start a <X>_DummyFunction label convention 2020-10-28 14:34:38 -04:00
Rangi
6d333bed5f Replace many '; unused' with '; unreferenced' 2020-10-28 10:21:10 -04:00
Rangi
c85ba78b77 Use more assertions to ensure correct code and data 2020-10-26 22:24:38 -04:00
Rangi
9dcdad5e60 Comment, remove, or revise many unreferenced labels 2020-10-26 20:29:58 -04:00
Rangi
bd3f634049 Identify remaining map object labels 2020-10-22 21:30:21 -04:00
Rangi
ae4fe08084 Identify some more labels (a few link-related) 2020-10-22 00:53:54 -04:00
Rangi
650686476c Identify remaining battle AI labels 2020-10-21 21:34:18 -04:00
Rangi
93dcc8b6eb Identify SwitchItemsInBag labels 
Thanks to FIQ for having done so in Polished Crystal
 2020-10-21 15:39:15 -04:00
Rangi
7b12060e6a Battle transition spin quadrants are like pokered's half circles 2020-10-19 20:27:19 -04:00
Rangi
2e90df15b7 Update battle anim bg function comments, and identify more unnamed labels 2020-10-06 18:09:33 -04:00
Rangi
fc08ff2c38 Identify some unnamed labels 2020-10-06 13:50:02 -04:00
Rangi
6b7ade66da Identify more unnamed labels 2020-10-05 16:15:57 -04:00
Rangi
ff2d850219 Identify some more unnamed labels 2020-10-05 12:02:56 -04:00
Rangi
306c85750e Identify some more unnamed labels 2020-10-04 20:10:39 -04:00
Rangi
cf37abd3ec Remove wKickCounter and wPresentPower aliases for wBattleAnimParam 2020-08-29 20:35:49 -04:00
Rangi
0b31d12dac
Merge pull request #756 from mid-kid/master 
Rub a dub dub, thanks for the grub
 2020-08-18 16:35:15 -04:00
Rangi
ed3e70b97c Identify some time-related data 2020-08-11 14:12:59 -04:00
mid-kid
b6055b1944 Use TRUE for hCGBPalUpdate 2020-08-05 16:02:48 +02:00
mid-kid
2d2a7dec7d Label some mobile battle screen functions 2020-08-03 23:35:18 +02:00
Rangi
bb25c1074c Use LOAD/ENDL for OAM DMA code in HRAM (requires rgbds 0.4.1) 2020-07-21 19:45:25 -04:00
Rangi
e239aa4aba Disassemble the final English debug ROM 2020-07-13 15:18:28 -04:00
Rangi
7eef66af3f Use MAX_NEUTRAL_DAMAGE in BattleCommand_DamageCalc 
Also make .gitignore consistent with pokered
 2020-07-05 15:12:53 -04:00
Rangi
f2efda1f68 Identify more unnamed labels 2020-06-29 12:25:58 -04:00
Rangi
91774f206e Replace "Unreferenced" labels with "; unreferenced" comments 2020-06-21 16:27:43 -04:00
Rangi
98af69691d Remove some more raw addresses 2020-06-21 12:21:47 -04:00
Rangi
273324e787 pushd/popd are bash-only 2020-06-20 22:44:01 -04:00
Rangi
cc460a17b0 Harmonize engine/{movie, pokemon} with pokegold (renames GetSRAMBank to OpenSRAM) 
To do: engine/{menus, overworld}
 2020-06-17 17:03:38 -04:00
Rangi
f76dabedcc Harmonize engine/{battle, battle_anims, events, games} with pokegold 2020-06-16 19:32:36 -04:00
Rangi
e3f07b9612 Undo incorrect comment 2020-06-15 10:26:10 -04:00
Rangi
ffbca4d5f3 Adding 0 is pointless in CheckMimicUsed 2020-06-15 08:43:40 -04:00
Rangi
75035a71a5 Label some mobile addresses, and revise some comments 2020-06-13 18:48:26 -04:00
Rangi
cdafd41ef0 Remove address-related comment 2020-06-10 16:45:04 -04:00
Rangi
156f2cc3ef Update some routine labels, including unreferenced ones 2020-05-18 11:59:48 -04:00
Rangi
e32cf1bfd1 Miscellaneous cleanup noted in #709 2020-05-17 20:59:15 -04:00
Rangi
5f197c53f4 Clean up some percentage values 2020-05-07 14:21:24 -04:00
Rangi
b50dd57cbb Miscellaneous updates and corrections 2020-04-23 16:14:50 -04:00
Rangi
0345e4fb0e Add suffixes to some constants to avoid ambiguity 
- `PSYCHIC` → `PSYCHIC_TYPE` (not the trainer `PSYCHIC_T` or the move `PSYCHIC_M`)
- `BLACKBELT` → `BLACKBELT_I` (not the trainer `BLACKBELT_T`)
- `CURSE_T` → `CURSE_TYPE` (not the move `CURSE`)
- `TOWN_MAP_D` → `TOWN_MAP_POSTER` (not the item `TOWN_MAP`)

This also uncovered a misidentified event: `EVENT_DECO_PLANT_4` → `EVENT_DECO_POSTER_1`. (There are three plants and four posters.)
 2020-03-21 17:59:26 -04:00
Rangi
0cce00cb73 Document a bug where Teleport cannot fail for wild Pokémon 2020-02-28 11:17:58 -05:00
mid-kid
2a8c969bc7 Fix some comments and inmediates 2020-02-21 21:10:55 +01:00
mid-kid
26b8bf003e Standardize on lowercase Tilemap and Attrmap 
We used to have a mixture of TileMap and and Tilemap, as well as the
similar AttrMap. Standardize on one.
 2020-02-13 18:31:10 +01:00
mid-kid
34ceaac71d Call_LoadTempTileMapToTileMap → SafeLoadTempTileMapToTileMap 
Stupid name is stupid smh tbh fam.
 2020-02-13 18:31:10 +01:00
mid-kid
991d207d86 OWFlash -> FlashFunction 
Match the other overworld move functions
 2020-02-13 18:31:10 +01:00
Rangi
80cf859cd3 PHONE_DISPLAY_HEIGHT is 4, the number of visible phone entries 2020-01-19 14:10:10 -05:00
Colton G. Rushton
5728d01417 Add and simplify bugfixes in bugs_and_glitches.md (#664) 
Add extra fixes for bugs covered on Bulbapedia (and simplify others)
 2020-01-04 16:52:08 -05:00
bbbbbbbbba
0d48d829d4 Document Special Defense badge boost glitch (#651) 
Document Special Defense badge boost glitch
 2019-10-20 18:25:34 -04:00
mid-kid
e3e0bcd653 #641 fixes and additions. (#646) 
Name a lot of text labels according to our conventions
 2019-10-20 18:24:17 -04:00
Rangi
01618d3cc4 Define constants for both battle transition tiles 2019-06-30 14:20:25 -04:00
mid-kid
3e78e5b2b6 TextBox -> Textbox 
Homogenizing names.
 2019-04-09 16:09:18 +02:00
Rangi
6393ecb7e5 More consistent formatting 2019-03-03 19:55:28 -05:00
ISSOtm
c57ed5775c Rename PlayerMonFaintHappinessMod 
Seriously, mini-rant here: we were three to spend a couple hours trying to find something in this function
that was completely unrelated to happiness... and apparently there's been far worse. :')
Props to you guys for having been through this =D
 2019-03-03 23:55:24 +01:00
Rangi
a999787cb8 Update documentation: 
- Apply more edits from #595
- Move music ID behavior from the wiki to docs
- Move assembly programming links from docs to the wiki
- Describe why the TM item gaps exist
 2019-02-17 13:18:38 -05:00
Rangi
df337fc417 Update to rgbds 0.3.8 2019-02-16 12:17:55 -05:00
Rangi
1853e3d127 Say "BANK(Foo) ; aka BANK(Bar)" to clarify that Foo and Bar share a bank 2019-01-12 15:17:20 -05:00
Rangi
26fc7e2521 Consistent formatting in Function_SetEnemyMonAndSendOutAnimation and BattleStartMessage 2019-01-06 22:11:57 -05:00
Rangi
5207615cdc Document a bugfix: 1/256 failure rate for 100% effect chance 2019-01-05 20:30:46 -05:00
Rangi
f2785cdb71 Use battle menu flags 2018-12-31 14:25:53 -05:00
mid-kid
930d285fab Fix comments around BANK() statements 
Found a couple BANK()s that reference multiple labels.
 2018-12-26 21:58:13 +01:00
Rangi
f6ecb681d5 Fix issue #581 (random stuff ax6 noticed) 2018-12-23 03:45:41 -05:00
Rangi
e025ab9db0
Merge pull request #578 from mid-kid/master 
Fixes in the animation subsystem.
 2018-12-09 17:44:09 -05:00
mid-kid
5dfe652ff6 CalcStats -> CalcBattleStats 
Confusingly ambiguous name
 2018-11-23 23:03:27 +01:00
mid-kid
c210f052a8 Move BattleSideCopy to transform.asm 2018-11-21 14:14:34 +01:00
Rangi
3202c4f3df Resolve issue #575: Rename text commands 2018-11-18 12:41:11 -05:00
mid-kid
940256569b text_jump → text_far 
The previous name for this was rather misleading. It isn't an actual
jump like you'd expect the `jp` instruction to behave as. Instead, it
behaves more like a `farcall`.
This also makes it consistent with its current command ID name of
`TX_FAR`.
 2018-11-05 22:26:18 +01:00
Rangi
3b20a18200 Identify BATTLEACTION_D and _E (thanks, ax6) 2018-10-21 00:52:10 -04:00
mid-kid
3540b2a2d6 wMonStatusFlags -> wDebugFlags 2018-09-16 02:15:55 +02:00
Rangi
f9cf53ecba Use existing bigdw macro 2018-09-09 18:25:43 -04:00
Rangi
3241c9cfaa Use 0/1/2/3 for palettes, and rgbds opt feature for battle transition graphic 2018-09-09 18:15:54 -04:00
Rangi
b42ba692c4 ; fallthrough 2018-08-26 22:34:59 -04:00
Rangi
0e1445b796 spaces->tab, and remove redundant comment 2018-08-26 16:15:43 -04:00
Rangi
557ce82073 hQuotient is a four-byte buffer (fixes #558) 2018-08-26 13:49:38 -04:00
Rangi
1c0fff7668 hLabel - $ff00 -> LOW(hLabel) 2018-08-25 14:34:25 -04:00
Rangi
eb1e3636bb Use labels instead of constants for HRAM 
Use explicit ldh instruction to access HRAM locations, don't rely on optimizing ld
 2018-08-25 14:28:22 -04:00
mid-kid
50da83cb23 CheckDestinyBond -> CheckFaint 
Its main function is fainting the opponent and ending the move effect.
Updated the comment accordingly.
 2018-08-17 20:16:37 +02:00
mid-kid
79cf90ab5e Fix some StatUp-related labels 2018-08-17 17:48:41 +02:00
mid-kid
2e147d1128 GetDamageStatsCritical -> CheckDamageStatsCritical 
Clarified its usage, as the comments surrounding it were factually
wrong.
 2018-08-16 16:11:28 +02:00
mid-kid
3cf49b7245 Fix more uses of EFFECTIVE 2018-08-07 14:38:41 +02:00
mid-kid
bc0595564e Fix constants in BattleCommand_MirrorCoat 2018-08-07 09:46:21 +02:00
Rangi
1d96a79a37 No wCurMove alias for wCurSpecies 2018-07-29 16:04:38 -04:00
Rangi
c9cb67141b Make reviewed fixes; standardize on " + " 2018-07-29 01:40:23 -04:00
Rangi
0c746447e7 Improve wTrainerHUDTiles usage 2018-07-29 01:09:12 -04:00
Rangi
9dec80b07e Add meaningful aliases for wd265 
Introduce MONICON_* constants
Introduce BATTLEPLAYERACTION_* constants
 2018-07-29 00:25:52 -04:00
Rangi
cdfdfed17b Crystal fixed TruncateHL_BC in single player 2018-07-27 21:32:14 -04:00
mid-kid
9aa6b55d7b Merge branch 'master' of https://github.com/pret/pokecrystal 2018-07-27 11:24:59 +02:00
mid-kid
e43c89bc80 Consistently use the diff format in bugs_and_glitches 2018-07-26 23:34:03 +02:00
Rangi
2b88951f9f MON_STAT_EXP - 1 → MON_EXP + 2 2018-07-24 14:14:04 -04:00
Rangi
4f0c9cecf9 StringCmp → CompareBytes; CompareLong → CompareBytesLong 
hStringCmpString[1/2] → h[EnemyMon/PartyMon1]Speed
 2018-07-23 00:25:53 -04:00
Rangi
bdde60c64b ANIM_MON_UNUSED → ANIM_MON_HOF 2018-07-22 23:42:50 -04:00
IIMarckus
8aebc7ba56 Merge branch 'master' of hyperdriveguy/pokecrystal 2018-07-21 00:41:56 -06:00