Commit Graph

586 Commits

Author SHA1 Message Date
xCrystal
db7d9c7063 Board menu: die roll input and animation (#11) 2023-09-25 21:57:47 +02:00
xCrystal
2cbe0e1764 Sync with pokecrystal up to aba1f14 2023-09-24 15:06:19 +02:00
xCrystal
5e78fd1ecc Sync with pokecrystal up to b0ddb07 2023-09-24 14:30:54 +02:00
xCrystal
d6001be90c Sync with pokecrystal up to 8873506b1 2023-09-24 14:21:42 +02:00
xCrystal
ca919cdf98 Board menu: implement preliminary Party, Bag, Pokegear, and Exit submenus (#11) 2023-09-22 23:12:05 +02:00
xCrystal
674e838460 Organize debug-only structures for test maps and levels (#16) 2023-09-03 00:22:23 +02:00
xCrystal
eb728d5151 Rename the concept of Money to Coins (#7) 2023-09-02 23:17:20 +02:00
xCrystal
5d95ff952a Replace ¥ font character with <COIN> (#7) 2023-09-02 23:17:21 +02:00
xCrystal
98fa7a9538 Rename the concept of Coins to Chips (#7) 2023-09-02 18:23:25 +02:00
xCrystal
ea4ab28652 Enforce capacity limit of sprite list in VRAM (#2); actually fix LoadSpriteGFX (#8) [bugfix to 59bda0b36b] 2023-09-02 13:01:45 +02:00
xCrystal
74f2a55332 Add new map setup script MAPSETUP_ENTERLEVEL (#4), and integrate overworld HUD setup in the corresponding setup scripts (#15) 2023-08-31 19:27:39 +02:00
xCrystal
f067112be6 Level selection menu: main logic of landmark transitions involving page change (#12) 2023-08-25 13:42:23 +02:00
xCrystal
e866cdab48 Level selection menu: function to compute valid directions and directional arrows OAM (#12) 2023-08-22 12:42:53 +02:00
xCrystal
daf9e41557 Level selection menu: begin main loop, and landmark transitions (movements) data (#12) 2023-08-20 19:53:33 +02:00
xCrystal
84d5bdb55d Level selection menu: sprite anim data (#12) 2023-08-20 13:03:33 +02:00
xCrystal
fc2e757c57 Make level selection menu landmarks universal (#4) (#12) 2023-08-20 12:08:24 +02:00
xCrystal
222b46896c Level selection menu: init screen and bg layout, and preliminary landmarks data (#12) 2023-08-19 19:45:43 +02:00
xCrystal
684c2eff78 Board menu (#11) [Commit 2] 2023-08-17 13:51:29 +02:00
xCrystal
052d246ee3 Use overworld textbox in text printing functions, differentiating between 1bpp and 2bpp text (#10) 2023-08-11 12:28:14 +02:00
xCrystal
be5f3ad6e1 Remove unused map environment with index 0 (#7), Implement function to draw the overworld textbox (#10) 2023-08-07 13:23:57 +02:00
xCrystal
f64bbf700d Consolidate behavior of fading to/from white in overworld (#2), Fix naming screen tiles (#3) (bug fix to 6e3c5fd008) 2023-08-04 23:54:53 +02:00
xCrystal
55a38ff2de Make map environments more granular and make all map palettes except darkness depend on map environment (#7) 2023-08-04 18:45:50 +02:00
xCrystal
a1e095074c Remove Japanese text and non-english fonts (#1), Expand tilesets from 192 to 255 tiles (#2) [Commit 1] 2023-08-02 18:21:34 +02:00
xCrystal
dd04feb32a Remove map name sign feature (#1) 2023-07-31 19:30:40 +02:00
xCrystal
9df4cf6946 Create a fourth time of day (#2) 2023-07-31 12:27:53 +02:00
xCrystal
05448d7a7e Remove RTC (#1) and remove time of day dependence on RTC (#7) [Commit #2] 2023-07-28 00:07:07 +02:00
xCrystal
0571144a7b Remove RTC (#1) and remove time of day dependence on RTC (#7) [Commit 1] 2023-07-27 20:32:15 +02:00
xCrystal
59bda0b36b Fix some pokecrystal bug and glitches (#8)
Credits sequence changes move selection menu behavior; Swimming NPCs aren't limited by their movement radius; No bump noise if standing on tile E; The unused phonecall script command may crash; ScriptCall can overflow wScriptStack and crash; LoadSpriteGFX does not limit the capacity of UsedSprites; ReadObjectEvents overflows into wObjectMasks; ClearWRAM only clears WRAM bank 1; BattleAnimCmd_ClearObjs only clears the first 6⅔ objects; Options menu fails to clear joypad state on initialization
2023-07-27 13:01:32 +02:00
xCrystal
d30b9dd60f Further remove unnecessary DMG/SGB checking (#7) and remove SGB layouts and palette data (#1) 2023-07-26 17:02:33 +02:00
xCrystal
15f452ff26 Remove indoor sprites (#7), and improve overworld sprite sorting in VRAM (#2) 2023-07-26 10:30:47 +02:00
xCrystal
2d5bd722cd Clean up WRAM, SRAM, and HRAM space (#6) 2023-07-25 19:49:25 +02:00
xCrystal
787caa2147 Get rid of LANDMARK_SPECIAL (#1) 2023-07-25 18:32:57 +02:00
xCrystal
473c23a727 Remove unnecessary event and engine flags (#1) 2023-07-25 18:24:38 +02:00
xCrystal
7bbe559252 Remove phone scripts data and text (#1) 2023-07-25 16:39:30 +02:00
xCrystal
5147904f78 Remove original maps and object events (#1) 2023-07-25 15:33:08 +02:00
xCrystal
fc7f2d4e0e Remove Mobile, Battle Tower, Mystery Gift, and Odd Egg (#1) 2023-07-24 21:13:11 +02:00
vulcandth
31c55dc74d
Use BattleAnim_Dummy in data/moves/animations.asm (#1052) 2023-06-22 16:15:43 -04:00
vulcandth
438c48daad
Rename PAL_NPC_SILVER to PAL_NPC_EMOTE (#1053) 2023-06-01 07:47:53 -05:00
mid-kid
cfd432f468 Minor battle tower fixes 2023-03-08 13:52:47 +01:00
vulcandth
25e12c9391
wUnlockedUnowns engine_flag constants (#1025) 2022-12-26 13:14:10 -05:00
Rangi
8e135931a6 Require rgbds 0.6.0 2022-10-02 22:03:53 -04:00
Rangi
8fc3b8e6e3 Dance Theatre -> Dance Theater
Fixes #1008
2022-09-23 22:06:52 -04:00
Idain
553a272e52
TYPO: NUM_MOVE_EFECTS > NUM_MOVE_EFFECTS (#1009) 2022-09-21 22:01:39 -05:00
Andrew Cook
0f5540740b
Some Mobile code labeling and removed magic numbers (#993)
* Macro loop for EmptyAllSRAMBanks

* Many things labeled and magic numbers removed

* Conform to the style guide

* Rename URLs in mobile_46

* MOBILEAPI_19 -> MOBILEAPI_TELEPHONESTATUS

* Update engine/menus/empty_sram.asm

Co-authored-by: Rangi <35663410+Rangi42@users.noreply.github.com>

* Update ram/wram.asm

Co-authored-by: Rangi <35663410+Rangi42@users.noreply.github.com>

* Update mobile/mobile_46.asm

Co-authored-by: Rangi <35663410+Rangi42@users.noreply.github.com>

* Update mobile/mobile_46.asm

Co-authored-by: Rangi <35663410+Rangi42@users.noreply.github.com>

* Remove underscore from Set*DownloadURL symbols

* Begin Labeling TradeCornerHoldMon routines

* Add wMobileMon party_struct

* Add TRADE_CORNER_REQUEST_LENGTH constant

* Name battle tower action functions

* Label trade corner send/receive buffer

* Label the saved copy of the trade corner pokemon

also fix mailmsg_jp

* So many copies of decodeBase64Character

* Label another buffer

* Fix Alignment and use MOBILE_EMAIL_LENGTH

* `Function11ad8a` -> `MobileIncJumptableIndex`

* Apply Rangi Suggestions pass 1

Co-Authored-By: Rangi <35663410+Rangi42@users.noreply.github.com>

* Apply Suggestions 2

Co-authored-by: Rangi <35663410+Rangi42@users.noreply.github.com>
Co-authored-by: vulcandth <vulcandth@gmail.com>
2022-09-14 19:49:58 -05:00
Rangi
0d5cf5c8b9
Refer to "Rival", not "Silver" (#983)
Fixes #982
2022-08-10 21:24:56 -04:00
Rangi
367a104203 PP must be 40 or less 2022-08-10 21:20:53 -04:00
vulcandth
ef9b9bb437
Clean up bugs commented in the source code (#912)
Co-authored-by: Rangi <remy.oukaour+rangi42@gmail.com>
2022-07-09 16:12:02 -05:00
Rangi
f159654054 spriteanimoam macro corresponds to battleanimoam 2022-07-04 01:11:42 -04:00
Rangi
a2e8f078a4 Split "gfx anims" into "pic anims" and "sprite anims"
Fixes #876
2022-07-04 01:11:42 -04:00
vulcandth
5f0597e944
Rename SLP to SLP_MASK (#918)
Co-authored-by: Rangi <35663410+Rangi42@users.noreply.github.com>
2022-06-17 22:25:56 -04:00
vulcandth
3648afda16
RGBDS syntax updates (#905)
New MACRO and DEF syntax
2022-06-06 17:25:42 -04:00
Rangi
ab0f9c287a Use compound assignment operators 2021-11-23 20:18:08 -05:00
Rangi
39111486ab Fix #845: Liz gossips about a beautiful trainer, not Pokémon 2021-11-03 17:24:16 -04:00
Rangi
753ed7186c Use -1 for terminating happiness probability data 2021-10-28 17:02:13 -04:00
Rangi
f59f1bdb88 Standardize capitalization of ".Jumptable" 2021-06-19 19:52:05 -04:00
Rangi
ed0a0f7159 Move the dbbw, dbww, and dbwww macros to legacy 2021-05-30 15:51:49 -04:00
Rangi
b1dbadbdd3 Require rgbds 0.5.1
Use some new features: \<10> macro args, SECTION UNION, SIZEOF/STARTOF, and CHARLEN/CHARSUB
2021-05-09 12:26:28 -04:00
Rangi
316fa4b695 Use rgbds 0.5.0 2021-04-19 16:31:37 -04:00
Rangi
94057c7726 Verify uneven list sizes with list_start, li, and assert_list_length macros
This was discussed in #815
2021-03-22 17:17:08 -04:00
Rangi
dbe2360ecd Miscellaneous cleanup 2021-03-22 16:41:17 -04:00
Rangi
4522162d45 Consistent labels for each nickname in RAM 2021-03-17 16:38:21 -04:00
Rangi
6c8f8609cb Assert some more table widths 2021-03-17 11:38:01 -04:00
Rangi
3684296583 Revise some constant definitions 2021-03-16 18:06:18 -04:00
Rangi
dbabd8b4a9 Define MAPGROUP_* constants and verify MapGroup_* table sizes 2021-03-10 21:16:54 -05:00
Rangi
ef20126fe5 Verify wild data sizes with def_grass/water_wildmons and end_grass/water_wildmons macros 2021-03-04 17:58:30 -05:00
Rangi
40902ffe24 Verify data table sizes with table_width and assert_table_length macros
This was discussed in #706

It also uncovered some off-by-one issues with defining some constants.

A few structs now use rsreset/_RS to define their offset constants, as discussed in #739
2021-03-04 00:15:03 -05:00
Rangi
a539578006
Merge pull request #798 from CelestialAmber/master
Fix typo
2021-02-05 09:45:18 -08:00
Rangi
4264d53eb6 Identify some more labels 2021-02-05 12:44:21 -05:00
Amber Brault
b391b6cef0 Fix typo 2021-01-21 11:01:53 -05:00
Rangi
f773fd1dd8 The 'tmhm' macro adjusts to the number of TMs/HMs/tutors 2021-01-06 10:20:19 -05:00
Rangi
99e66c2557 Rename some labels
- Remove "Buffer" suffix from some byte and word quantities
- Change "Ptr" to "Pointer"

Fixes #789
2020-12-23 16:29:30 -05:00
Rangi
fff343349d Clarify signed magnitude in the growth_rate macro 2020-12-20 23:35:22 -05:00
Rangi
145e752266 Use assert to ensure correct base data size 2020-11-17 16:14:45 -05:00
Rangi
97e981985b Correct some filename comments 2020-11-17 11:12:21 -05:00
Rangi
9b3c45b14d Resolve some "???" comments 2020-11-17 11:09:02 -05:00
Rangi
62b756c46e Rename "dummy game" to "memory game" 2020-11-08 19:32:57 -05:00
Rangi
826e070f04 More syncing with pokegold 2020-11-03 10:13:06 -05:00
Rangi
6220200f0f Identify some more labels, and make some more consistent 2020-11-01 12:36:38 -05:00
Rangi
4a323cf591 UnusedSpriteAnimGFX was to sprite anims as AnimObjGFX is to battle anims 2020-10-30 17:41:03 -04:00
Rangi
fe1a58deea Identify wSpriteAnimDict key constants 2020-10-30 15:39:08 -04:00
Rangi
1237156948 Identify mobile Name Card exchange labels 2020-10-30 10:45:31 -04:00
Rangi
ba5bc304f9 Updates to more closely sync with pokegold 2020-10-29 23:23:57 -04:00
Rangi
bcc0d633e9 Identify the remaining (non-mobile) uses of another WRAM union 2020-10-29 14:51:41 -04:00
Rangi
ea426a8879 Identify more WRAM labels, and start a <X>_DummyFunction label convention 2020-10-28 14:34:38 -04:00
Rangi
6d333bed5f Replace many '; unused' with '; unreferenced' 2020-10-28 10:21:10 -04:00
Rangi
2738858985 Create data/collision/ for tile collision-related data 2020-10-27 10:00:56 -04:00
Rangi
9dcdad5e60 Comment, remove, or revise many unreferenced labels 2020-10-26 20:29:58 -04:00
Rangi
7991db972b Identify some more link.asm labels (syncing to pokegold) 2020-10-23 13:36:54 -04:00
Rangi
d8310c166d Identify some more map object labels and constants 2020-10-22 17:41:48 -04:00
Rangi
ae4fe08084 Identify some more labels (a few link-related) 2020-10-22 00:53:54 -04:00
7Soul
cf26f55985
Identify battle bg effects functions and constants (#773)
Identify battle bg effects functions and constants
2020-10-06 15:45:09 -04:00
7Soul
836da09f4e
Identify anim object constants (#772)
Identify anim object constants
2020-10-04 15:06:38 -04:00
7Soul
2ffc5f907f
Identify battle animation functions (#771)
Identify battle animation functions
2020-10-03 21:54:02 -04:00
mid-kid
353f78f493 GS_INTRO_STAR/SPARKLE -> GS_GAMEFREAK_LOGO_STAR/SPARKLE
These two sprite animations are related to the Game Freak Logo splash
screen, not the actual intro.
2020-08-27 15:13:41 +02:00
Rangi
7729dcd204 Consistent constants for radio data table sizes (could still be better) 2020-08-13 13:47:50 -04:00
Rangi
dd369f3199 Move EngineFlags and SpecialsPointers into data/engine/ 2020-07-22 20:24:53 -04:00
Rangi
11dc805de0 Revert "Factor out tables into data/overworld/"
This reverts commit b5a7e7de3e.
2020-07-22 20:21:26 -04:00
Rangi
b5a7e7de3e Factor out tables into data/overworld/
Fixes #749
2020-07-22 15:22:58 -04:00
Rangi
212846af57 Treat map setup commands like trade script commands
Fixes #736
2020-07-22 13:37:43 -04:00
Rangi
a9941e28cc Define NUM_FLYPOINTS 2020-07-21 11:48:39 -04:00