Idain
b06cfe78fd
Use NUM_BATTLE_STATS instead of raw numbers
2022-04-06 10:28:18 +00:00
Rangi
e706b878d9
Use ~X instead of $ff ^ X
2021-11-23 20:37:18 -05:00
IIMarckus
a283f44954
More EFFECTIVEness.
2021-08-16 14:44:57 -06:00
IIMarckus
52290d8e03
Use EFFECTIVE constant for 1.0× battle damage.
2021-08-16 14:42:45 -06:00
Rangi
7d3ea88611
Rename GetFarHalfword to GetFarWord
...
Fixes #796
2021-01-09 15:16:05 -05:00
Rangi
99e66c2557
Rename some labels
...
- Remove "Buffer" suffix from some byte and word quantities
- Change "Ptr" to "Pointer"
Fixes #789
2020-12-23 16:29:30 -05:00
Rangi
4613bcfadf
Use STRING_BUFFER_LENGTH for the wStringBuffers
2020-11-24 20:11:17 -05:00
Rangi
6a5edc98e9
Terser damage calculation constants
2020-11-09 16:12:19 -05:00
Rangi
7254c10093
Identify remaining uses of wBuffer1-6 as general-purpose HP buffers or mobile
2020-11-03 23:25:22 -05:00
Rangi
826e070f04
More syncing with pokegold
2020-11-03 10:13:06 -05:00
Rangi
6d333bed5f
Replace many '; unused' with '; unreferenced'
2020-10-28 10:21:10 -04:00
Rangi
9dcdad5e60
Comment, remove, or revise many unreferenced labels
2020-10-26 20:29:58 -04:00
Rangi
93dcc8b6eb
Identify SwitchItemsInBag labels
...
Thanks to FIQ for having done so in Polished Crystal
2020-10-21 15:39:15 -04:00
Rangi
cf37abd3ec
Remove wKickCounter and wPresentPower aliases for wBattleAnimParam
2020-08-29 20:35:49 -04:00
Rangi
bb25c1074c
Use LOAD/ENDL for OAM DMA code in HRAM (requires rgbds 0.4.1)
2020-07-21 19:45:25 -04:00
Rangi
e239aa4aba
Disassemble the final English debug ROM
2020-07-13 15:18:28 -04:00
Rangi
7eef66af3f
Use MAX_NEUTRAL_DAMAGE in BattleCommand_DamageCalc
...
Also make .gitignore consistent with pokered
2020-07-05 15:12:53 -04:00
Rangi
f76dabedcc
Harmonize engine/{battle, battle_anims, events, games} with pokegold
2020-06-16 19:32:36 -04:00
Rangi
e3f07b9612
Undo incorrect comment
2020-06-15 10:26:10 -04:00
Rangi
ffbca4d5f3
Adding 0 is pointless in CheckMimicUsed
2020-06-15 08:43:40 -04:00
Rangi
75035a71a5
Label some mobile addresses, and revise some comments
2020-06-13 18:48:26 -04:00
mid-kid
e3e0bcd653
#641 fixes and additions. ( #646 )
...
Name a lot of text labels according to our conventions
2019-10-20 18:24:17 -04:00
mid-kid
3e78e5b2b6
TextBox -> Textbox
...
Homogenizing names.
2019-04-09 16:09:18 +02:00
Rangi
6393ecb7e5
More consistent formatting
2019-03-03 19:55:28 -05:00
Rangi
5207615cdc
Document a bugfix: 1/256 failure rate for 100% effect chance
2019-01-05 20:30:46 -05:00
Rangi
e025ab9db0
Merge pull request #578 from mid-kid/master
...
Fixes in the animation subsystem.
2018-12-09 17:44:09 -05:00
mid-kid
5dfe652ff6
CalcStats -> CalcBattleStats
...
Confusingly ambiguous name
2018-11-23 23:03:27 +01:00
mid-kid
c210f052a8
Move BattleSideCopy to transform.asm
2018-11-21 14:14:34 +01:00
Rangi
3202c4f3df
Resolve issue #575 : Rename text commands
2018-11-18 12:41:11 -05:00
mid-kid
940256569b
text_jump → text_far
...
The previous name for this was rather misleading. It isn't an actual
jump like you'd expect the `jp` instruction to behave as. Instead, it
behaves more like a `farcall`.
This also makes it consistent with its current command ID name of
`TX_FAR`.
2018-11-05 22:26:18 +01:00
Rangi
3b20a18200
Identify BATTLEACTION_D and _E (thanks, ax6)
2018-10-21 00:52:10 -04:00
Rangi
557ce82073
hQuotient is a four-byte buffer ( fixes #558 )
2018-08-26 13:49:38 -04:00
Rangi
eb1e3636bb
Use labels instead of constants for HRAM
...
Use explicit ldh instruction to access HRAM locations, don't rely on optimizing ld
2018-08-25 14:28:22 -04:00
mid-kid
50da83cb23
CheckDestinyBond -> CheckFaint
...
Its main function is fainting the opponent and ending the move effect.
Updated the comment accordingly.
2018-08-17 20:16:37 +02:00
mid-kid
79cf90ab5e
Fix some StatUp-related labels
2018-08-17 17:48:41 +02:00
mid-kid
2e147d1128
GetDamageStatsCritical -> CheckDamageStatsCritical
...
Clarified its usage, as the comments surrounding it were factually
wrong.
2018-08-16 16:11:28 +02:00
Rangi
1d96a79a37
No wCurMove alias for wCurSpecies
2018-07-29 16:04:38 -04:00
Rangi
9dec80b07e
Add meaningful aliases for wd265
...
Introduce MONICON_* constants
Introduce BATTLEPLAYERACTION_* constants
2018-07-29 00:25:52 -04:00
Rangi
cdfdfed17b
Crystal fixed TruncateHL_BC in single player
2018-07-27 21:32:14 -04:00
mid-kid
9aa6b55d7b
Merge branch 'master' of https://github.com/pret/pokecrystal
2018-07-27 11:24:59 +02:00
mid-kid
e43c89bc80
Consistently use the diff format in bugs_and_glitches
2018-07-26 23:34:03 +02:00
Rangi
4f0c9cecf9
StringCmp → CompareBytes; CompareLong → CompareBytesLong
...
hStringCmpString[1/2] → h[EnemyMon/PartyMon1]Speed
2018-07-23 00:25:53 -04:00
Rangi
b565e6a9dc
Miscellaneous reorganization fixes
2018-07-04 02:42:11 -04:00
Rangi
1caa50a647
No space between labels and bodies
2018-06-25 12:24:18 -04:00
Rangi
9f3e9145f9
Remove more triple newlines
2018-06-25 12:01:02 -04:00
Rangi
67d1364c7a
Fix triple newlines left over from removing address comments
2018-06-24 23:22:50 -04:00
mid-kid
1d9a68dbdd
Remove all address comments
2018-06-24 16:13:22 +02:00
Rangi
fbe82a7fe0
Note which labels are only needed for locating banks (relevant to issue #485 )
2018-06-12 23:29:15 -04:00
mid-kid
5e9c785b3f
Merge branch 'master' of https://github.com/pret/pokecrystal
2018-06-04 11:05:53 +02:00
mid-kid
17087489c6
Miscellaneous fixes in the use of _command constants.
2018-06-01 09:04:36 +02:00