Commit Graph

4521 Commits

Author SHA1 Message Date
mid-kid
43eff93861 Small home/ reorganization
Time to move everything out of home.asm:
- InexplicablyEmptyFunction was moved to home/map.asm
- The wDebugFlags functions and xor_a brothers were moved to
  home/flag.asm because they're all flag-related.
- ret_2f3e was moved into home/region.asm
- The register alias sisters were moved to a new file called home/call_regs.asm
- IsInArray and SkipNames were joined by AddNTimes from home/math.asm
  into home/array.asm, as they're all used to index arrays.
- CallPointerAt was moved into home/print_text.asm because given the
  contents of that file it doesn't feel very out of place (that file
  isn't very aptly named...)
- CountSetBits was moved into home/pokedex_flags.asm because it's unique
  use is counting the amount of seen/caught mon in the podedex. GetWeekday
  was pulled into this by proximity.

Other changes were also made:
- PushLYOverrides was moved from home/sprite_anims.asm to
  home/battle.asm, because it's almost exclusively used for battle
  animations, with the lone exception being the Magnet Train.
- home/copy.asm was renamed to home/gfx.asm, as it's all gfx-related
- home/copy2.asm was renamed to home/copy.asm, now it's the only file
  called copy.
- SetHPPal and GetHPPal were moved from home/hp_pals.asm to
  home/tilemap.asm, as they're attrmap related, like many functions in
  that file are.
- home/rtc.asm was renamed to home/time_palettes.asm, as it had very
  little to do with the RTC at all, all RTC functions being in home/time.asm
- home/handshake.asm was renamed to home/printer.asm.
- home/mon_data_2.asm was renamed to home/mon_party.asm.
2020-02-22 00:23:47 +01:00
mid-kid
9a927c1b3e
Merge pull request #685 from mid-kid/master
Moshi moshi? minoru enhansumentsu desu
2020-02-21 21:11:36 +01:00
mid-kid
2a8c969bc7 Fix some comments and inmediates 2020-02-21 21:10:55 +01:00
mid-kid
345b585a78 Document GetTMHMName locals
This was documented in pokegold apparently
2020-02-21 21:10:43 +01:00
mid-kid
c22e268083 RTC -> UpdateTimeAndPals
Rename clear misnomer.
Most of the related functions in that file aren't really aptly named but
I don't know good names right now.
2020-02-21 18:21:29 +01:00
mid-kid
18013b468a Fix tools/unnamed.py for new rgbds object format 2020-02-21 01:48:17 +01:00
mid-kid
317188b35f Correct fash ship typos 2020-02-16 12:22:13 +01:00
mid-kid
75a6bb5df6 PanicResetClock -> ClearClock
Funky name that only exists based on what it's used for, not so much
what it is.
2020-02-16 12:20:20 +01:00
Rangi
65a780994f
Merge pull request #684 from Rangi42/master
Define TileCollisionTable as a standard 'db' series
2020-02-13 19:28:14 -05:00
Rangi
88bbdb6a2f Define TileCollisionTable as a standard 'db' series 2020-02-13 19:07:19 -05:00
mid-kid
26b8bf003e Standardize on lowercase Tilemap and Attrmap
We used to have a mixture of TileMap and and Tilemap, as well as the
similar AttrMap. Standardize on one.
2020-02-13 18:31:10 +01:00
mid-kid
34ceaac71d Call_LoadTempTileMapToTileMap → SafeLoadTempTileMapToTileMap
Stupid name is stupid smh tbh fam.
2020-02-13 18:31:10 +01:00
mid-kid
9f2c2627f5 Make tools/sort_symfile.sh case insensitive
Development versions of rgblink now output lowercase
2020-02-13 18:31:10 +01:00
mid-kid
a241f049df Remove FarCall prefix from SwapTextboxPalettes and ScrollBGMapPalettes
No prefix for the farcall, prefix with an underscore for the farcalled.
This matches what is done for pretty much every other home function.
2020-02-13 18:31:10 +01:00
mid-kid
991d207d86 OWFlash -> FlashFunction
Match the other overworld move functions
2020-02-13 18:31:10 +01:00
mid-kid
a094c58f1e Split up engine/events/misc_scripts_2.asm
New files are:
- engine/events/hidden_item.asm
- engine/events/repel.asm
2020-02-13 18:31:10 +01:00
mid-kid
0d81f1c470 InitSpriteAnimStruct <-> _InitSpriteAnimStruct
These were the wrong way around, as the function in home should not be
prefixed
2020-02-13 18:31:10 +01:00
Rangi
53cf08b6b3
Merge pull request #682 from Rangi42/master
Miscellaneous fixes
2020-02-13 12:21:37 -05:00
Rangi
ceadab8cd1 PnP_HiddenPlaces -> PnP_Places
The "Places & People" radio station does not avoid these maps; it only describes these maps.
2020-02-06 11:07:42 -05:00
Rangi
fb9cbe7d1e
Merge pull request #650 from pret/audio-macros
Update audio macros and arguments
2020-02-05 18:51:20 -05:00
dannye
cbf14612ea Update docs/music_commands.md
to clarify a few caveats about some macro parameters
2020-02-04 20:03:22 -06:00
mid-kid
24c058bc0a Fix tools/unnamed.py for new rgbds object format 2020-02-04 23:19:41 +01:00
Rangi
ed44d1cdb7
Merge pull request #680 from Rangi42/master
Miscellaneous fixes for #676
2020-02-04 11:17:14 -05:00
Rangi
24a23b1922 Use CMDQUEUE constants 2020-02-04 11:11:43 -05:00
Rangi
d482dc28f4 Identify four padding bytes in base data as beta front/back pic pointers 2020-02-04 11:07:16 -05:00
mid-kid
44b361c1bb Merge branch 'master' into audio-macros 2020-02-04 16:03:01 +01:00
Rangi
b1c8548628 Clean up comments in home/time.asm 2020-01-31 20:59:48 -05:00
Colton G. Rushton
dd6812c06a Optimize the Perish Song+Spikes glitch fix 2020-01-27 19:26:11 +01:00
Colton G. Rushton
f369003a6e Add Dude full box glitch fix
Added a minor fix for the Dude full box glitch that was proposed by ISSOtm.
2020-01-23 17:57:19 +01:00
Rangi
80cf859cd3 PHONE_DISPLAY_HEIGHT is 4, the number of visible phone entries 2020-01-19 14:10:10 -05:00
dannye
e7be25948d Merge branch 'master' into audio-macros 2020-01-06 22:07:33 -06:00
dannye
99d16d616d Update docs/music_commands.md
and remove the pokered compatibility macros
2020-01-05 15:41:55 -06:00
Rangi
bd67691bc3
Merge pull request #671 from Rangi42/master
Identify "branch" labels in battle animations
2020-01-05 15:45:14 -05:00
Rangi
c04b455aac Identify "branch" labels in battle animations 2020-01-05 15:42:21 -05:00
mid-kid
77be50d26a
Merge pull request #670 from Rangi42/master
Identify "branch" labels in music files
2020-01-05 19:51:30 +00:00
Rangi
cf18b9458a Replace "branch" labels in music files with local names 2020-01-05 14:17:40 -05:00
Rangi
94ebdab6d3
Merge pull request #660 from mid-kid/master
Make the map setup commands match the actual function names better
2020-01-04 20:08:43 -05:00
Rangi
9aeb0ab522 Revise bugs_and_glitches.md 2020-01-04 17:10:26 -05:00
Colton G. Rushton
5728d01417 Add and simplify bugfixes in bugs_and_glitches.md (#664)
Add extra fixes for bugs covered on Bulbapedia (and simplify others)
2020-01-04 16:52:08 -05:00
mid-kid
e678eb78a1
New Discord invite link
Something something community.
2019-12-11 20:10:48 +01:00
Rangi
fa7261a8ee Update some labels 2019-12-03 09:17:21 -05:00
Rangi
083d51fd58
Merge pull request #662 from Rangi42/master
Resolve miscellaneous issue #658
2019-11-24 03:57:20 -05:00
Rangi
0e311ad709 Fix miscellaneous points made in #658 2019-11-23 20:56:22 -05:00
Rangi
ef48ae98b5 Separate tilesets.o goes with pics.o and sprites.o 2019-11-23 20:43:33 -05:00
Rangi
008f591a3a Keep mobile SECTION declarations in main.asm, and name them "mobileXX" like "bankXX" 2019-11-23 20:32:20 -05:00
mid-kid
5e104de3f5
Merge pull request #661 from mid-kid/patch-1
Fixed a charmap warning with the new RGBDS
2019-11-19 00:08:28 +00:00
mid-kid
563ba14196 Remove old charmap sections 2019-11-19 01:01:47 +01:00
Colton G. Rushton
7b2377c41e Fixed a charmap warning with the new RGBDS 2019-11-18 18:27:48 +01:00
mid-kid
739a60b33c Make the map setup commands match the actual function names better
These functions used as map setup commands are used in other places,
too, so I can't prefix them under the same. The names should match
except I won't repeat "map" in a map setup command name.
2019-11-18 18:21:57 +01:00
mid-kid
1c41b2e579 Fix some mobile-related things 2019-11-18 18:21:57 +01:00