Remy Oukaour
c6fefd0fe8
Rename overworld sprite files, consistent with their constants
2017-12-11 00:17:39 -05:00
Remy Oukaour
08b14e593e
Rename tilesets, consistent with constant names
2017-12-10 23:56:10 -05:00
Remy Oukaour
a551e345df
PokeCenter → Pokecenter (consistent with the POKECENTER map constants)
2017-12-10 22:34:42 -05:00
Remy Oukaour
a827c02757
Use MORN/DAY/NITE shifts for time-based person_events
2017-12-10 21:00:05 -05:00
Remy Oukaour
b4261d27d8
Use new palette constants
2017-12-10 20:50:08 -05:00
Remy Oukaour
a0bef01a1d
Define more palette constants
2017-12-10 20:10:39 -05:00
Remy Oukaour
0f16ba854a
Comment palette colors and roof map groups
2017-12-10 20:05:34 -05:00
Remy Oukaour
62f5913943
All map triggers use the maptrigger macro, not dw
...
.MapTriggers and .MapCallbacks lists are formatted consistently with .Warps, .XYTriggers, .Signposts, and .PersonEvents
2017-12-10 17:53:21 -05:00
Remy Oukaour
66527d861f
"Trainer*AfterBattleText" labels
2017-12-10 15:44:41 -05:00
Remy Oukaour
25bff5c1ac
Remove unused .asm file
2017-12-10 13:58:55 -05:00
Remy Oukaour
fba44a5929
Single files for tilesets/data.asm and maps/blockdata.asm
2017-12-10 13:53:02 -05:00
Remy Oukaour
699495bfcb
Consistent capitalization for map names, matching their constants
2017-12-10 13:37:15 -05:00
yenatch
94c7def488
Merge pull request #409 from roukaour/master
...
Document constants with comments, actual names, and more thorough usage
2017-12-10 01:47:10 -05:00
Remy Oukaour
d554b997c5
Use correct WRAM labels for intro/title scenes
...
Remove outdated WRAM alias comments
2017-12-10 00:18:29 -05:00
Remy Oukaour
ab7025a144
Consistent code formatting: no redundant as and spaces after commas
2017-12-10 00:06:20 -05:00
Remy Oukaour
32ea595c47
Move some gfx/unknown/ files into meaningful directories
2017-12-09 23:37:08 -05:00
Remy Oukaour
31901f73b0
Move some gfx/misc/ files into meaningful directories
2017-12-09 22:57:41 -05:00
Remy Oukaour
59ee673775
Consistent pointer labels in WRAM
2017-12-09 22:24:43 -05:00
Remy Oukaour
e29a1f8f94
Clarify which rgbds builds to use
2017-12-09 22:14:11 -05:00
Remy Oukaour
7ccb11c903
Add constants for battle object colors
2017-12-09 22:07:52 -05:00
Remy Oukaour
cd2a748128
More WRAM cleanup
2017-12-09 22:00:36 -05:00
Remy Oukaour
880fb511e1
More WRAM organization
2017-12-09 15:28:03 -05:00
Remy Oukaour
e3c686f6df
Further WRAM organization
2017-12-09 15:14:51 -05:00
Remy Oukaour
5a5df2ab87
More WRAM organization
2017-12-09 14:47:32 -05:00
Remy Oukaour
16c6696dd5
Start organizing WRAM
...
- Use db and dw when they're more meaningful than ds 1/2
- Use unions to group related labels
2017-12-09 13:58:49 -05:00
Remy Oukaour
0b7d8d44ad
More constants
2017-12-09 13:28:23 -05:00
Remy Oukaour
55d19b6dca
Separate file for mobile constants
2017-12-09 12:57:42 -05:00
Remy Oukaour
6a41d4f63e
Define more charmap characters and use them in place of hard-coded numbers
2017-12-09 12:57:23 -05:00
Remy Oukaour
512863989f
Document constants with comments, actual names, and more thorough usage
2017-12-09 02:15:46 -05:00
yenatch
89b9292db0
Merge pull request #405 from yenatch/fix-no-rule-error
...
fix cryptic 'no rule' error when a prerequisite is missing
2017-12-06 00:09:21 -05:00
yenatch
cf7eec3bde
Merge pull request #404 from surskitty/master
...
De-Magic-Numbers the Rocket Grunts
2017-12-06 00:06:11 -05:00
yenatch
08ddbe843b
Merge pull request #403 from mid-kid/master
...
mid-kid's patches: The Experience
2017-12-06 00:04:14 -05:00
yenatch
346a6f8dcb
fix make 3.81
...
the shell newline capture doesnt work in 3.81, so that's gone
2017-12-03 21:58:27 -05:00
yenatch
ea8aaeb8e3
fix cryptic 'no rule' error when a prerequisite is missing
...
at the cost of scan_includes running before the rules are actually evaluated
2017-12-03 20:46:11 -05:00
mid-kid
f619e84e4f
Remove useless file
...
Also fixed a comment on top of music_pointers.asm
2017-11-30 21:44:27 +01:00
mid-kid
a1fc73603e
Label all of PARTYMENUACTION_*
...
It's pretty clear what it's used for.
PartyMenuActionText is used for two things:
1) Storing what kind of action we're going to do (<$10)
2) Storing the text for some kind of healing stuff I'm not entirely sure (>=$f0)
In the former case, if GetPartyMenuTilemapPointers is ran, it will be
used to pick a sequence of actions that should be done, specified in the
table, and it'll print the corresponding string using the
PartyMenuStrings table. The items in the sequence of actions that should
be done are in WritePartyMenuTilemap.
Strangely enough, one possible value is left completely unused:
PARTYMENUACTION_GIVE_MON_FEMALE. It works in the exact same way as it's
male counterpart, and as such I don't believe it was used in the
japanese version either, since it doesn't matter which gender your 'mon
is when you put 'em in the daycare.
2017-11-30 20:35:58 +01:00
Marcus Huderle
7a2a205281
Merge pull request #400 from mid-kid/master
...
mid-kid's amazing patches act 2
2017-11-29 17:13:47 -08:00
mid-kid
2cc2f057e8
Fix some SPRITE_ANIM_FRAMESET_ constants
...
Thanks to @roukaour for the fixes.
2017-11-29 20:24:19 +01:00
surskitty
15015e4877
Making all Rocket Grunts call the constant.
2017-11-27 00:38:15 -05:00
surskitty
b6c1ceed80
Constants for Rocket Grunt rosters.
...
Having constants rather than magic numbers should make it easier
to remove unused grunts from the roster.
2017-11-27 00:35:10 -05:00
surskitty
9c28b822cb
Fighting Dojo npc labels.
2017-11-27 00:07:24 -05:00
mid-kid
e39c8afbf2
Rename all files in data/pokedex/entries/
...
Some people suggested this would be a good idea, and make management of
the files easier. I'm inclined to agree.
2017-11-26 23:10:49 +01:00
mid-kid
09d9f2c1ef
Add MobileError-related labels
...
This function is called from a few different places in the mobile code,
including from one special that is only executed when the
BattleTowerRoomMenu special returns with a non-zero code.
Since that special causes a blue "error" screen to appear, that looks
the exact same as the one you'd get when trying to connect from the
mobile trade corner/battle colosseum in a Pokémon Center's top floor,
and this function contains a bunch of japanese strings in a jumptable, I
think it's reasonable to assume it should be called
"DisplayMobileError".
2017-11-26 11:35:13 +01:00
mid-kid
89d6a24644
Script_ChoseChallenge -> Script_ChooseChallenge
...
This script is called for the player to *choose* (or pick) the challenge
they want to undertake.
2017-11-26 11:29:38 +01:00
mid-kid
afc92eadc1
Label BattleTowerRoomMenu
...
All of the functions called by it are prefixed with BattleTowerRoomMenu,
but a bunch of them seem more generic than that, since they're part of
different mobile menus. Also called another menu jumptable
BattleTowerRoomMenu2 for the lack of a better name (only the Yes/No menu
functions are used in western crystal).
The names of the more generic functions should be fixed when we start
labelling other menus.
2017-11-25 17:03:20 +01:00
Marcus Huderle
c28be02a19
Merge pull request #395 from surskitty/master
...
Some Script Labels
2017-11-21 17:18:29 -08:00
Marcus Huderle
b97287be29
Merge pull request #397 from mid-kid/master
...
A few more labels and comments
2017-11-21 17:15:25 -08:00
mid-kid
e5f9fddb86
PewterPokeCEnter2FBeta -> PewterPokeCenter2FBeta
...
Probably a typo.
2017-11-22 00:34:37 +01:00
mid-kid
359d73ceef
Move LoadOverworldFont to main.asm
...
It doesn't fit correctly in misc/mobile_41.asm.
Also moved the font images out of gfx/unknown and into gfx/font.
2017-11-21 23:53:51 +01:00
mid-kid
df118afbca
Move all of constants/sram_constants.asm into sram
...
This way we can easily use `BANK()` where appropriate, and it is more
tidy.
2017-11-20 23:07:24 +01:00
