Rangi
a6cffc04c3
Use MAP_LENGTH
in GetMapPointer
2021-12-30 18:16:22 -05:00
Rangi
e706b878d9
Use ~X instead of $ff ^ X
2021-11-23 20:37:18 -05:00
Andrew Cook
588cf88257
Label wram variables for in home/mobile and lib/mobile ( #843 )
2021-09-05 12:47:24 -04:00
Rangi
b1dbadbdd3
Require rgbds 0.5.1
...
Use some new features: \<10> macro args, SECTION UNION, SIZEOF/STARTOF, and CHARLEN/CHARSUB
2021-05-09 12:26:28 -04:00
Rangi
4522162d45
Consistent labels for each nickname in RAM
2021-03-17 16:38:21 -04:00
Rangi
3684296583
Revise some constant definitions
2021-03-16 18:06:18 -04:00
Rangi
d132a20b7a
Verify script command table sizes
2021-03-11 16:28:52 -05:00
Rangi
40902ffe24
Verify data table sizes with table_width and assert_table_length macros
...
This was discussed in #706
It also uncovered some off-by-one issues with defining some constants.
A few structs now use rsreset/_RS to define their offset constants, as discussed in #739
2021-03-04 00:15:03 -05:00
Rangi
4401d24074
Identify link sync buffers, separate from link action bytes
...
Fixes #803
2021-02-22 12:02:52 -05:00
Rangi
7d3ea88611
Rename GetFarHalfword to GetFarWord
...
Fixes #796
2021-01-09 15:16:05 -05:00
Rangi
5db892782a
Remove "Buffer" suffix from two HRAM labels
2020-12-23 16:54:28 -05:00
Rangi
99e66c2557
Rename some labels
...
- Remove "Buffer" suffix from some byte and word quantities
- Change "Ptr" to "Pointer"
Fixes #789
2020-12-23 16:29:30 -05:00
Rangi
098903fc97
FarString -> PlaceFarString, and document a BrokenPlaceFarString bug
2020-12-07 13:32:08 -05:00
aljohnston112
7b9d8767d4
Identified two magic numbers and cleaned up some comments ( #783 )
...
Improve the audio engine's comments and replace some magic numbers with constants
2020-12-07 12:44:16 -05:00
Rangi
9b3c45b14d
Resolve some "???" comments
2020-11-17 11:09:02 -05:00
Rangi
17894e5f39
Replace $0 with 0 for "ld l, a / ld h, 0" idiom
2020-11-09 15:20:40 -05:00
Rangi
01d6e6c758
Group some link.asm code into "paragraphs"
2020-11-02 19:32:14 -05:00
Rangi
ba5bc304f9
Updates to more closely sync with pokegold
2020-10-29 23:23:57 -04:00
Rangi
7883e8f431
Define SERIAL_LINK_BYTE_TIMEOUT
2020-10-29 16:43:28 -04:00
Rangi
bcc0d633e9
Identify the remaining (non-mobile) uses of another WRAM union
2020-10-29 14:51:41 -04:00
Rangi
ea426a8879
Identify more WRAM labels, and start a <X>_DummyFunction label convention
2020-10-28 14:34:38 -04:00
Rangi
6d333bed5f
Replace many '; unused' with '; unreferenced'
2020-10-28 10:21:10 -04:00
Rangi
9dcdad5e60
Comment, remove, or revise many unreferenced labels
2020-10-26 20:29:58 -04:00
Rangi
bd3f634049
Identify remaining map object labels
2020-10-22 21:30:21 -04:00
Rangi
d8310c166d
Identify some more map object labels and constants
2020-10-22 17:41:48 -04:00
Rangi
ae4fe08084
Identify some more labels (a few link-related)
2020-10-22 00:53:54 -04:00
Rangi
ff2d850219
Identify some more unnamed labels
2020-10-05 12:02:56 -04:00
Rangi
306c85750e
Identify some more unnamed labels
2020-10-04 20:10:39 -04:00
Rangi
0b31d12dac
Merge pull request #756 from mid-kid/master
...
Rub a dub dub, thanks for the grub
2020-08-18 16:35:15 -04:00
ISSOtm
e0b783bb7b
Enable compatibility with upcoming RGBASM version
...
This is additionally required, because an `elif`'s condition is evaluated even
when it's about to be skipped over, and this `"\2"` will become an error
2020-08-18 13:41:59 +02:00
Rangi
9d6ac04c9d
"<NULL>" -> 0, for 'and a'
2020-08-17 16:29:08 -04:00
Rangi
328a6737db
Use ISCONST for future rgbds lexer compatibility
2020-08-17 13:02:49 -04:00
mid-kid
b6055b1944
Use TRUE for hCGBPalUpdate
2020-08-05 16:02:48 +02:00
mid-kid
6f30d79620
TX_NUM -> TX_DECIMAL
2020-08-03 23:35:18 +02:00
mid-kid
79bb2784e9
Better label 2D menu data
2020-08-03 22:56:49 +02:00
Rangi
e239aa4aba
Disassemble the final English debug ROM
2020-07-13 15:18:28 -04:00
Rangi
b3bd682366
text_linkpromptbutton -> text_waitbutton
...
Removes support for text_waitbutton as a legacy alias for text_promptbutton.
2020-07-06 12:55:31 -04:00
Rangi
f5ac9b0eb7
SCGB_PARTY_MENU_HP_PALS -> SCGB_PARTY_MENU_HP_BARS, and SCGB_RAM -> SCGB_DEFAULT
2020-07-04 16:18:16 -04:00
Rangi
fce6243b43
Identify more labels, and use the jumptable macro when possible
2020-07-01 13:13:49 -04:00
Rangi
e171c84c29
Identify more labels and constants
2020-06-29 19:35:47 -04:00
Rangi
61847b3596
Identify some more labels
2020-06-22 16:30:13 -04:00
Rangi
e0d07fba3f
Sync PokeFluteTerminator with pokegold
2020-06-21 19:01:54 -04:00
Rangi
c3c18dd196
Comment more ROM labels as unreferenced
...
(Some unreferenced labels are above code which is still used via fallthrough!)
2020-06-21 18:33:31 -04:00
Rangi
91774f206e
Replace "Unreferenced" labels with "; unreferenced" comments
2020-06-21 16:27:43 -04:00
Rangi
cc460a17b0
Harmonize engine/{movie, pokemon} with pokegold (renames GetSRAMBank to OpenSRAM)
...
To do: engine/{menus, overworld}
2020-06-17 17:03:38 -04:00
Rangi
f2550fc3c2
ReplaceKrisSprite -> UpdatePlayerSprite
2020-06-16 19:38:00 -04:00
Rangi
c552390a15
Harmonize home/ with pokegold
2020-06-16 15:49:32 -04:00
Rangi
b9f2b93c17
Harmonize some more symbols with pokegold
2020-06-16 11:28:52 -04:00
Rangi
f1513ae8ad
Add some comments to UpdateBGMap
2020-05-19 20:00:58 -04:00
Rangi
156f2cc3ef
Update some routine labels, including unreferenced ones
2020-05-18 11:59:48 -04:00
Rangi
e32cf1bfd1
Miscellaneous cleanup noted in #709
2020-05-17 20:59:15 -04:00
Rangi
395ebd8386
Format all CopyTilemapAtOnce variations the same way
2020-05-16 22:25:52 -04:00
Rangi
b69526a908
Miscellaneous fixes
...
Addresses the haircut brothers' probability comments in #709
2020-05-05 10:17:02 -04:00
Rangi
576cbf5b3e
Miscellaneous fixes, including one for the Pokédex design flaw by ax6
2020-04-18 17:31:51 -04:00
Rangi
58b377f25b
Fix #709 miscellaneous issues
2020-04-16 09:30:50 -04:00
Rangi
a40ddc4668
Ensure that the cartridge header is patched over all $00s, and comment on the entry point format
2020-04-06 14:44:07 -04:00
Rangi
10909e6b43
hStackBank -> hTempBank
2020-04-06 13:02:23 -04:00
Rangi
1ec60810b8
hBuffer -> hStackBank and hFarByte
2020-04-06 12:52:46 -04:00
Rangi
79184bc718
Miscellaneous fixes:
...
- `hSecondsBackup` -> `hUnusedBackup`
- `ld bc, hBGMapAddress + 1` -> `bccoord -1, -2, 0`
- Identify some `.asm_XXX` labels
2020-04-04 15:43:10 -04:00
Rangi
0ee9d7a48b
Upgrade to rgbds 0.4.0
...
- fail for rgbds < 0.4.0
- `rst <Label>`
- `ds <count>, <byte>`
- `shift <N>`
- ASCII "\r"
- Sorted .sym file
2020-04-04 15:15:02 -04:00
Rangi
6a6ba10315
rgbds supports 'X - 1' instead of 'X + -1'
2020-03-21 14:01:05 -04:00
Rangi
ad50e94b50
Add a LANDMARK_
prefix to landmark constants
...
Resolves #697
2020-03-15 19:50:39 -04:00
Rangi
447da80615
Identify remaining gfx/unknown files
2020-02-28 09:23:41 -05:00
Rangi
75a537ed1e
Fix some comments and whitespace
2020-02-26 08:41:12 -05:00
Rangi
c3f389d615
Replace some "idiotic", "wtf", "stupid interns" comments with more common "useless", "pointless", "could have done X instead"
2020-02-23 18:51:32 -05:00
Rangi
2238f52197
Fix build with rgbds 0.3.9 release
2020-02-23 14:28:35 -05:00
mid-kid
813d0aa73a
Fix the sections in home/header.asm
...
They're fixed anyway, and this allows us to make some expressions
constant.
2020-02-23 20:11:54 +01:00
mid-kid
c0b6e5bc21
JoypadInt -> Joypad
...
This matches all other interrupts. The old Joypad was renamed to
UpdateJoypad.
2020-02-23 14:33:53 +01:00
mid-kid
44128c5d98
Create home/header.asm
...
Contains what was previously in:
- home/rst.asm
- home/interrupts.asm
- home.asm
All of this should be in a static location in the ROM so it kinda makes
sense together.
2020-02-23 14:28:21 +01:00
mid-kid
7bd8d56ff9
Implement suggestions in PR #687
...
Merge mon_stats.asm, cry.asm, print_level.asm, and mon_data.asm into pokemon.asm
Merge mon_party.asm into battle.asm
Merge menu.asm, menu_window.asm, and menu2.asm into menu.asm
2020-02-22 12:52:13 +01:00
mid-kid
43eff93861
Small home/ reorganization
...
Time to move everything out of home.asm:
- InexplicablyEmptyFunction was moved to home/map.asm
- The wDebugFlags functions and xor_a brothers were moved to
home/flag.asm because they're all flag-related.
- ret_2f3e was moved into home/region.asm
- The register alias sisters were moved to a new file called home/call_regs.asm
- IsInArray and SkipNames were joined by AddNTimes from home/math.asm
into home/array.asm, as they're all used to index arrays.
- CallPointerAt was moved into home/print_text.asm because given the
contents of that file it doesn't feel very out of place (that file
isn't very aptly named...)
- CountSetBits was moved into home/pokedex_flags.asm because it's unique
use is counting the amount of seen/caught mon in the podedex. GetWeekday
was pulled into this by proximity.
Other changes were also made:
- PushLYOverrides was moved from home/sprite_anims.asm to
home/battle.asm, because it's almost exclusively used for battle
animations, with the lone exception being the Magnet Train.
- home/copy.asm was renamed to home/gfx.asm, as it's all gfx-related
- home/copy2.asm was renamed to home/copy.asm, now it's the only file
called copy.
- SetHPPal and GetHPPal were moved from home/hp_pals.asm to
home/tilemap.asm, as they're attrmap related, like many functions in
that file are.
- home/rtc.asm was renamed to home/time_palettes.asm, as it had very
little to do with the RTC at all, all RTC functions being in home/time.asm
- home/handshake.asm was renamed to home/printer.asm.
- home/mon_data_2.asm was renamed to home/mon_party.asm.
2020-02-22 00:23:47 +01:00
mid-kid
9a927c1b3e
Merge pull request #685 from mid-kid/master
...
Moshi moshi? minoru enhansumentsu desu
2020-02-21 21:11:36 +01:00
mid-kid
345b585a78
Document GetTMHMName locals
...
This was documented in pokegold apparently
2020-02-21 21:10:43 +01:00
mid-kid
c22e268083
RTC -> UpdateTimeAndPals
...
Rename clear misnomer.
Most of the related functions in that file aren't really aptly named but
I don't know good names right now.
2020-02-21 18:21:29 +01:00
mid-kid
75a6bb5df6
PanicResetClock -> ClearClock
...
Funky name that only exists based on what it's used for, not so much
what it is.
2020-02-16 12:20:20 +01:00
Rangi
88bbdb6a2f
Define TileCollisionTable as a standard 'db' series
2020-02-13 19:07:19 -05:00
mid-kid
26b8bf003e
Standardize on lowercase Tilemap and Attrmap
...
We used to have a mixture of TileMap and and Tilemap, as well as the
similar AttrMap. Standardize on one.
2020-02-13 18:31:10 +01:00
mid-kid
34ceaac71d
Call_LoadTempTileMapToTileMap → SafeLoadTempTileMapToTileMap
...
Stupid name is stupid smh tbh fam.
2020-02-13 18:31:10 +01:00
mid-kid
a241f049df
Remove FarCall prefix from SwapTextboxPalettes and ScrollBGMapPalettes
...
No prefix for the farcall, prefix with an underscore for the farcalled.
This matches what is done for pretty much every other home function.
2020-02-13 18:31:10 +01:00
mid-kid
0d81f1c470
InitSpriteAnimStruct <-> _InitSpriteAnimStruct
...
These were the wrong way around, as the function in home should not be
prefixed
2020-02-13 18:31:10 +01:00
Rangi
fb9cbe7d1e
Merge pull request #650 from pret/audio-macros
...
Update audio macros and arguments
2020-02-05 18:51:20 -05:00
Rangi
d482dc28f4
Identify four padding bytes in base data as beta front/back pic pointers
2020-02-04 11:07:16 -05:00
Rangi
b1c8548628
Clean up comments in home/time.asm
2020-01-31 20:59:48 -05:00
dannye
e7be25948d
Merge branch 'master' into audio-macros
2020-01-06 22:07:33 -06:00
Rangi
94ebdab6d3
Merge pull request #660 from mid-kid/master
...
Make the map setup commands match the actual function names better
2020-01-04 20:08:43 -05:00
Rangi
fa7261a8ee
Update some labels
2019-12-03 09:17:21 -05:00
Rangi
0e311ad709
Fix miscellaneous points made in #658
2019-11-23 20:56:22 -05:00
Rangi
ef48ae98b5
Separate tilesets.o goes with pics.o and sprites.o
2019-11-23 20:43:33 -05:00
mid-kid
739a60b33c
Make the map setup commands match the actual function names better
...
These functions used as map setup commands are used in other places,
too, so I can't prefix them under the same. The names should match
except I won't repeat "map" in a map setup command name.
2019-11-18 18:21:57 +01:00
mid-kid
77803f571f
Fix some constants around wLinkMode
2019-11-18 18:21:57 +01:00
mid-kid
176257ea6f
Document WaitPressAorB_BlinkCursor a bit
...
This is one weird function I'll never understand the purpose of.
It could use a better name, but I have no clue what.
2019-11-18 18:21:57 +01:00
Rangi
4d32035d4f
Bit 6 of PrintNum left-aligns numbers
2019-11-03 20:17:04 -05:00
Rangi
69ea875eeb
Split menu code out of home/movement.asm
2019-11-03 14:46:36 -05:00
Rangi
4aeab6b879
Rename buttonsound to promptbutton
2019-11-03 12:48:54 -05:00
Rangi
5134266b9a
Rename OBJECT_LENGTH to MAPOBJECT_LENGTH and OBJECT_STRUCT_LENGTH to OBJECT_LENGTH
2019-11-03 12:26:38 -05:00
mid-kid
7111ae8e58
Fix some mobile script and map sign things
2019-10-21 00:42:36 +02:00
mid-kid
e3e0bcd653
#641 fixes and additions. ( #646 )
...
Name a lot of text labels according to our conventions
2019-10-20 18:24:17 -04:00
dannye
fc051f2130
Update audio macros and arguments
...
and update related labels/constants/comments
this fixes a lot of mistakes and maximizes compatibility with red
2019-09-02 03:41:25 -05:00
mid-kid
c7fdf5f9ec
Fix overworld scrolling function names
2019-06-09 00:17:35 +02:00
mid-kid
b6277408a0
Misc fixes
2019-06-04 13:31:22 +02:00