Rangi
94057c7726
Verify uneven list sizes with list_start, li, and assert_list_length macros
...
This was discussed in #815
2021-03-22 17:17:08 -04:00
Rangi
dbe2360ecd
Miscellaneous cleanup
2021-03-22 16:41:17 -04:00
Rangi
4522162d45
Consistent labels for each nickname in RAM
2021-03-17 16:38:21 -04:00
Rangi
6c8f8609cb
Assert some more table widths
2021-03-17 11:38:01 -04:00
Rangi
3684296583
Revise some constant definitions
2021-03-16 18:06:18 -04:00
Rangi
dbabd8b4a9
Define MAPGROUP_* constants and verify MapGroup_* table sizes
2021-03-10 21:16:54 -05:00
Rangi
ef20126fe5
Verify wild data sizes with def_grass/water_wildmons and end_grass/water_wildmons macros
2021-03-04 17:58:30 -05:00
Rangi
40902ffe24
Verify data table sizes with table_width and assert_table_length macros
...
This was discussed in #706
It also uncovered some off-by-one issues with defining some constants.
A few structs now use rsreset/_RS to define their offset constants, as discussed in #739
2021-03-04 00:15:03 -05:00
Rangi
a539578006
Merge pull request #798 from CelestialAmber/master
...
Fix typo
2021-02-05 09:45:18 -08:00
Rangi
4264d53eb6
Identify some more labels
2021-02-05 12:44:21 -05:00
Amber Brault
b391b6cef0
Fix typo
2021-01-21 11:01:53 -05:00
Rangi
f773fd1dd8
The 'tmhm' macro adjusts to the number of TMs/HMs/tutors
2021-01-06 10:20:19 -05:00
Rangi
99e66c2557
Rename some labels
...
- Remove "Buffer" suffix from some byte and word quantities
- Change "Ptr" to "Pointer"
Fixes #789
2020-12-23 16:29:30 -05:00
Rangi
fff343349d
Clarify signed magnitude in the growth_rate macro
2020-12-20 23:35:22 -05:00
Rangi
145e752266
Use assert to ensure correct base data size
2020-11-17 16:14:45 -05:00
Rangi
97e981985b
Correct some filename comments
2020-11-17 11:12:21 -05:00
Rangi
9b3c45b14d
Resolve some "???" comments
2020-11-17 11:09:02 -05:00
Rangi
62b756c46e
Rename "dummy game" to "memory game"
2020-11-08 19:32:57 -05:00
Rangi
826e070f04
More syncing with pokegold
2020-11-03 10:13:06 -05:00
Rangi
6220200f0f
Identify some more labels, and make some more consistent
2020-11-01 12:36:38 -05:00
Rangi
4a323cf591
UnusedSpriteAnimGFX was to sprite anims as AnimObjGFX is to battle anims
2020-10-30 17:41:03 -04:00
Rangi
fe1a58deea
Identify wSpriteAnimDict key constants
2020-10-30 15:39:08 -04:00
Rangi
1237156948
Identify mobile Name Card exchange labels
2020-10-30 10:45:31 -04:00
Rangi
ba5bc304f9
Updates to more closely sync with pokegold
2020-10-29 23:23:57 -04:00
Rangi
bcc0d633e9
Identify the remaining (non-mobile) uses of another WRAM union
2020-10-29 14:51:41 -04:00
Rangi
ea426a8879
Identify more WRAM labels, and start a <X>_DummyFunction label convention
2020-10-28 14:34:38 -04:00
Rangi
6d333bed5f
Replace many '; unused' with '; unreferenced'
2020-10-28 10:21:10 -04:00
Rangi
2738858985
Create data/collision/ for tile collision-related data
2020-10-27 10:00:56 -04:00
Rangi
9dcdad5e60
Comment, remove, or revise many unreferenced labels
2020-10-26 20:29:58 -04:00
Rangi
7991db972b
Identify some more link.asm labels (syncing to pokegold)
2020-10-23 13:36:54 -04:00
Rangi
d8310c166d
Identify some more map object labels and constants
2020-10-22 17:41:48 -04:00
Rangi
ae4fe08084
Identify some more labels (a few link-related)
2020-10-22 00:53:54 -04:00
7Soul
cf26f55985
Identify battle bg effects functions and constants ( #773 )
...
Identify battle bg effects functions and constants
2020-10-06 15:45:09 -04:00
7Soul
836da09f4e
Identify anim object constants ( #772 )
...
Identify anim object constants
2020-10-04 15:06:38 -04:00
7Soul
2ffc5f907f
Identify battle animation functions ( #771 )
...
Identify battle animation functions
2020-10-03 21:54:02 -04:00
mid-kid
353f78f493
GS_INTRO_STAR/SPARKLE -> GS_GAMEFREAK_LOGO_STAR/SPARKLE
...
These two sprite animations are related to the Game Freak Logo splash
screen, not the actual intro.
2020-08-27 15:13:41 +02:00
Rangi
7729dcd204
Consistent constants for radio data table sizes (could still be better)
2020-08-13 13:47:50 -04:00
Rangi
dd369f3199
Move EngineFlags and SpecialsPointers into data/engine/
2020-07-22 20:24:53 -04:00
Rangi
11dc805de0
Revert "Factor out tables into data/overworld/"
...
This reverts commit b5a7e7de3e
.
2020-07-22 20:21:26 -04:00
Rangi
b5a7e7de3e
Factor out tables into data/overworld/
...
Fixes #749
2020-07-22 15:22:58 -04:00
Rangi
212846af57
Treat map setup commands like trade script commands
...
Fixes #736
2020-07-22 13:37:43 -04:00
Rangi
a9941e28cc
Define NUM_FLYPOINTS
2020-07-21 11:48:39 -04:00
Rangi
59d9932255
SPRITE_GYM_GUY -> SPRITE_GYM_GUIDE
2020-07-17 13:01:48 -04:00
Rangi
eca33ef190
Define map setup commands as macros like other script commands
2020-07-13 20:44:16 -04:00
Rangi
6ca82e5c86
Eliminate enum: use const instead, with case-by-case parallel const implementations
2020-07-08 15:30:23 -04:00
Rangi
43a9295789
add_tm, add_hm, and add_mt define TM##_MOVE, HM##_MOVE, and MT##_MOVE constants, to avoid repeating the move names in tmhm_moves.asm
2020-07-06 16:53:05 -04:00
Rangi
26d764de5d
Use STRCMP, not ==, to compare multi-character strings
2020-07-02 11:46:30 -04:00
Rangi
fce6243b43
Identify more labels, and use the jumptable macro when possible
2020-07-01 13:13:49 -04:00
Rangi
c3c18dd196
Comment more ROM labels as unreferenced
...
(Some unreferenced labels are above code which is still used via fallthrough!)
2020-06-21 18:33:31 -04:00
Rangi
91774f206e
Replace "Unreferenced" labels with "; unreferenced" comments
2020-06-21 16:27:43 -04:00