mid-kid
26b8bf003e
Standardize on lowercase Tilemap and Attrmap
...
We used to have a mixture of TileMap and and Tilemap, as well as the
similar AttrMap. Standardize on one.
2020-02-13 18:31:10 +01:00
mid-kid
34ceaac71d
Call_LoadTempTileMapToTileMap → SafeLoadTempTileMapToTileMap
...
Stupid name is stupid smh tbh fam.
2020-02-13 18:31:10 +01:00
mid-kid
a241f049df
Remove FarCall prefix from SwapTextboxPalettes and ScrollBGMapPalettes
...
No prefix for the farcall, prefix with an underscore for the farcalled.
This matches what is done for pretty much every other home function.
2020-02-13 18:31:10 +01:00
mid-kid
0d81f1c470
InitSpriteAnimStruct <-> _InitSpriteAnimStruct
...
These were the wrong way around, as the function in home should not be
prefixed
2020-02-13 18:31:10 +01:00
Rangi
fb9cbe7d1e
Merge pull request #650 from pret/audio-macros
...
Update audio macros and arguments
2020-02-05 18:51:20 -05:00
Rangi
d482dc28f4
Identify four padding bytes in base data as beta front/back pic pointers
2020-02-04 11:07:16 -05:00
Rangi
b1c8548628
Clean up comments in home/time.asm
2020-01-31 20:59:48 -05:00
dannye
e7be25948d
Merge branch 'master' into audio-macros
2020-01-06 22:07:33 -06:00
Rangi
94ebdab6d3
Merge pull request #660 from mid-kid/master
...
Make the map setup commands match the actual function names better
2020-01-04 20:08:43 -05:00
Rangi
fa7261a8ee
Update some labels
2019-12-03 09:17:21 -05:00
Rangi
0e311ad709
Fix miscellaneous points made in #658
2019-11-23 20:56:22 -05:00
Rangi
ef48ae98b5
Separate tilesets.o goes with pics.o and sprites.o
2019-11-23 20:43:33 -05:00
mid-kid
739a60b33c
Make the map setup commands match the actual function names better
...
These functions used as map setup commands are used in other places,
too, so I can't prefix them under the same. The names should match
except I won't repeat "map" in a map setup command name.
2019-11-18 18:21:57 +01:00
mid-kid
77803f571f
Fix some constants around wLinkMode
2019-11-18 18:21:57 +01:00
mid-kid
176257ea6f
Document WaitPressAorB_BlinkCursor a bit
...
This is one weird function I'll never understand the purpose of.
It could use a better name, but I have no clue what.
2019-11-18 18:21:57 +01:00
Rangi
4d32035d4f
Bit 6 of PrintNum left-aligns numbers
2019-11-03 20:17:04 -05:00
Rangi
69ea875eeb
Split menu code out of home/movement.asm
2019-11-03 14:46:36 -05:00
Rangi
4aeab6b879
Rename buttonsound to promptbutton
2019-11-03 12:48:54 -05:00
Rangi
5134266b9a
Rename OBJECT_LENGTH to MAPOBJECT_LENGTH and OBJECT_STRUCT_LENGTH to OBJECT_LENGTH
2019-11-03 12:26:38 -05:00
mid-kid
7111ae8e58
Fix some mobile script and map sign things
2019-10-21 00:42:36 +02:00
mid-kid
e3e0bcd653
#641 fixes and additions. ( #646 )
...
Name a lot of text labels according to our conventions
2019-10-20 18:24:17 -04:00
dannye
fc051f2130
Update audio macros and arguments
...
and update related labels/constants/comments
this fixes a lot of mistakes and maximizes compatibility with red
2019-09-02 03:41:25 -05:00
mid-kid
c7fdf5f9ec
Fix overworld scrolling function names
2019-06-09 00:17:35 +02:00
mid-kid
b6277408a0
Misc fixes
2019-06-04 13:31:22 +02:00
mid-kid
13cfe356d6
Fix usage of rIE and rSC constants
2019-05-25 17:59:50 +02:00
Rangi
45e3f6aca9
Identify some more WRAM labels
2019-04-19 11:35:27 -04:00
mid-kid
3e78e5b2b6
TextBox -> Textbox
...
Homogenizing names.
2019-04-09 16:09:18 +02:00
Rangi
2184b60a0c
Identify and eliminate wEngineBuffer1-5
2019-04-08 19:42:55 -04:00
Rangi
79dc22c769
Define constants for map event sizes
2019-03-03 14:19:16 -05:00
Rangi
dc396822d7
Identify more collision-related constants and data
2019-03-03 13:30:27 -05:00
Rangi
df337fc417
Update to rgbds 0.3.8
2019-02-16 12:17:55 -05:00
Rangi
60cdc65293
wc7e8 -> wUnusedC7E8 (similar to wUnusedD102)
2019-01-30 19:46:45 -05:00
Rangi
84b6a084cb
Keep "paragraphs" of related code together
2019-01-24 21:10:45 -05:00
Rangi
1853e3d127
Say "BANK(Foo) ; aka BANK(Bar)" to clarify that Foo and Bar share a bank
2019-01-12 15:17:20 -05:00
mid-kid
930d285fab
Fix comments around BANK() statements
...
Found a couple BANK()s that reference multiple labels.
2018-12-26 21:58:13 +01:00
Rangi
e025ab9db0
Merge pull request #578 from mid-kid/master
...
Fixes in the animation subsystem.
2018-12-09 17:44:09 -05:00
mid-kid
4e3ed078f9
Cosmetic fixes
2018-11-20 21:53:45 +01:00
Rangi
3202c4f3df
Resolve issue #575 : Rename text commands
2018-11-18 12:41:11 -05:00
mid-kid
940256569b
text_jump → text_far
...
The previous name for this was rather misleading. It isn't an actual
jump like you'd expect the `jp` instruction to behave as. Instead, it
behaves more like a `farcall`.
This also makes it consistent with its current command ID name of
`TX_FAR`.
2018-11-05 22:26:18 +01:00
mid-kid
f52f20edb7
Rename CheckTrainerBattle
...
Renamed to be more in line with our current coding standards. Hopefully
this is slightly more readable.
2018-10-11 11:39:09 +02:00
Rangi
3241c9cfaa
Use 0/1/2/3 for palettes, and rgbds opt feature for battle transition graphic
2018-09-09 18:15:54 -04:00
Rangi
bb4a6e5f55
wCursorCurTile -> wCursorCurrentTile
2018-09-09 17:15:49 -04:00
Rangi
14a2ea835e
Remove redundant comments
2018-09-09 15:15:33 -04:00
Rangi
ae022e1420
Curr -> Cur
2018-09-09 15:09:51 -04:00
Rangi
1c0fff7668
hLabel - $ff00 -> LOW(hLabel)
2018-08-25 14:34:25 -04:00
Rangi
eb1e3636bb
Use labels instead of constants for HRAM
...
Use explicit ldh instruction to access HRAM locations, don't rely on optimizing ld
2018-08-25 14:28:22 -04:00
Rangi
b5a9e83a94
Fix reviewed issues.
...
Pokedex_PrintListing has a comment noting how it depends on wCurSpecies == wNamedObjectIndexBuffer; an assert would be more convenient, but is not possible since WRAM label addresses are not defined yet here.
2018-07-29 16:00:11 -04:00
Rangi
c9cb67141b
Make reviewed fixes; standardize on " + "
2018-07-29 01:40:23 -04:00
Rangi
9dec80b07e
Add meaningful aliases for wd265
...
Introduce MONICON_* constants
Introduce BATTLEPLAYERACTION_* constants
2018-07-29 00:25:52 -04:00
Rangi
4f0c9cecf9
StringCmp → CompareBytes; CompareLong → CompareBytesLong
...
hStringCmpString[1/2] → h[EnemyMon/PartyMon1]Speed
2018-07-23 00:25:53 -04:00
