Rangi
6220200f0f
Identify some more labels, and make some more consistent
2020-11-01 12:36:38 -05:00
Rangi
4a323cf591
UnusedSpriteAnimGFX was to sprite anims as AnimObjGFX is to battle anims
2020-10-30 17:41:03 -04:00
Rangi
fe1a58deea
Identify wSpriteAnimDict key constants
2020-10-30 15:39:08 -04:00
Rangi
1237156948
Identify mobile Name Card exchange labels
2020-10-30 10:45:31 -04:00
Rangi
ba5bc304f9
Updates to more closely sync with pokegold
2020-10-29 23:23:57 -04:00
Rangi
bcc0d633e9
Identify the remaining (non-mobile) uses of another WRAM union
2020-10-29 14:51:41 -04:00
Rangi
ea426a8879
Identify more WRAM labels, and start a <X>_DummyFunction label convention
2020-10-28 14:34:38 -04:00
Rangi
6d333bed5f
Replace many '; unused' with '; unreferenced'
2020-10-28 10:21:10 -04:00
Rangi
2738858985
Create data/collision/ for tile collision-related data
2020-10-27 10:00:56 -04:00
Rangi
9dcdad5e60
Comment, remove, or revise many unreferenced labels
2020-10-26 20:29:58 -04:00
Rangi
7991db972b
Identify some more link.asm labels (syncing to pokegold)
2020-10-23 13:36:54 -04:00
Rangi
d8310c166d
Identify some more map object labels and constants
2020-10-22 17:41:48 -04:00
Rangi
ae4fe08084
Identify some more labels (a few link-related)
2020-10-22 00:53:54 -04:00
7Soul
cf26f55985
Identify battle bg effects functions and constants ( #773 )
...
Identify battle bg effects functions and constants
2020-10-06 15:45:09 -04:00
7Soul
836da09f4e
Identify anim object constants ( #772 )
...
Identify anim object constants
2020-10-04 15:06:38 -04:00
7Soul
2ffc5f907f
Identify battle animation functions ( #771 )
...
Identify battle animation functions
2020-10-03 21:54:02 -04:00
mid-kid
353f78f493
GS_INTRO_STAR/SPARKLE -> GS_GAMEFREAK_LOGO_STAR/SPARKLE
...
These two sprite animations are related to the Game Freak Logo splash
screen, not the actual intro.
2020-08-27 15:13:41 +02:00
Rangi
7729dcd204
Consistent constants for radio data table sizes (could still be better)
2020-08-13 13:47:50 -04:00
Rangi
dd369f3199
Move EngineFlags and SpecialsPointers into data/engine/
2020-07-22 20:24:53 -04:00
Rangi
11dc805de0
Revert "Factor out tables into data/overworld/"
...
This reverts commit b5a7e7de3e
2020-07-22 20:21:26 -04:00
Rangi
b5a7e7de3e
Factor out tables into data/overworld/
...
Fixes #749
2020-07-22 15:22:58 -04:00
Rangi
212846af57
Treat map setup commands like trade script commands
...
Fixes #736
2020-07-22 13:37:43 -04:00
Rangi
a9941e28cc
Define NUM_FLYPOINTS
2020-07-21 11:48:39 -04:00
Rangi
59d9932255
SPRITE_GYM_GUY -> SPRITE_GYM_GUIDE
2020-07-17 13:01:48 -04:00
Rangi
eca33ef190
Define map setup commands as macros like other script commands
2020-07-13 20:44:16 -04:00
Rangi
6ca82e5c86
Eliminate enum: use const instead, with case-by-case parallel const implementations
2020-07-08 15:30:23 -04:00
Rangi
43a9295789
add_tm, add_hm, and add_mt define TM##_MOVE, HM##_MOVE, and MT##_MOVE constants, to avoid repeating the move names in tmhm_moves.asm
2020-07-06 16:53:05 -04:00
Rangi
26d764de5d
Use STRCMP, not ==, to compare multi-character strings
2020-07-02 11:46:30 -04:00
Rangi
fce6243b43
Identify more labels, and use the jumptable macro when possible
2020-07-01 13:13:49 -04:00
Rangi
c3c18dd196
Comment more ROM labels as unreferenced
...
(Some unreferenced labels are above code which is still used via fallthrough!)
2020-06-21 18:33:31 -04:00
Rangi
91774f206e
Replace "Unreferenced" labels with "; unreferenced" comments
2020-06-21 16:27:43 -04:00
Rangi
ac0025064f
Identify some more Unknown labels
2020-06-20 18:52:26 -04:00
Rangi
f2550fc3c2
ReplaceKrisSprite -> UpdatePlayerSprite
2020-06-16 19:38:00 -04:00
Rangi
7b2515d1e4
[in progress] Harmonize more constant and data files with pokegold
2020-06-16 14:32:57 -04:00
Rangi
b9f2b93c17
Harmonize some more symbols with pokegold
2020-06-16 11:28:52 -04:00
Rangi
75035a71a5
Label some mobile addresses, and revise some comments
2020-06-13 18:48:26 -04:00
Rangi
518cee440e
Resolve #723 : treat std scripts like specials and predefs
2020-06-10 16:44:16 -04:00
Rangi
60f7ca4006
Group MoveDescriptions with PrintMoveDesc and rename that to PrintMoveDescription (like ItemDescriptions with PrintItemDescription)
2020-05-25 03:54:42 -04:00
Rangi
5f197c53f4
Clean up some percentage values
2020-05-07 14:21:24 -04:00
Rangi
905833ef8c
Use a FIRST_UNOWN_CHAR constant for the Unown font
2020-05-06 10:34:51 -04:00
Rangi
b69526a908
Miscellaneous fixes
...
Addresses the haircut brothers' probability comments in #709
2020-05-05 10:17:02 -04:00
Rangi
20464d1bfb
Miscellaneous updates
...
- `PREDEFPAL_00` -> `PREDEFPAL_ROUTES` (observed from `LoadSGBLayout.GetMapPalsIndex.route`)
- `$0` -> `PLAYER` (standard person ID)
- Fix some whitespace formatting
2020-04-30 11:27:32 -04:00
Rangi
0ef004a4db
dsprite y, ypx, x, xpx, off, attr -> dbsprite x, y, xpx, ypx, off, attr
2020-04-04 16:00:30 -04:00
Andrew Cook
5d97f15f80
Assorted labels in mobile related code ( #702 )
...
Rename assorted labels in mobile-related code
2020-03-31 21:26:59 -04:00
Rangi
0345e4fb0e
Add suffixes to some constants to avoid ambiguity
...
- `PSYCHIC` → `PSYCHIC_TYPE` (not the trainer `PSYCHIC_T` or the move `PSYCHIC_M`)
- `BLACKBELT` → `BLACKBELT_I` (not the trainer `BLACKBELT_T`)
- `CURSE_T` → `CURSE_TYPE` (not the move `CURSE`)
- `TOWN_MAP_D` → `TOWN_MAP_POSTER` (not the item `TOWN_MAP`)
This also uncovered a misidentified event: `EVENT_DECO_PLANT_4` → `EVENT_DECO_POSTER_1`. (There are three plants and four posters.)
2020-03-21 17:59:26 -04:00
Rangi
6a6ba10315
rgbds supports 'X - 1' instead of 'X + -1'
2020-03-21 14:01:05 -04:00
Rangi
5a5f5ececd
Miscellaneous fixes from #694
2020-03-21 13:07:18 -04:00
Rangi
ad50e94b50
Add a LANDMARK_ prefix to landmark constants
...
Resolves #697
2020-03-15 19:50:39 -04:00
Rangi
65f22544e0
Refactor flypoints to separate const definition from data usage
2020-03-15 14:10:53 -04:00
Rangi
a73ced3b69
unused_dark_cave -> unused_johto (goes with the beta Johto town+city maps)
2020-02-25 19:18:24 -05:00
