mirror of
https://gitlab.winehq.org/wine/vkd3d.git
synced 2024-11-21 16:46:41 -08:00
c43e5c8eb5
Currently, if an expression successfully parses according to the bison grammar, but for one reason or another cannot generate a meaningful IR instruction, we abort parsing with YYABORT. This includes, for example, an undefined variable or function, invalid swizzle or field reference, or a constructor with a complex or non-numeric data type. Aborting parsing is unfortunate, however, because it means that any further errors in the program cannot be caught by the programmer, increasing the number of times they will need to fix errors and recompile. The idea of this patch is that any such expression will instead generate an IR node whose data type is of HLSL_CLASS_ERROR. Any further expression which would consume an "error" typed instruction will instead immediately return an expression of type "error" (probably the same one) instead of aborting or doing any other type-checking. Currently these "error" instructions should not pass the parsing stage, since hlsl_compile_shader() will immediately notice that compilation has failed and skip any optimization, lowering, or bytecode-writing. A further direction to take this is to pre-allocate one "error" expression immediately when creating the HLSL parser, and return that expression when we fail to allocate an hlsl_ir_node of any type. This means we do not need to handle allocation errors when constructing nodes, saving us quite a lot of error handling (which is not only tedious but currently often broken, if nothing else by virtue of neglecting cleanup of local variables). |
||
|---|---|---|
| .. | ||
| checksum.c | ||
| d3d_asm.c | ||
| d3dbc.c | ||
| dxbc.c | ||
| dxil.c | ||
| fx.c | ||
| glsl.c | ||
| hlsl_codegen.c | ||
| hlsl_constant_ops.c | ||
| hlsl.c | ||
| hlsl.h | ||
| hlsl.l | ||
| hlsl.y | ||
| ir.c | ||
| libvkd3d-shader.pc.in | ||
| msl.c | ||
| preproc.h | ||
| preproc.l | ||
| preproc.y | ||
| spirv.c | ||
| tpf.c | ||
| vkd3d_shader_main.c | ||
| vkd3d_shader_private.h | ||
| vkd3d_shader.map | ||