mirror of
https://gitlab.winehq.org/wine/vkd3d.git
synced 2024-11-21 16:46:41 -08:00
5b7191280b
After compiling and linking with '-fsanitize=undefined' the following
error pops up in many tests:
vkd3d_shader_main.c:2024:12: runtime error: member access within null pointer of type 'struct vkd3d_shader_param_node'
This happens in the scenario where shader_param_allocator_get() gets
called with 'count = 0' but no allocation has been made yet, so
allocator->current is NULL.
In this case the result of the function, given by:
params = &allocator->current->param[allocator->index * allocator->stride];
is an invalid non-NULL pointer.
Functions like shader_sm4_read_instruction() may call
vsir_program_get_src_params() or vsir_program_get_dst_params() with 0
counts for various DCL_ instructions, as well as things like NOP,
ELSE, and SYNC.
We could avoid calling the functions in question with 0 counts, but it
doesn't seem worth the effort.
Alternatively, we could just return NULL on 'count == 0', but this is
also complicated because NULL is interpreted as a memory allocation
failure on the callers.
So we force allocation of the next node even if 'count = 0' when
allocator->current is NULL.
|
||
|---|---|---|
| .. | ||
| checksum.c | ||
| d3d_asm.c | ||
| d3dbc.c | ||
| dxbc.c | ||
| dxil.c | ||
| fx.c | ||
| glsl.c | ||
| hlsl_codegen.c | ||
| hlsl_constant_ops.c | ||
| hlsl.c | ||
| hlsl.h | ||
| hlsl.l | ||
| hlsl.y | ||
| ir.c | ||
| libvkd3d-shader.pc.in | ||
| preproc.h | ||
| preproc.l | ||
| preproc.y | ||
| spirv.c | ||
| tpf.c | ||
| vkd3d_shader_main.c | ||
| vkd3d_shader_private.h | ||
| vkd3d_shader.map | ||