Commit Graph

4679 Commits

Author SHA1 Message Date
bbbbbbbbba
0d48d829d4 Document Special Defense badge boost glitch (#651)
Document Special Defense badge boost glitch
2019-10-20 18:25:34 -04:00
mid-kid
e3e0bcd653 #641 fixes and additions. (#646)
Name a lot of text labels according to our conventions
2019-10-20 18:24:17 -04:00
Ryan Tandy
3fc2ba41f7 Clarify naming of SFX_GET_EGG_* pointers
In game, one receives eggs from the Aide and the Day-care Man, not the
Day-care Lady. SFX `0x96` is used for both. Rename it to reflect it is
not unique to the Day-care.

SFX `0x95` is an alias of the same sound and appears to be unused.
Rename the pointer to clarify that.
2019-09-23 10:03:19 -07:00
dannye
331ed51264 stereo_panning: force any non-zero arg to 1 2019-09-08 12:09:43 -05:00
dannye
5645e1e213 Remove excessive newline from ends of sound files 2019-09-08 11:57:55 -05:00
dannye
9d4dd09b86 Add legacy audio macros 2019-09-04 00:17:10 -05:00
dannye
5fd3e591df Use TRUE/FALSE constants for stereo_panning
and use dn instead of db for volume envelope and pitch sweep
2019-09-03 22:55:51 -05:00
dannye
e058393487 Rename dnote to drum_note and dspeed to drum_speed 2019-09-03 22:36:32 -05:00
dannye
fc051f2130 Update audio macros and arguments
and update related labels/constants/comments
this fixes a lot of mistakes and maximizes compatibility with red
2019-09-02 03:41:25 -05:00
Ryan Tandy
abee217ce0 Fix swapped comments in data/trainers/dvs.asm
Bugsy has trainer class id 3 and his DVs are 9/8/8/8.
Whitney has trainer class id 2 and her DVs are 8/8/8/8.
2019-08-27 16:23:27 -07:00
IIMarckus
9ddbaacea8 GlassTing (Elm's PC when email arrives) isn't in G/S either. 2019-08-16 01:09:32 -06:00
Rangi
3e056a6862 Store a mobile tilemap+tilemap in its own files 2019-08-11 22:20:26 -04:00
Rangi
6962d843a3 Store Magnet Train tilemaps in their own files 2019-08-11 18:48:26 -04:00
Rangi
01618d3cc4 Define constants for both battle transition tiles 2019-06-30 14:20:25 -04:00
Rangi
f1bab45624
Merge pull request #638 from mid-kid/master
beep boop
2019-06-17 07:29:30 -04:00
mid-kid
7e84f72403 end -> return in clair bugfix 2019-06-17 08:05:29 +02:00
mid-kid
ad299b1635 Apply suggested changes 2019-06-10 01:52:46 +02:00
mid-kid
d6db010429 Document high nybble of PrintNum c register 2019-06-09 17:46:06 +02:00
mid-kid
c048b24d25 Create constants for ScrollingMenu item formats
...I should've done this quite a while ago.
2019-06-09 02:31:24 +02:00
mid-kid
6b37353406 Properly disassemble MenuData_0x4851b 2019-06-09 00:24:40 +02:00
mid-kid
54b87ecea8 Document in-battle move selection menu scrolling glitch
What a mouthful...
2019-06-09 00:17:35 +02:00
mid-kid
c7fdf5f9ec Fix overworld scrolling function names 2019-06-09 00:17:35 +02:00
mid-kid
7b47aeaf79 Redump slots_1.png with 16 as width. 2019-06-09 00:17:05 +02:00
mid-kid
b6277408a0 Misc fixes 2019-06-04 13:31:22 +02:00
mid-kid
309079524b Fix menu_coords for pokecenter pc 2019-06-04 13:11:29 +02:00
Rangi
fbc2c55cdb Dark theme colors for @media (prefers-color-scheme: dark) 2019-05-26 11:54:13 -04:00
Rangi
e8ddecd0eb
Merge pull request #636 from mid-kid/patch
Small cleanups
2019-05-25 13:54:29 -04:00
mid-kid
476f9ba40d Define appropriate constants as EQU
These constants are defined only once and shouldn't be redefined anyway.
2019-05-25 17:59:50 +02:00
mid-kid
649c8d38da Get rid of _CRYSTAL
Having this here is completely redundant and useless, and doesn't even
work since it should use `if DEF(_CRYSTAL)` instead.
2019-05-25 17:59:50 +02:00
mid-kid
13cfe356d6 Fix usage of rIE and rSC constants 2019-05-25 17:59:50 +02:00
mid-kid
40766b9a76 Magnet train fixes
Should make the code slightly easier to read, at least
2019-05-25 17:59:50 +02:00
Rangi
b24cd55f96 Correct the older+younger haircut brothers' labels and constants 2019-05-18 13:27:32 -04:00
Rangi
7db6c59211
Merge pull request #628 from DeeDeeG/renaming-placeholder-labels
Renaming placeholder labels in maps folder
2019-05-18 13:01:42 -04:00
Rangi
7890fae995 Some more GB Printer documentation 2019-05-11 13:01:59 -04:00
Rangi
5248d18f58 Merge branch 'master' of https://github.com/pret/pokecrystal 2019-05-05 12:50:19 -04:00
Rangi
d695275d60
Merge pull request #632 from mid-kid/patch-2
Cygwin now requires a double-click
2019-05-05 12:49:22 -04:00
mid-kid
7def5e700b Cygwin now requires a double-click 2019-04-29 22:30:34 +02:00
DeeDeeG
80e89b5539 PokemonFanClub.asm: Update NPC names
Includes the following NPC constant renames:

POKEMONFANCLUB_PRESIDENT --> POKEMONFANCLUB_CHAIRMAN
POKEMONFANCLUB_FISHER --> POKEMONFANCLUB_CLEFAIRY_GUY

Also update the Clefairy doll and Bayleef text labels.
2019-04-28 01:31:58 -04:00
DeeDeeG
3d5467abc8 maps/PokemonFanClub.asm: Re-label UnknownText 2019-04-28 00:59:46 -04:00
DeeDeeG
51e6317164 SaffronMagnetTrainStation.asm: Re-label UnknownText, MovementData 2019-04-28 00:28:49 -04:00
DeeDeeG
099c01be3f GoldenrodPokecenter1F.asm: Re-label UnknownText, MovementData
Mostly gave non-placeholder labels for the unused GS Ball event.
Also did so for PokeFanF.

Left alone all the unused text about trading and news.
2019-04-28 00:02:37 -04:00
DeeDeeG
35d64c30d7 GoldenrodMagnetTrainStation.asm: Label UnknownText, MovementData 2019-04-27 22:52:32 -04:00
DeeDeeG
f1187dc860 GoldenrodCity.asm: label UnknownText, MovementData 2019-04-27 22:31:24 -04:00
DeeDeeG
82aea0f71e GoldenrodDeptStore5F.asm: Re-label UnknownText 2019-04-27 21:45:39 -04:00
DeeDeeG
318d042e6c Route35GoldenrodGate.asm: Rename an NPC
ROUTE35GOLDENRODGATE_OFFICER --> ROUTE35GOLDENRODGATE_RANDY
2019-04-27 21:45:32 -04:00
DeeDeeG
e47fbb22f2 Route35GoldenrodGate.asm: Re-label UnknownText 2019-04-27 21:44:24 -04:00
DeeDeeG
c6b19dfba2 GoldenrodFlowerShop.asm: Re-label UnknownText 2019-04-27 21:44:24 -04:00
DeeDeeG
f0cd72140a GoldenrodUnderground.asm: Rename some NPCs
GOLDENRODUNDERGROUND_SUPER_NERD5 --> GOLDENRODUNDERGROUND_OLDER_HAIRCUT_BROTHER
GOLDENRODUNDERGROUND_SUPER_NERD6 --> GOLDENRODUNDERGROUND_YOUNGER_HAIRCUT_BROTHER
2019-04-27 21:44:24 -04:00
DeeDeeG
a22d70f599 GoldenrodUnderground.asm: Re-label UnknownText 2019-04-27 21:44:24 -04:00
DeeDeeG
8758550960 PowerPlant.asm: Rename some NPCs
GymGuy3 --> Officer2
POWERPLANT_FISHER --> POWERPLANT_MANAGER
2019-04-27 21:44:24 -04:00