mid-kid
cfd432f468
Minor battle tower fixes
2023-03-08 13:52:47 +01:00
mid-kid
cf1c505555
GetNicknamenamePointer -> GetNicknamePointer
...
Found this commit on an old drive
2023-02-26 12:28:06 +01:00
vulcandth
c01409be5a
Relabel some map_object struct fields ( #1029 )
2023-01-03 22:16:08 -05:00
vulcandth
cb8505e022
Define InitDefaultEZChatMsgs and sEZChatMessages ( #1022 )
2022-12-26 13:55:01 -05:00
vulcandth
25e12c9391
wUnlockedUnowns engine_flag constants ( #1025 )
2022-12-26 13:14:10 -05:00
vulcandth
f739f8b1ac
Add table assert DoBattleAnimFrame.Jumptable
2022-12-23 18:48:14 -06:00
Rangi
4387298b2c
Comment the Crystal 1.0 bugs as "BUG:" too
2022-12-14 22:30:20 -05:00
vulcandth
b232b4be5f
Bug: PRZ and BRN stat reductions don't apply to switched Pokémon ( #1021 )
...
Co-authored-by: Rangi <35663410+Rangi42@users.noreply.github.com>
2022-12-01 16:54:01 -05:00
vulcandth
c4e3f2bbc2
TrainerWalkToPlayer should reference wSeenTrainerDistance (#1020 )
2022-11-22 21:03:24 -05:00
vulcandth
f7d26fbe9c
.CheckNPC label and comment correction
2022-11-07 20:27:09 -06:00
Idain
a95336d9e7
Fix Spelling Typos in engine/battle_anims/functions.asm
2022-10-16 23:16:12 -05:00
Rangi
ce004be92c
Revise constants in CheckShininess
2022-10-12 21:41:08 -04:00
Rangi
8e135931a6
Require rgbds 0.6.0
2022-10-02 22:03:53 -04:00
Idain
a9869f1896
Replace hardcoded wMonType constants ( #1011 )
2022-09-28 19:51:39 -05:00
Rangi
f7507b7782
$f -> BATTLEACTION_FORFEIT
...
(thanks, Vulcandth)
2022-09-23 23:10:24 -04:00
Andrew Cook
0f5540740b
Some Mobile code labeling and removed magic numbers ( #993 )
...
* Macro loop for EmptyAllSRAMBanks
* Many things labeled and magic numbers removed
* Conform to the style guide
* Rename URLs in mobile_46
* MOBILEAPI_19 -> MOBILEAPI_TELEPHONESTATUS
* Update engine/menus/empty_sram.asm
Co-authored-by: Rangi <35663410+Rangi42@users.noreply.github.com>
* Update ram/wram.asm
Co-authored-by: Rangi <35663410+Rangi42@users.noreply.github.com>
* Update mobile/mobile_46.asm
Co-authored-by: Rangi <35663410+Rangi42@users.noreply.github.com>
* Update mobile/mobile_46.asm
Co-authored-by: Rangi <35663410+Rangi42@users.noreply.github.com>
* Remove underscore from Set*DownloadURL symbols
* Begin Labeling TradeCornerHoldMon routines
* Add wMobileMon party_struct
* Add TRADE_CORNER_REQUEST_LENGTH constant
* Name battle tower action functions
* Label trade corner send/receive buffer
* Label the saved copy of the trade corner pokemon
also fix mailmsg_jp
* So many copies of decodeBase64Character
* Label another buffer
* Fix Alignment and use MOBILE_EMAIL_LENGTH
* `Function11ad8a` -> `MobileIncJumptableIndex`
* Apply Rangi Suggestions pass 1
Co-Authored-By: Rangi <35663410+Rangi42@users.noreply.github.com>
* Apply Suggestions 2
Co-authored-by: Rangi <35663410+Rangi42@users.noreply.github.com>
Co-authored-by: vulcandth <vulcandth@gmail.com>
2022-09-14 19:49:58 -05:00
Rangi
41d5ea0482
Rename the object_struct field labels and constants ( #1005 )
...
Fixes #990
2022-09-12 09:15:44 -04:00
vulcandth
4c239a6f65
Rename macros/wram.asm to macros/ram.asm ( #1003 )
2022-09-11 01:05:07 -04:00
vulcandth
39ba36cb92
Use RS Group offset constants for slot_reel
...
Co-Authored-By: Rangi <35663410+Rangi42@users.noreply.github.com>
2022-09-05 10:17:40 +00:00
Idain
01dffba788
Document fish bug properly ( #995 )
2022-08-31 18:13:10 -05:00
Rangi
4883950318
Use for loops to generate box pointer tables
...
Fixes #996
2022-08-31 18:03:49 -04:00
vulcandth
9801b93906
Add Bug comment for fishing/surfing on NPCs
...
Also this re-orders `FishFunction:` and `SurfFunction:` in the bug doc, since `SurfFunction:` is encountered in the file first.
2022-08-31 00:43:12 -05:00
Fredrik Ljungdahl
40c899162b
Replace numbers with constants in PlayHitSound
2022-08-24 12:17:31 +02:00
Idain
bc4fec0694
Fix AI_Smart_Rage comment ( #988 )
2022-08-21 22:39:08 -05:00
Rangi
7ef31d9889
Move non-Pokémon graphics out of gfx/icons
...
Fixes #987
2022-08-17 17:45:26 -04:00
The Void
38cd2155df
Bug Doc: Options menu fails to clear joypad state on initialization ( #984 )
2022-08-11 23:28:35 -05:00
Rangi
0d5cf5c8b9
Refer to "Rival", not "Silver" ( #983 )
...
Fixes #982
2022-08-10 21:24:56 -04:00
vulcandth
c3331eb7b1
Rename scene and callback labels ( #981 )
...
Co-authored-by: Rangi <35663410+Rangi42@users.noreply.github.com>
2022-08-09 18:04:18 -04:00
Rangi
07e8efee7e
Fix some whitespace
2022-08-07 00:38:08 -04:00
Rangi
7cac5b787b
Assert that there are NUM_FRAMES textbox frames
2022-08-06 12:24:40 -04:00
Rangi
8826d97ee4
Define scene constants alongside scene_scripts ( #979 )
...
Generic SCENE_DEFAULT and SCENE_FINISHED are legacy values
2022-07-29 17:43:10 -04:00
Rangi
51bfd31ea8
Use '$' for hex, not '0x'
2022-07-21 19:59:10 -04:00
Rangi
974bb7bf33
Only use "; BUG:" comments for documented bugs
2022-07-17 14:08:56 -04:00
Colton G. Rushton
145d8dd5c2
wVirtualOAM -> wShadowOAM and hTransferVirtualOAM -> hTransferShadowOAM ( #971 )
2022-07-09 17:18:22 -04:00
vulcandth
ef9b9bb437
Clean up bugs commented in the source code ( #912 )
...
Co-authored-by: Rangi <remy.oukaour+rangi42@gmail.com>
2022-07-09 16:12:02 -05:00
Rangi
a2e8f078a4
Split "gfx anims" into "pic anims" and "sprite anims"
...
Fixes #876
2022-07-04 01:11:42 -04:00
vulcandth
1853f70add
VC ExchangeBytes Aliases
...
Co-Authored-By: aaaaaa123456789 <aaaaaa123456789@acidch.at>
2022-06-21 11:16:15 +02:00
Rangi
a1498e63e2
Rename search.asm and search2.asm
2022-06-17 23:27:53 -04:00
vulcandth
66d84ff021
MobileCheckOwnMonAnywhere & CheckOwnMonAnywhere Label, comments, formatting (#927 )
...
Co-authored-by: Rangi <35663410+Rangi42@users.noreply.github.com>
2022-06-17 23:21:08 -04:00
Colton G. Rushton
84a3b335aa
Document that farcall returns c in a for some code ( #937 )
2022-06-17 22:30:53 -04:00
vulcandth
5f0597e944
Rename SLP to SLP_MASK ( #918 )
...
Co-authored-by: Rangi <35663410+Rangi42@users.noreply.github.com>
2022-06-17 22:25:56 -04:00
vulcandth
73c020074e
Remove redundant comments referencing labels ( #921 )
2022-06-06 17:34:54 -04:00
vulcandth
3648afda16
RGBDS syntax updates ( #905 )
...
New MACRO and DEF syntax
2022-06-06 17:25:42 -04:00
vulcandth
a4d346cc8c
Improved Virtual Console patch identifiers ( #907 )
2022-06-06 17:22:48 -04:00
Konrad Borowski
6e3f2a47bd
Remove Heavy Ball never happens comment
...
It's not correct as Snorlax weights more than 409.6 kg.
2022-05-26 19:56:07 +00:00
Idain
dc121712fe
Fix misspelled label ( #904 )
2022-04-17 11:36:30 -04:00
vulcandth
f9077c6db6
Additional vc_asserts ( #906 )
2022-04-16 20:42:06 -04:00
Idain
b06cfe78fd
Use NUM_BATTLE_STATS instead of raw numbers
2022-04-06 10:28:18 +00:00
mid-kid
1d97d41ea2
Tile constant makes more sense as negative
2022-04-05 21:22:46 +02:00
vulcandth
af7d328d66
Cleanup Magic Numbers
2022-04-05 19:14:39 +00:00
