vulcandth
ef9b9bb437
Clean up bugs commented in the source code ( #912 )
...
Co-authored-by: Rangi <remy.oukaour+rangi42@gmail.com >
2022-07-09 16:12:02 -05:00
vulcandth
5f0597e944
Rename SLP to SLP_MASK ( #918 )
...
Co-authored-by: Rangi <35663410+Rangi42@users.noreply.github.com >
2022-06-17 22:25:56 -04:00
Konrad Borowski
6e3f2a47bd
Remove Heavy Ball never happens comment
...
It's not correct as Snorlax weights more than 409.6 kg.
2022-05-26 19:56:07 +00:00
Rangi
2910b9a6c2
Rename GetPokedexEntryBank to HeavyBall_GetDexEntryBank
2022-02-22 17:11:33 -05:00
Rangi
e706b878d9
Use ~X instead of $ff ^ X
2021-11-23 20:37:18 -05:00
Rangi
4522162d45
Consistent labels for each nickname in RAM
2021-03-17 16:38:21 -04:00
Rangi
40902ffe24
Verify data table sizes with table_width and assert_table_length macros
...
This was discussed in #706
It also uncovered some off-by-one issues with defining some constants.
A few structs now use rsreset/_RS to define their offset constants, as discussed in #739
2021-03-04 00:15:03 -05:00
Rangi
7d3ea88611
Rename GetFarHalfword to GetFarWord
...
Fixes #796
2021-01-09 15:16:05 -05:00
Rangi
99e66c2557
Rename some labels
...
- Remove "Buffer" suffix from some byte and word quantities
- Change "Ptr" to "Pointer"
Fixes #789
2020-12-23 16:29:30 -05:00
Rangi
7254c10093
Identify remaining uses of wBuffer1-6 as general-purpose HP buffers or mobile
2020-11-03 23:25:22 -05:00
Rangi
9f62d7911b
Identify some more uses of wBuffer1-6
2020-11-03 22:45:12 -05:00
Rangi
bcc0d633e9
Identify the remaining (non-mobile) uses of another WRAM union
2020-10-29 14:51:41 -04:00
Rangi
9dcdad5e60
Comment, remove, or revise many unreferenced labels
2020-10-26 20:29:58 -04:00
Rangi
306c85750e
Identify some more unnamed labels
2020-10-04 20:10:39 -04:00
Rangi
1357e0d674
Fix #769 : document the Heavy Ball weight bank bug
2020-09-27 12:39:27 -04:00
mid-kid
79bb2784e9
Better label 2D menu data
2020-08-03 22:56:49 +02:00
Rangi
61847b3596
Identify some more labels
2020-06-22 16:30:13 -04:00
Rangi
e0d07fba3f
Sync PokeFluteTerminator with pokegold
2020-06-21 19:01:54 -04:00
Rangi
cc460a17b0
Harmonize engine/{movie, pokemon} with pokegold (renames GetSRAMBank to OpenSRAM)
...
To do: engine/{menus, overworld}
2020-06-17 17:03:38 -04:00
Rangi
8019db3ea9
Harmonize engine/{gfx, items, link, math} with pokegold
2020-06-17 10:39:17 -04:00
Rangi
0345e4fb0e
Add suffixes to some constants to avoid ambiguity
...
- `PSYCHIC` → `PSYCHIC_TYPE` (not the trainer `PSYCHIC_T` or the move `PSYCHIC_M`)
- `BLACKBELT` → `BLACKBELT_I` (not the trainer `BLACKBELT_T`)
- `CURSE_T` → `CURSE_TYPE` (not the move `CURSE`)
- `TOWN_MAP_D` → `TOWN_MAP_POSTER` (not the item `TOWN_MAP`)
This also uncovered a misidentified event: `EVENT_DECO_PLANT_4` → `EVENT_DECO_POSTER_1`. (There are three plants and four posters.)
2020-03-21 17:59:26 -04:00
mid-kid
26b8bf003e
Standardize on lowercase Tilemap and Attrmap
...
We used to have a mixture of TileMap and and Tilemap, as well as the
similar AttrMap. Standardize on one.
2020-02-13 18:31:10 +01:00
mid-kid
e3e0bcd653
#641 fixes and additions. ( #646 )
...
Name a lot of text labels according to our conventions
2019-10-20 18:24:17 -04:00
mid-kid
3e78e5b2b6
TextBox -> Textbox
...
Homogenizing names.
2019-04-09 16:09:18 +02:00
Rangi
3202c4f3df
Resolve issue #575 : Rename text commands
2018-11-18 12:41:11 -05:00
