Commit Graph

70 Commits

Author SHA1 Message Date
xCrystal
e44744c587 wVramState -> wStateFlags and define flag constants (from pokecrystal f72f078c0e68736adf81f6c45c84f0c1e127a231) 2024-02-11 00:34:46 +01:00
xCrystal
5c4d982702 Apply most of pokecrystal PR 1105 2024-02-11 00:16:00 +01:00
xCrystal
2cbe0e1764 Sync with pokecrystal up to aba1f14 2023-09-24 15:06:19 +02:00
xCrystal
d6001be90c Sync with pokecrystal up to 8873506b1 2023-09-24 14:21:42 +02:00
xCrystal
fc2e757c57 Make level selection menu landmarks universal (#4) (#12) 2023-08-20 12:08:24 +02:00
xCrystal
052d246ee3 Use overworld textbox in text printing functions, differentiating between 1bpp and 2bpp text (#10) 2023-08-11 12:28:14 +02:00
xCrystal
9df4cf6946 Create a fourth time of day (#2) 2023-07-31 12:27:53 +02:00
xCrystal
05448d7a7e Remove RTC (#1) and remove time of day dependence on RTC (#7) [Commit #2] 2023-07-28 00:07:07 +02:00
xCrystal
0571144a7b Remove RTC (#1) and remove time of day dependence on RTC (#7) [Commit 1] 2023-07-27 20:32:15 +02:00
xCrystal
d30b9dd60f Further remove unnecessary DMG/SGB checking (#7) and remove SGB layouts and palette data (#1) 2023-07-26 17:02:33 +02:00
xCrystal
acd022d765 Remove unnecessary DMG and SGB checking (#7) 2023-07-26 17:02:33 +02:00
xCrystal
787caa2147 Get rid of LANDMARK_SPECIAL (#1) 2023-07-25 18:32:57 +02:00
xCrystal
473c23a727 Remove unnecessary event and engine flags (#1) 2023-07-25 18:24:38 +02:00
xCrystal
5147904f78 Remove original maps and object events (#1) 2023-07-25 15:33:08 +02:00
Colton G. Rushton
145d8dd5c2
wVirtualOAM -> wShadowOAM and hTransferVirtualOAM -> hTransferShadowOAM (#971) 2022-07-09 17:18:22 -04:00
vulcandth
3648afda16
RGBDS syntax updates (#905)
New MACRO and DEF syntax
2022-06-06 17:25:42 -04:00
Idain
5ac4a51751
Use time constants more often (#867) 2022-01-10 20:57:40 -05:00
Rangi
f59f1bdb88 Standardize capitalization of ".Jumptable" 2021-06-19 19:52:05 -04:00
Rangi
316fa4b695 Use rgbds 0.5.0 2021-04-19 16:31:37 -04:00
Rangi
dc18e188b2 Sync some files with pokegold 2021-03-24 10:24:52 -04:00
Rangi
8daf8fe19c The radio's "Places & People" does not comment on Mysticalman Eusine 2021-03-21 21:07:45 -04:00
Rangi
3684296583 Revise some constant definitions 2021-03-16 18:06:18 -04:00
Rangi
40902ffe24 Verify data table sizes with table_width and assert_table_length macros
This was discussed in #706

It also uncovered some off-by-one issues with defining some constants.

A few structs now use rsreset/_RS to define their offset constants, as discussed in #739
2021-03-04 00:15:03 -05:00
Rangi
7d3ea88611 Rename GetFarHalfword to GetFarWord
Fixes #796
2021-01-09 15:16:05 -05:00
Rangi
99e66c2557 Rename some labels
- Remove "Buffer" suffix from some byte and word quantities
- Change "Ptr" to "Pointer"

Fixes #789
2020-12-23 16:29:30 -05:00
Rangi
97e981985b Correct some filename comments 2020-11-17 11:12:21 -05:00
Rangi
17894e5f39 Replace $0 with 0 for "ld l, a / ld h, 0" idiom 2020-11-09 15:20:40 -05:00
Rangi
ea426a8879 Identify more WRAM labels, and start a <X>_DummyFunction label convention 2020-10-28 14:34:38 -04:00
Rangi
6d333bed5f Replace many '; unused' with '; unreferenced' 2020-10-28 10:21:10 -04:00
Rangi
c85ba78b77 Use more assertions to ensure correct code and data 2020-10-26 22:24:38 -04:00
Rangi
9dcdad5e60 Comment, remove, or revise many unreferenced labels 2020-10-26 20:29:58 -04:00
Rangi
2e90df15b7 Update battle anim bg function comments, and identify more unnamed labels 2020-10-06 18:09:33 -04:00
Rangi
6b7ade66da Identify more unnamed labels 2020-10-05 16:15:57 -04:00
Rangi
d9603e3e33 Identify more unnamed labels 2020-10-04 22:34:50 -04:00
Rangi
0b31d12dac
Merge pull request #756 from mid-kid/master
Rub a dub dub, thanks for the grub
2020-08-18 16:35:15 -04:00
Rangi
7729dcd204 Consistent constants for radio data table sizes (could still be better) 2020-08-13 13:47:50 -04:00
mid-kid
248763b238 Prevent OaksPKMNTalk from looping forever if NUM_GRASSMON is changed
That should cause no real problems because of a range check right after
it.
2020-08-03 22:56:49 +02:00
Rangi
d96f914315 Define JOHTO_FLYPOINT like KANTO_FLYPOINT 2020-07-21 12:15:14 -04:00
Rangi
a9941e28cc Define NUM_FLYPOINTS 2020-07-21 11:48:39 -04:00
Rangi
fce6243b43 Identify more labels, and use the jumptable macro when possible 2020-07-01 13:13:49 -04:00
Rangi
91774f206e Replace "Unreferenced" labels with "; unreferenced" comments 2020-06-21 16:27:43 -04:00
Rangi
be93ab33a7 Harmonize engine/{phone, pokedex, pokegear, printer, rtc, tilesets} with pokegold
To do: engine/{menus, movie, overworld, pokemon}
2020-06-17 11:29:00 -04:00
Rangi
79184bc718 Miscellaneous fixes:
- `hSecondsBackup` -> `hUnusedBackup`
- `ld bc, hBGMapAddress + 1` -> `bccoord -1, -2, 0`
- Identify some `.asm_XXX` labels
2020-04-04 15:43:10 -04:00
Rangi
ad50e94b50 Add a LANDMARK_ prefix to landmark constants
Resolves #697
2020-03-15 19:50:39 -04:00
mid-kid
26b8bf003e Standardize on lowercase Tilemap and Attrmap
We used to have a mixture of TileMap and and Tilemap, as well as the
similar AttrMap. Standardize on one.
2020-02-13 18:31:10 +01:00
mid-kid
0d81f1c470 InitSpriteAnimStruct <-> _InitSpriteAnimStruct
These were the wrong way around, as the function in home should not be
prefixed
2020-02-13 18:31:10 +01:00
Rangi
ceadab8cd1 PnP_HiddenPlaces -> PnP_Places
The "Places & People" radio station does not avoid these maps; it only describes these maps.
2020-02-06 11:07:42 -05:00
Rangi
80cf859cd3 PHONE_DISPLAY_HEIGHT is 4, the number of visible phone entries 2020-01-19 14:10:10 -05:00
mid-kid
739a60b33c Make the map setup commands match the actual function names better
These functions used as map setup commands are used in other places,
too, so I can't prefix them under the same. The names should match
except I won't repeat "map" in a map setup command name.
2019-11-18 18:21:57 +01:00
mid-kid
e3e0bcd653 #641 fixes and additions. (#646)
Name a lot of text labels according to our conventions
2019-10-20 18:24:17 -04:00