Rangi
41d5ea0482
Rename the object_struct
field labels and constants ( #1005 )
...
Fixes #990
2022-09-12 09:15:44 -04:00
vulcandth
4c239a6f65
Rename macros/wram.asm
to macros/ram.asm
( #1003 )
2022-09-11 01:05:07 -04:00
vulcandth
39ba36cb92
Use RS Group offset constants for slot_reel
...
Co-Authored-By: Rangi <35663410+Rangi42@users.noreply.github.com>
2022-09-05 10:17:40 +00:00
Idain
01dffba788
Document fish bug properly ( #995 )
2022-08-31 18:13:10 -05:00
Rangi
4883950318
Use for
loops to generate box pointer tables
...
Fixes #996
2022-08-31 18:03:49 -04:00
vulcandth
9801b93906
Add Bug comment for fishing/surfing on NPCs
...
Also this re-orders `FishFunction:` and `SurfFunction:` in the bug doc, since `SurfFunction:` is encountered in the file first.
2022-08-31 00:43:12 -05:00
Fredrik Ljungdahl
40c899162b
Replace numbers with constants in PlayHitSound
2022-08-24 12:17:31 +02:00
Idain
bc4fec0694
Fix AI_Smart_Rage comment ( #988 )
2022-08-21 22:39:08 -05:00
Rangi
7ef31d9889
Move non-Pokémon graphics out of gfx/icons
...
Fixes #987
2022-08-17 17:45:26 -04:00
The Void
38cd2155df
Bug Doc: Options menu fails to clear joypad state on initialization ( #984 )
2022-08-11 23:28:35 -05:00
Rangi
0d5cf5c8b9
Refer to "Rival", not "Silver" ( #983 )
...
Fixes #982
2022-08-10 21:24:56 -04:00
vulcandth
c3331eb7b1
Rename scene and callback labels ( #981 )
...
Co-authored-by: Rangi <35663410+Rangi42@users.noreply.github.com>
2022-08-09 18:04:18 -04:00
Rangi
07e8efee7e
Fix some whitespace
2022-08-07 00:38:08 -04:00
Rangi
7cac5b787b
Assert that there are NUM_FRAMES textbox frames
2022-08-06 12:24:40 -04:00
Rangi
8826d97ee4
Define scene constants alongside scene_scripts ( #979 )
...
Generic SCENE_DEFAULT and SCENE_FINISHED are legacy values
2022-07-29 17:43:10 -04:00
Rangi
51bfd31ea8
Use '$' for hex, not '0x'
2022-07-21 19:59:10 -04:00
Rangi
974bb7bf33
Only use "; BUG:" comments for documented bugs
2022-07-17 14:08:56 -04:00
Colton G. Rushton
145d8dd5c2
wVirtualOAM -> wShadowOAM and hTransferVirtualOAM -> hTransferShadowOAM ( #971 )
2022-07-09 17:18:22 -04:00
vulcandth
ef9b9bb437
Clean up bugs commented in the source code ( #912 )
...
Co-authored-by: Rangi <remy.oukaour+rangi42@gmail.com>
2022-07-09 16:12:02 -05:00
Rangi
a2e8f078a4
Split "gfx anims" into "pic anims" and "sprite anims"
...
Fixes #876
2022-07-04 01:11:42 -04:00
vulcandth
1853f70add
VC ExchangeBytes Aliases
...
Co-Authored-By: aaaaaa123456789 <aaaaaa123456789@acidch.at>
2022-06-21 11:16:15 +02:00
Rangi
a1498e63e2
Rename search.asm and search2.asm
2022-06-17 23:27:53 -04:00
vulcandth
66d84ff021
MobileCheckOwnMonAnywhere
& CheckOwnMonAnywhere
Label, comments, formatting (#927 )
...
Co-authored-by: Rangi <35663410+Rangi42@users.noreply.github.com>
2022-06-17 23:21:08 -04:00
Colton G. Rushton
84a3b335aa
Document that farcall
returns c
in a
for some code ( #937 )
2022-06-17 22:30:53 -04:00
vulcandth
5f0597e944
Rename SLP
to SLP_MASK
( #918 )
...
Co-authored-by: Rangi <35663410+Rangi42@users.noreply.github.com>
2022-06-17 22:25:56 -04:00
vulcandth
73c020074e
Remove redundant comments referencing labels ( #921 )
2022-06-06 17:34:54 -04:00
vulcandth
3648afda16
RGBDS syntax updates ( #905 )
...
New MACRO and DEF syntax
2022-06-06 17:25:42 -04:00
vulcandth
a4d346cc8c
Improved Virtual Console patch identifiers ( #907 )
2022-06-06 17:22:48 -04:00
Konrad Borowski
6e3f2a47bd
Remove Heavy Ball never happens comment
...
It's not correct as Snorlax weights more than 409.6 kg.
2022-05-26 19:56:07 +00:00
Idain
dc121712fe
Fix misspelled label ( #904 )
2022-04-17 11:36:30 -04:00
vulcandth
f9077c6db6
Additional vc_asserts ( #906 )
2022-04-16 20:42:06 -04:00
Idain
b06cfe78fd
Use NUM_BATTLE_STATS instead of raw numbers
2022-04-06 10:28:18 +00:00
mid-kid
1d97d41ea2
Tile constant makes more sense as negative
2022-04-05 21:22:46 +02:00
vulcandth
af7d328d66
Cleanup Magic Numbers
2022-04-05 19:14:39 +00:00
Idain
9b4ebe9400
Replace magic numbers with constants ( #894 )
2022-03-20 19:58:18 -04:00
Rangi
f33a041930
Allow alternate labels for patch names
2022-03-12 22:38:29 -05:00
vulcandth
31c3c94d64
Build the Virtual Console patch with make crystal11_vc
( #882 )
...
Fixes #813
2022-03-12 18:34:04 -05:00
Rangi
3a562f9896
Identify some wMenuJoypad-related button constants
2022-03-09 19:42:26 -05:00
Rangi
2910b9a6c2
Rename GetPokedexEntryBank
to HeavyBall_GetDexEntryBank
2022-02-22 17:11:33 -05:00
Idain
d0c8f63f25
Rename ENGINE_FISH_SWARM to ENGINE_QWILFISH_SWARM ( #879 )
2022-02-22 09:47:05 -05:00
mid-kid
418b73bc6d
Use constants for PartyAttr in move_effects/thief.asm
2022-02-15 18:30:57 +01:00
Rangi
e56a9f7962
Clear however many bytes are needed for wFruitTreeFlags
2022-02-14 17:28:08 -05:00
Idain
e949477089
Document Return/Frustration bug and its fix ( #872 )
...
Co-authored-by: Rangi <35663410+Rangi42@users.noreply.github.com>
2022-01-24 20:48:21 -05:00
Rangi
20dc31115e
Use VRAM_End
in place of sScratch
2022-01-20 20:16:22 -05:00
Rangi
0ffdb65210
Better comments for enemy health percentage code
2022-01-10 21:25:43 -05:00
Idain
5ac4a51751
Use time constants more often ( #867 )
2022-01-10 20:57:40 -05:00
Idain
67207fab94
Identify why five of six enemy mon base stats are copied ( #866 )
...
Co-authored-by: Rangi <35663410+Rangi42@users.noreply.github.com>
2022-01-08 13:42:40 -05:00
Rangi
69185e1657
Identify some overworld movement data
2021-12-22 21:38:26 -05:00
Rangi
e706b878d9
Use ~X instead of $ff ^ X
2021-11-23 20:37:18 -05:00
Rangi
ab0f9c287a
Use compound assignment operators
2021-11-23 20:18:08 -05:00
Rangi
39111486ab
Fix #845 : Liz gossips about a beautiful trainer, not Pokémon
2021-11-03 17:24:16 -04:00
Rangi
187b120007
Add assertions to some more tables
2021-10-24 18:28:54 -04:00
Rangi
d4a6a1b2bc
Add table assertions to slot machine data
2021-10-15 22:15:00 -04:00
Rangi
bd45cfd5fd
Add assert PokemonPicPointers == UnownPicPointers
in GetFrontpicPointer
2021-10-06 17:44:34 -04:00
Rangi
fb2a95afed
and 50 percent
-> and %011111111
2021-09-07 19:18:22 -04:00
IIMarckus
a283f44954
More EFFECTIVEness.
2021-08-16 14:44:57 -06:00
IIMarckus
52290d8e03
Use EFFECTIVE constant for 1.0× battle damage.
2021-08-16 14:42:45 -06:00
Rangi
d93c13c94c
Identify more palettes in CBG layouts
2021-07-19 18:59:16 -04:00
Nescientist
80a3f7e1ba
Fixing comments in BattleCommand_Teleport
2021-06-20 10:56:11 -04:00
Rangi
f59f1bdb88
Standardize capitalization of ".Jumptable"
2021-06-19 19:52:05 -04:00
TheFakeMateo
7a03fecc38
Fix incorrectly swapped Players PC menu constants
2021-06-09 19:31:54 -04:00
Rangi
e4d82e92d0
Rename prioritysjump
to sdefer
2021-06-08 20:35:04 -04:00
Rangi
1f9e688b76
MON_PKRUS -> MON_POKERUS
2021-06-07 20:00:21 -04:00
Rangi
a41dac9a2f
"ld [MON_LEVEL], a" in ComputeNPCTrademonStats should be "ld [wCurPartyLevel], a"
2021-06-07 19:36:03 -04:00
Rangi
e140e88b7b
Add more comments to tileset palette animation functions
2021-05-30 23:32:03 -04:00
Rangi
ed0a0f7159
Move the dbbw, dbww, and dbwww macros to legacy
2021-05-30 15:51:49 -04:00
Rangi
b1dbadbdd3
Require rgbds 0.5.1
...
Use some new features: \<10> macro args, SECTION UNION, SIZEOF/STARTOF, and CHARLEN/CHARSUB
2021-05-09 12:26:28 -04:00
Rangi
efd1006917
Use {interpolation} to generate sequences of RAM labels
...
This makes the table_width/assert_table_length usages unnecessary, and also keeps the labels automatically up to date if the length constants change.
2021-04-27 12:11:39 -04:00
Rangi
c5f9e25cc4
SPECIAL -> UNUSED_TYPES_END
2021-04-26 12:00:16 -04:00
Rangi
316fa4b695
Use rgbds 0.5.0
2021-04-19 16:31:37 -04:00
Rangi
2fe0cbbb19
Add some comments regarding 16-bit increment/decrement
2021-03-24 18:34:33 -04:00
Rangi
dc18e188b2
Sync some files with pokegold
2021-03-24 10:24:52 -04:00
Rangi
8bf76af5a7
Consistent comments in the tileset animation engine
2021-03-23 20:47:32 -04:00
Rangi
dbe2360ecd
Miscellaneous cleanup
2021-03-22 16:41:17 -04:00
Rangi
8daf8fe19c
The radio's "Places & People" does not comment on Mysticalman Eusine
2021-03-21 21:07:45 -04:00
Rangi
90ce126139
Use numeric constants in text strings with "{d:interpolation}"
2021-03-21 18:14:31 -04:00
Rangi
0506e5b1b9
Assert the sBox1-14 tables have NUM_BOXES entries
2021-03-21 17:47:53 -04:00
Rangi
4522162d45
Consistent labels for each nickname in RAM
2021-03-17 16:38:21 -04:00
Rangi
6c8f8609cb
Assert some more table widths
2021-03-17 11:38:01 -04:00
Rangi
3684296583
Revise some constant definitions
2021-03-16 18:06:18 -04:00
Rangi
ec1fe073a3
$11 = wTempMonStructEnd - wTempMonLevel
2021-03-15 15:40:48 -04:00
Rangi
97a11c623e
Sync some files with pokegold
2021-03-11 17:43:20 -05:00
Rangi
d132a20b7a
Verify script command table sizes
2021-03-11 16:28:52 -05:00
Rangi
dbabd8b4a9
Define MAPGROUP_* constants and verify MapGroup_* table sizes
2021-03-10 21:16:54 -05:00
Rangi
e791c5392b
Merge pull request #806 from Rangi42/tables
...
Verify data table sizes with table_width and assert_table_length macros
2021-03-08 07:01:31 -08:00
Rangi
c1c609ec4a
Identify scrolling menu lists in WRAM
...
Fixes #809
2021-03-08 09:41:55 -05:00
Rangi
40902ffe24
Verify data table sizes with table_width and assert_table_length macros
...
This was discussed in #706
It also uncovered some off-by-one issues with defining some constants.
A few structs now use rsreset/_RS to define their offset constants, as discussed in #739
2021-03-04 00:15:03 -05:00
Rangi
4401d24074
Identify link sync buffers, separate from link action bytes
...
Fixes #803
2021-02-22 12:02:52 -05:00
Rangi
287d893d22
Use PARTY_LENGTH and MAILBOX_CAPACITY constants
2021-02-10 08:50:39 -05:00
Rangi
5b9e6c0299
Identify label BattleTowerFade.loop
2021-02-05 14:56:29 -05:00
Rangi
4be482e587
Merge pull request #799 from FredrIQ/typo_fix
...
Battle Tower: fix typo in constant (PROGESS -> PROGRESS)
2021-02-05 09:45:11 -08:00
Rangi
4264d53eb6
Identify some more labels
2021-02-05 12:44:21 -05:00
Fredrik Ljungdahl
8f4dcbcb59
Battle Tower: fix typo in constant (PROGESS -> PROGRESS)
2021-02-04 12:42:56 +01:00
Rangi
7d3ea88611
Rename GetFarHalfword to GetFarWord
...
Fixes #796
2021-01-09 15:16:05 -05:00
Rangi
5db892782a
Remove "Buffer" suffix from two HRAM labels
2020-12-23 16:54:28 -05:00
Rangi
99e66c2557
Rename some labels
...
- Remove "Buffer" suffix from some byte and word quantities
- Change "Ptr" to "Pointer"
Fixes #789
2020-12-23 16:29:30 -05:00
Rangi
6f226f584c
Identify link.asm WRAM labels based on ax6's research notes < https://pastebin.com/NTxjzKGQ >
2020-12-08 21:24:48 -05:00
Rangi
9fea403be2
grey -> gray
2020-12-08 14:34:54 -05:00
Rangi
098903fc97
FarString -> PlaceFarString, and document a BrokenPlaceFarString bug
2020-12-07 13:32:08 -05:00
Rangi
4ef556cbc8
Document AI_Smart_Conversion2 bug ( resolves #786 )
2020-12-07 13:13:03 -05:00
aljohnston112
7b9d8767d4
Identified two magic numbers and cleaned up some comments ( #783 )
...
Improve the audio engine's comments and replace some magic numbers with constants
2020-12-07 12:44:16 -05:00
Rangi
5e9d43e39b
text "<PARA>..." → text_start and para "..."
2020-12-04 22:28:31 -05:00
Rangi
4613bcfadf
Use STRING_BUFFER_LENGTH for the wStringBuffers
2020-11-24 20:11:17 -05:00
Rangi
97e981985b
Correct some filename comments
2020-11-17 11:12:21 -05:00
Rangi
9b3c45b14d
Resolve some "???" comments
2020-11-17 11:09:02 -05:00
Rangi
fa3712ea34
Remove "XXX" comments (various "???+" still mark unclear code)
2020-11-09 16:38:11 -05:00
Rangi
6a5edc98e9
Terser damage calculation constants
2020-11-09 16:12:19 -05:00
Rangi
17894e5f39
Replace $0 with 0 for "ld l, a / ld h, 0" idiom
2020-11-09 15:20:40 -05:00
Rangi
03e149e559
Identify wBattleAnimTemp0-3
2020-11-09 15:05:14 -05:00
Rangi
62b756c46e
Rename "dummy game" to "memory game"
2020-11-08 19:32:57 -05:00
Rangi
7254c10093
Identify remaining uses of wBuffer1-6 as general-purpose HP buffers or mobile
2020-11-03 23:25:22 -05:00
Rangi
a831b34e5c
Identify some uses of wBuffer1-6 in new Crystal code
2020-11-03 22:52:50 -05:00
Rangi
9f62d7911b
Identify some more uses of wBuffer1-6
2020-11-03 22:45:12 -05:00
Rangi
c88c4a8340
Identify more uses of wBuffer1-6
2020-11-03 19:53:07 -05:00
Rangi
826e070f04
More syncing with pokegold
2020-11-03 10:13:06 -05:00
Rangi
01d6e6c758
Group some link.asm code into "paragraphs"
2020-11-02 19:32:14 -05:00
Rangi
9ab9088a9f
Identify wLinkBattleRNPreamble
2020-11-01 13:42:12 -05:00
Rangi
6220200f0f
Identify some more labels, and make some more consistent
2020-11-01 12:36:38 -05:00
Rangi
4a323cf591
UnusedSpriteAnimGFX was to sprite anims as AnimObjGFX is to battle anims
2020-10-30 17:41:03 -04:00
Rangi
9b0002161b
Extract more RGB data to .pal files
2020-10-30 16:12:25 -04:00
Rangi
fe1a58deea
Identify wSpriteAnimDict key constants
2020-10-30 15:39:08 -04:00
Rangi
1237156948
Identify mobile Name Card exchange labels
2020-10-30 10:45:31 -04:00
Rangi
ba5bc304f9
Updates to more closely sync with pokegold
2020-10-29 23:23:57 -04:00
Rangi
7883e8f431
Define SERIAL_LINK_BYTE_TIMEOUT
2020-10-29 16:43:28 -04:00
Rangi
a51b1a2f13
Port more pokegold link engine symbols, and name an unused WRAM byte
2020-10-29 15:15:14 -04:00
Rangi
bcc0d633e9
Identify the remaining (non-mobile) uses of another WRAM union
2020-10-29 14:51:41 -04:00
Rangi
ea426a8879
Identify more WRAM labels, and start a <X>_DummyFunction label convention
2020-10-28 14:34:38 -04:00
Rangi
6d333bed5f
Replace many '; unused' with '; unreferenced'
2020-10-28 10:21:10 -04:00
Rangi
446f1846b1
Identify remaining Mystery Gift labels and constants
...
Source: https://projectpokemon.org/home/forums/topic/43930-mystery-gift-reverse-engineering-of-ir-protocol/
2020-10-27 23:09:06 -04:00
Rangi
2738858985
Create data/collision/ for tile collision-related data
2020-10-27 10:00:56 -04:00
Rangi
c85ba78b77
Use more assertions to ensure correct code and data
2020-10-26 22:24:38 -04:00
Rangi
9dcdad5e60
Comment, remove, or revise many unreferenced labels
2020-10-26 20:29:58 -04:00
Rangi
a2b6befd7d
Identify some more labels, mostly WRAM
2020-10-23 16:04:15 -04:00
Rangi
7991db972b
Identify some more link.asm labels (syncing to pokegold)
2020-10-23 13:36:54 -04:00
Rangi
8a73bb9ab2
Identify remaining debug color picker labels
2020-10-23 12:38:07 -04:00
Rangi
bd3f634049
Identify remaining map object labels
2020-10-22 21:30:21 -04:00
Rangi
d8310c166d
Identify some more map object labels and constants
2020-10-22 17:41:48 -04:00
Rangi
15f6a0af43
Identify a few more labels and data
2020-10-22 12:55:46 -04:00
Rangi
b9a74ff777
Identify more sprite graphics and map object labels, and have consistent anonymous jumptable labels
2020-10-22 10:54:53 -04:00
Rangi
ae4fe08084
Identify some more labels (a few link-related)
2020-10-22 00:53:54 -04:00
Rangi
3a2932cec1
Identify remaining two battle anim BG effect functions
2020-10-21 22:51:24 -04:00
Rangi
650686476c
Identify remaining battle AI labels
2020-10-21 21:34:18 -04:00
Rangi
93dcc8b6eb
Identify SwitchItemsInBag labels
...
Thanks to FIQ for having done so in Polished Crystal
2020-10-21 15:39:15 -04:00
Rangi
7b12060e6a
Battle transition spin quadrants are like pokered's half circles
2020-10-19 20:27:19 -04:00
Rangi
406ac7afbb
Identify some values as relative struct offsets in MoveScreenLoop
2020-10-14 18:32:41 -04:00
Rangi
2e90df15b7
Update battle anim bg function comments, and identify more unnamed labels
2020-10-06 18:09:33 -04:00
7Soul
cf26f55985
Identify battle bg effects functions and constants ( #773 )
...
Identify battle bg effects functions and constants
2020-10-06 15:45:09 -04:00
Rangi
fc08ff2c38
Identify some unnamed labels
2020-10-06 13:50:02 -04:00
Rangi
42d0a2567a
Identify some more unnamed labels
2020-10-05 20:10:01 -04:00
Rangi
6b7ade66da
Identify more unnamed labels
2020-10-05 16:15:57 -04:00
Rangi
ff2d850219
Identify some more unnamed labels
2020-10-05 12:02:56 -04:00
Rangi
d9603e3e33
Identify more unnamed labels
2020-10-04 22:34:50 -04:00
Rangi
306c85750e
Identify some more unnamed labels
2020-10-04 20:10:39 -04:00
Rangi
5a546068a8
Identify SGB blk/pal packets
2020-10-04 18:32:33 -04:00
7Soul
2ffc5f907f
Identify battle animation functions ( #771 )
...
Identify battle animation functions
2020-10-03 21:54:02 -04:00
Rangi
1357e0d674
Fix #769 : document the Heavy Ball weight bank bug
2020-09-27 12:39:27 -04:00
Rangi
cf37abd3ec
Remove wKickCounter and wPresentPower aliases for wBattleAnimParam
2020-08-29 20:35:49 -04:00
mid-kid
3b43f79dc6
Use hex for tile IDs in engine/movie/splash.asm
2020-08-27 18:03:54 +02:00
mid-kid
353f78f493
GS_INTRO_STAR/SPARKLE -> GS_GAMEFREAK_LOGO_STAR/SPARKLE
...
These two sprite animations are related to the Game Freak Logo splash
screen, not the actual intro.
2020-08-27 15:13:41 +02:00
mid-kid
15c08ad8a3
Small changes to better match pokegold
2020-08-27 14:52:27 +02:00
mid-kid
13c4a93cea
Fix some constants surrounding sprite animations
...
Also commented the use of the field surrounding the struct
initialization functions.
SPRITEANIMSTRUCT_0C -> SPRITEANIMSTRUCT_VAR1
SPRITEANIMSTRUCT_0D -> SPRITEANIMSTRUCT_VAR2
SPRITEANIMSTRUCT_0E -> SPRITEANIMSTRUCT_VAR3
SPRITEANIMSTRUCT_0F -> SPRITEANIMSTRUCT_VAR4
BATTLEANIMSTRUCT_01 -> BATTLEANIMSTRUCT_OAMFLAGS
BATTLEANIMSTRUCT_ANON_JT_INDEX -> BATTLEANIMSTRUCT_JUMPTABLE_INDEX
BATTLEANIMSTRUCT_0F -> BATTLEANIMSTRUCT_VAR1
BATTLEANIMSTRUCT_10 -> BATTLEANIMSTRUCT_VAR2
2020-08-27 13:59:33 +02:00
mid-kid
733664b18f
Document splash screen animation
2020-08-27 13:59:33 +02:00
mid-kid
2b2c1ac649
Split engine/movie/intro.asm into itself and splash.asm
2020-08-27 13:59:31 +02:00
mid-kid
926e231849
Move all splash screen files to gfx/splash
2020-08-27 13:58:54 +02:00
mid-kid
e40f421ffb
Document weird code involving link trades of mew and celebi
...
This piece of code is frankly rather confusing, as it seemingly doesn't
serve much of a purpose. Documenting it here for future reference.
2020-08-19 16:00:00 +02:00
Rangi
0b31d12dac
Merge pull request #756 from mid-kid/master
...
Rub a dub dub, thanks for the grub
2020-08-18 16:35:15 -04:00
mid-kid
315d6c665e
Add wTitleScreenSelectedOption constants
2020-08-18 22:20:16 +02:00
Rangi
7729dcd204
Consistent constants for radio data table sizes (could still be better)
2020-08-13 13:47:50 -04:00
Rangi
f65448a4c0
Factor out gfx/pack/pack_menu.tilemap
2020-08-12 20:59:54 -04:00
Rangi
ed3e70b97c
Identify some time-related data
2020-08-11 14:12:59 -04:00
mid-kid
8befc889ad
Remove a verifiably false comment
...
wSpriteAnimCount starts at 0, keeps incrementing and never decrements.
When it reaches $ff, the next value is 1.
Its purpose is unknown, as this value is used nowhere else.
2020-08-05 16:02:48 +02:00
mid-kid
aabfc0b413
d
is the multiplier for Sprites_Sine
2020-08-05 16:02:48 +02:00
mid-kid
b6055b1944
Use TRUE for hCGBPalUpdate
2020-08-05 16:02:48 +02:00
mid-kid
ac48d65498
Document wTitleScreenSelectedOption variable
2020-08-05 16:02:44 +02:00
mid-kid
2d2a7dec7d
Label some mobile battle screen functions
2020-08-03 23:35:18 +02:00
mid-kid
58b45443e8
Minor title screen fixes
2020-08-03 23:35:18 +02:00
mid-kid
79bb2784e9
Better label 2D menu data
2020-08-03 22:56:49 +02:00
mid-kid
248763b238
Prevent OaksPKMNTalk from looping forever if NUM_GRASSMON is changed
...
That should cause no real problems because of a range check right after
it.
2020-08-03 22:56:49 +02:00
Rangi
0de7808ded
Identify constant in NamingScreen_IsTargetBox
2020-08-03 15:22:28 -04:00
Rangi
35821ec58c
Correct constants in DoNPCTrade
2020-07-25 18:36:49 -04:00
Rangi
dcb24bc724
Use def_* macros for automatic map event counts
...
Resolves #742
2020-07-24 09:57:16 -04:00
Rangi
dd369f3199
Move EngineFlags and SpecialsPointers into data/engine/
2020-07-22 20:24:53 -04:00
Rangi
11dc805de0
Revert "Factor out tables into data/overworld/"
...
This reverts commit b5a7e7de3e
.
2020-07-22 20:21:26 -04:00
Rangi
b5a7e7de3e
Factor out tables into data/overworld/
...
Fixes #749
2020-07-22 15:22:58 -04:00
Rangi
212846af57
Treat map setup commands like trade script commands
...
Fixes #736
2020-07-22 13:37:43 -04:00
Rangi
bb25c1074c
Use LOAD/ENDL for OAM DMA code in HRAM (requires rgbds 0.4.1)
2020-07-21 19:45:25 -04:00
Rangi
d96f914315
Define JOHTO_FLYPOINT like KANTO_FLYPOINT
2020-07-21 12:15:14 -04:00
Rangi
a9941e28cc
Define NUM_FLYPOINTS
2020-07-21 11:48:39 -04:00
Rangi
fc99117d88
" " → $7f
2020-07-21 11:12:56 -04:00
Rangi
de073374a6
Port pokered's more local system for trade animation scripts
...
Also factor out trade tilemaps
2020-07-17 16:53:22 -04:00
Rangi
59d9932255
SPRITE_GYM_GUY -> SPRITE_GYM_GUIDE
2020-07-17 13:01:48 -04:00
Rangi
ef452ccbc7
return → endcallback, reloadandreturn → reloadend
2020-07-17 08:37:03 -04:00
Rangi
eca33ef190
Define map setup commands as macros like other script commands
2020-07-13 20:44:16 -04:00
Rangi
e239aa4aba
Disassemble the final English debug ROM
2020-07-13 15:18:28 -04:00
Rangi
c086de0c98
Use const_skip and const_next macros for brevity
2020-07-10 20:03:46 -04:00
Rangi
6ca82e5c86
Eliminate enum: use const instead, with case-by-case parallel const implementations
2020-07-08 15:30:23 -04:00
Rangi
43a9295789
add_tm, add_hm, and add_mt define TM##_MOVE, HM##_MOVE, and MT##_MOVE constants, to avoid repeating the move names in tmhm_moves.asm
2020-07-06 16:53:05 -04:00
Rangi
ddf1163a21
Define SERIAL_PREAMBLE_LENGTH
2020-07-06 15:49:01 -04:00
Rangi
7eef66af3f
Use MAX_NEUTRAL_DAMAGE in BattleCommand_DamageCalc
...
Also make .gitignore consistent with pokered
2020-07-05 15:12:53 -04:00
Rangi
f5ac9b0eb7
SCGB_PARTY_MENU_HP_PALS -> SCGB_PARTY_MENU_HP_BARS, and SCGB_RAM -> SCGB_DEFAULT
2020-07-04 16:18:16 -04:00