100 Commits

Author	SHA1	Message	Date
Andrew Cook	0f5540740b	Some Mobile code labeling and removed magic numbers (#993) ... * Macro loop for EmptyAllSRAMBanks * Many things labeled and magic numbers removed * Conform to the style guide * Rename URLs in mobile_46 * MOBILEAPI_19 -> MOBILEAPI_TELEPHONESTATUS * Update engine/menus/empty_sram.asm Co-authored-by: Rangi <35663410+Rangi42@users.noreply.github.com> * Update ram/wram.asm Co-authored-by: Rangi <35663410+Rangi42@users.noreply.github.com> * Update mobile/mobile_46.asm Co-authored-by: Rangi <35663410+Rangi42@users.noreply.github.com> * Update mobile/mobile_46.asm Co-authored-by: Rangi <35663410+Rangi42@users.noreply.github.com> * Remove underscore from Set*DownloadURL symbols * Begin Labeling TradeCornerHoldMon routines * Add wMobileMon party_struct * Add TRADE_CORNER_REQUEST_LENGTH constant * Name battle tower action functions * Label trade corner send/receive buffer * Label the saved copy of the trade corner pokemon also fix mailmsg_jp * So many copies of decodeBase64Character * Label another buffer * Fix Alignment and use MOBILE_EMAIL_LENGTH * `Function11ad8a` -> `MobileIncJumptableIndex` * Apply Rangi Suggestions pass 1 Co-Authored-By: Rangi <35663410+Rangi42@users.noreply.github.com> * Apply Suggestions 2 Co-authored-by: Rangi <35663410+Rangi42@users.noreply.github.com> Co-authored-by: vulcandth <vulcandth@gmail.com>	2022-09-14 19:49:58 -05:00
Rangi	4883950318	Use for loops to generate box pointer tables ... Fixes #996	2022-08-31 18:03:49 -04:00
Rangi	7ef31d9889	Move non-Pokémon graphics out of gfx/icons ... Fixes #987	2022-08-17 17:45:26 -04:00
The Void	38cd2155df	Bug Doc: Options menu fails to clear joypad state on initialization (#984)	2022-08-11 23:28:35 -05:00
Rangi	0d5cf5c8b9	Refer to "Rival", not "Silver" (#983) ... Fixes #982	2022-08-10 21:24:56 -04:00
Rangi	7cac5b787b	Assert that there are NUM_FRAMES textbox frames	2022-08-06 12:24:40 -04:00
Rangi	974bb7bf33	Only use "; BUG:" comments for documented bugs	2022-07-17 14:08:56 -04:00
Colton G. Rushton	145d8dd5c2	wVirtualOAM -> wShadowOAM and hTransferVirtualOAM -> hTransferShadowOAM (#971)	2022-07-09 17:18:22 -04:00
vulcandth	3648afda16	RGBDS syntax updates (#905) ... New MACRO and DEF syntax	2022-06-06 17:25:42 -04:00
vulcandth	a4d346cc8c	Improved Virtual Console patch identifiers (#907)	2022-06-06 17:22:48 -04:00
vulcandth	f9077c6db6	Additional vc_asserts (#906)	2022-04-16 20:42:06 -04:00
Rangi	f33a041930	Allow alternate labels for patch names	2022-03-12 22:38:29 -05:00
vulcandth	31c3c94d64	Build the Virtual Console patch with make crystal11_vc (#882) ... Fixes #813	2022-03-12 18:34:04 -05:00
Rangi	e706b878d9	Use ~X instead of $ff ^ X	2021-11-23 20:37:18 -05:00
Rangi	ed0a0f7159	Move the dbbw, dbww, and dbwww macros to legacy	2021-05-30 15:51:49 -04:00
Rangi	316fa4b695	Use rgbds 0.5.0	2021-04-19 16:31:37 -04:00
Rangi	99e66c2557	Rename some labels ... - Remove "Buffer" suffix from some byte and word quantities - Change "Ptr" to "Pointer" Fixes #789	2020-12-23 16:29:30 -05:00
Rangi	97e981985b	Correct some filename comments	2020-11-17 11:12:21 -05:00
Rangi	17894e5f39	Replace $0 with 0 for "ld l, a / ld h, 0" idiom	2020-11-09 15:20:40 -05:00
Rangi	c88c4a8340	Identify more uses of wBuffer1-6	2020-11-03 19:53:07 -05:00
Rangi	6220200f0f	Identify some more labels, and make some more consistent	2020-11-01 12:36:38 -05:00
Rangi	fe1a58deea	Identify wSpriteAnimDict key constants	2020-10-30 15:39:08 -04:00
Rangi	ea426a8879	Identify more WRAM labels, and start a <X>_DummyFunction label convention	2020-10-28 14:34:38 -04:00
Rangi	6d333bed5f	Replace many '; unused' with '; unreferenced'	2020-10-28 10:21:10 -04:00
Rangi	446f1846b1	Identify remaining Mystery Gift labels and constants ... Source: https://projectpokemon.org/home/forums/topic/43930-mystery-gift-reverse-engineering-of-ir-protocol/	2020-10-27 23:09:06 -04:00