Rangi
0d5cf5c8b9
Refer to "Rival", not "Silver" ( #983 )
...
Fixes #982
2022-08-10 21:24:56 -04:00
vulcandth
ef9b9bb437
Clean up bugs commented in the source code ( #912 )
...
Co-authored-by: Rangi <remy.oukaour+rangi42@gmail.com>
2022-07-09 16:12:02 -05:00
Rangi
94057c7726
Verify uneven list sizes with list_start, li, and assert_list_length macros
...
This was discussed in #815
2021-03-22 17:17:08 -04:00
Rangi
40902ffe24
Verify data table sizes with table_width and assert_table_length macros
...
This was discussed in #706
It also uncovered some off-by-one issues with defining some constants.
A few structs now use rsreset/_RS to define their offset constants, as discussed in #739
2021-03-04 00:15:03 -05:00
Rangi
b9f2b93c17
Harmonize some more symbols with pokegold
2020-06-16 11:28:52 -04:00
Ryan Tandy
abee217ce0
Fix swapped comments in data/trainers/dvs.asm
...
Bugsy has trainer class id 3 and his DVs are 9/8/8/8.
Whitney has trainer class id 2 and her DVs are 8/8/8/8.
2019-08-27 16:23:27 -07:00
Rangi
36b21b39d8
Fix #537 : Palettes generated from PNGs use .gbcpal directly.
...
This avoids overwriting a .pal file from a .png with the same name.
It also prevents people from trying to edit generated .pal files.
2018-08-31 21:39:17 -04:00
mid-kid
f5cd6341ff
Consistency with order of constant comments
2018-08-07 20:53:14 +02:00
Rangi
67152eab98
Keep more data/ INCLUDEs with relevant routines
2018-06-25 13:45:50 -04:00
Rangi
5693cc49cf
Single newline at the end of files
2018-06-25 12:07:35 -04:00
Rangi
67d1364c7a
Fix triple newlines left over from removing address comments
2018-06-24 23:22:50 -04:00
mid-kid
5efce10789
Remove even more address comments
...
That should be all of them this time
2018-06-25 02:10:37 +02:00
mid-kid
1d9a68dbdd
Remove all address comments
2018-06-24 16:13:22 +02:00
Rangi
9ac2583b20
Use dn
2018-06-06 18:49:16 -04:00
Rangi
09d1ac8725
Specify DVs individually
2018-06-06 11:45:19 -04:00
Rangi
d31ba05aeb
Combine bit flags with | not +
2018-05-05 19:27:10 -04:00
mid-kid
81fff9bb80
Fix file permissions
...
I have no idea why this was a thing (do people store this repo on FAT32
flash drives or something?), but quite a bit of files had a permission
of 755. This isn't really a problem, but it's inconsistent and weird.
2018-04-01 17:05:10 +02:00
Rangi
f0b01a4eea
Document more quirks and bugs
2018-02-26 13:41:48 -05:00
Rangi
eb3726bba0
NO_ITEM == 0
2018-02-25 16:48:31 -05:00
Rangi
612fd7cb96
Merge branch 'master' of https://github.com/pret/pokecrystal
...
# Conflicts:
# maps/KrissHouse2F.asm
2018-02-15 21:21:58 -05:00
luckytyphlosion
8b007e8d51
Fix more w-izing edge cases.
2018-02-04 22:45:04 -05:00
Rangi
32ed487a47
Merge branch 'master' of https://github.com/pret/pokecrystal
...
# Conflicts:
# audio/engine.asm
# constants/gfx_constants.asm
# constants/map_data_constants.asm
# constants/pokemon_data_constants.asm
# constants/sprite_constants.asm
# constants/wram_constants.asm
# data/maps/data.asm
# engine/battle/ai/scoring.asm
# engine/battle/core.asm
# engine/battle/effect_commands.asm
# engine/battle/misc.asm
# engine/battle_anims/getpokeballwobble.asm
# engine/breeding.asm
# engine/buy_sell_toss.asm
# engine/decorations.asm
# engine/events/battle_tower/battle_tower.asm
# engine/events/battle_tower/rules.asm
# engine/events/buena.asm
# engine/events/bug_contest/contest_2.asm
# engine/events/daycare.asm
# engine/events/dratini.asm
# engine/events/halloffame.asm
# engine/events/happiness_egg.asm
# engine/events/kurt.asm
# engine/events/lucky_number.asm
# engine/events/magnet_train.asm
# engine/events/overworld.asm
# engine/events/pokerus/pokerus.asm
# engine/events/print_unown.asm
# engine/events/print_unown_2.asm
# engine/events/unown_walls.asm
# engine/item_effects.asm
# engine/link.asm
# engine/mon_menu.asm
# engine/player_object.asm
# engine/routines/playslowcry.asm
# engine/scripting.asm
# engine/search.asm
# engine/search2.asm
# engine/specials.asm
# engine/start_menu.asm
# engine/timeset.asm
# home/battle_vars.asm
# home/map.asm
# maps/GoldenrodUndergroundSwitchRoomEntrances.asm
# maps/IlexForest.asm
# maps/KrissHouse2F.asm
# maps/Route39Barn.asm
# mobile/mobile_12_2.asm
# mobile/mobile_40.asm
# mobile/mobile_5f.asm
# wram.asm
2018-02-03 19:42:56 -05:00
Rangi
50f6007cc2
No need for ==== lines
2018-01-31 10:36:27 -05:00
Rangi
9ac2cea1f7
Align columns
2018-01-31 00:46:03 -05:00
Rangi
96ae7a7ee3
More compact trainer data
2018-01-31 00:37:03 -05:00
Rangi
d260b5f185
Compact trainer data
2018-01-31 00:07:11 -05:00
luckytyphlosion
a1951cefc0
Prefix wram labels with w, part 2.
2018-01-23 17:39:09 -05:00
Rangi
7cef012335
wUnlockedUnowns engine flag constants
...
Use local labels for "End"ings
2018-01-22 13:00:35 -05:00
Remy Oukaour
0082dcdd62
Missing comment
2018-01-18 22:38:20 -05:00
Remy Oukaour
a9f8aeb94e
Remove trailing whitespace
2018-01-18 21:48:52 -05:00
Remy Oukaour
0a3b251dcb
Arrays end with -1, not $ff
2018-01-10 22:53:42 -05:00
Remy Oukaour
a849c3557b
More comments
...
Fix some constants
2018-01-09 15:39:48 -05:00
Remy Oukaour
a3242b4ad4
Simpler comments
2018-01-09 15:23:03 -05:00
Remy Oukaour
cb92b7bbf0
Indent with tabs
2018-01-09 15:20:21 -05:00
Remy Oukaour
5a73a62d9b
Move battle engine data into data/
...
IsJohtoGymLeader → IsGymLeader
2018-01-09 15:12:49 -05:00
Remy Oukaour
bdd3a55333
Organize mobile/battle_tower_*.asm data and code
2018-01-06 18:53:30 -05:00
Remy Oukaour
7a4d641251
Remove redundant data/ filename prefixes
2017-12-27 01:29:15 -05:00
Remy Oukaour
35a3a19fda
Use "battle_anims" and "sprite_anims" for clarity, not just "anims"
2017-12-26 18:45:04 -05:00
Remy Oukaour
253c09949b
Move data/audio/ back into audio/
...
Keep trainer data together
2017-12-15 12:38:59 -05:00
Remy Oukaour
6ab1d028bb
Split items/ and trainers/ into their data/ and engine/ components
...
Move some data into a pokemon/ subdirectory
2017-12-14 23:00:54 -05:00