Rangi
98da09b3e9
Define more struct offset constants with rsreset instead of const_def
...
This was discussed in #739
2021-03-04 18:15:38 -05:00
Rangi
ef20126fe5
Verify wild data sizes with def_grass/water_wildmons and end_grass/water_wildmons macros
2021-03-04 17:58:30 -05:00
Rangi
40902ffe24
Verify data table sizes with table_width and assert_table_length macros
...
This was discussed in #706
It also uncovered some off-by-one issues with defining some constants.
A few structs now use rsreset/_RS to define their offset constants, as discussed in #739
2021-03-04 00:15:03 -05:00
ElectroDeoxys
9c17fb14c8
Document AI redundant bug ( #802 )
...
Document AI_Redundant Future Sight bug
2021-03-03 17:17:57 -05:00
Rangi
0e818f8b8b
Define SCENE_ALWAYS EQU -1 for coord_events
2021-03-01 21:11:58 -05:00
Rangi
4401d24074
Identify link sync buffers, separate from link action bytes
...
Fixes #803
2021-02-22 12:02:52 -05:00
Rangi
3c3d87e765
Use NITE_HOUR constant for Buena's event
2021-02-16 15:58:09 -05:00
Rangi
287d893d22
Use PARTY_LENGTH and MAILBOX_CAPACITY constants
2021-02-10 08:50:39 -05:00
Rangi
5b9e6c0299
Identify label BattleTowerFade.loop
2021-02-05 14:56:29 -05:00
Rangi
d10b168c6f
Identify unreferenced Goldenrod Pokémon Center text labels
2021-02-05 13:56:39 -05:00
Rangi
a539578006
Merge pull request #798 from CelestialAmber/master
...
Fix typo
2021-02-05 09:45:18 -08:00
Rangi
4be482e587
Merge pull request #799 from FredrIQ/typo_fix
...
Battle Tower: fix typo in constant (PROGESS -> PROGRESS)
2021-02-05 09:45:11 -08:00
Rangi
4264d53eb6
Identify some more labels
2021-02-05 12:44:21 -05:00
Fredrik Ljungdahl
8f4dcbcb59
Battle Tower: fix typo in constant (PROGESS -> PROGRESS)
2021-02-04 12:42:56 +01:00
Amber Brault
b391b6cef0
Fix typo
2021-01-21 11:01:53 -05:00
Rangi
7d3ea88611
Rename GetFarHalfword to GetFarWord
...
Fixes #796
2021-01-09 15:16:05 -05:00
Rangi
f773fd1dd8
The 'tmhm' macro adjusts to the number of TMs/HMs/tutors
2021-01-06 10:20:19 -05:00
Rangi
5db892782a
Remove "Buffer" suffix from two HRAM labels
2020-12-23 16:54:28 -05:00
Rangi
99e66c2557
Rename some labels
...
- Remove "Buffer" suffix from some byte and word quantities
- Change "Ptr" to "Pointer"
Fixes #789
2020-12-23 16:29:30 -05:00
Rangi
1a054661ec
Merge pull request #793 from nbasu02/document-stat-up-hit-update-statmessage
...
move statupmessage above checkfaint in Attack and DefenseUpHit documentation
2020-12-21 08:43:47 -05:00
Neil Basu
9248dbc472
move statupmessage above checkfaint in Attack and DefenseUpHit documentation
2020-12-20 21:41:13 -08:00
Rangi
fff343349d
Clarify signed magnitude in the growth_rate macro
2020-12-20 23:35:22 -05:00
Rangi
9978126309
Merge pull request #792 from nbasu02/document-stat-up-hit-fix
...
Document fix for StatUpHit effects when opponent is KO'd
2020-12-18 09:26:31 -05:00
Rangi
49458edf94
Edit wording and diff format
2020-12-18 09:25:49 -05:00
Neil Basu
cfc9bf5a33
shorten documents on stat up hit effects
2020-12-14 22:34:10 -08:00
Neil Basu
5dc8c92d83
Document fix for StatUpHit effects when opponent is KO'd
2020-12-14 20:17:21 -08:00
Rangi
3550a87360
Update rgbdscheck.asm
...
Hard-code the version string in the failure message so it won't be in hex
2020-12-09 15:11:18 -05:00
Rangi
e485280a8a
Require rgbds 0.4.2
...
This allows [\1] to work when \1 is hl, bc, or de
The object file format has changed along with the version number
2020-12-09 12:21:46 -05:00
Rangi
6f226f584c
Identify link.asm WRAM labels based on ax6's research notes < https://pastebin.com/NTxjzKGQ >
2020-12-08 21:24:48 -05:00
Rangi
9fea403be2
grey -> gray
2020-12-08 14:34:54 -05:00
Rangi
098903fc97
FarString -> PlaceFarString, and document a BrokenPlaceFarString bug
2020-12-07 13:32:08 -05:00
Rangi
4ef556cbc8
Document AI_Smart_Conversion2 bug ( resolves #786 )
2020-12-07 13:13:03 -05:00
Rangi
b1d04e4ed1
Merge pull request #790 from nbasu02/mark-unused-grunts
...
document unused male grunts
2020-12-07 13:01:24 -05:00
aljohnston112
7b9d8767d4
Identified two magic numbers and cleaned up some comments ( #783 )
...
Improve the audio engine's comments and replace some magic numbers with constants
2020-12-07 12:44:16 -05:00
Rangi
5e9d43e39b
text "<PARA>..." → text_start and para "..."
2020-12-04 22:28:31 -05:00
Rangi
ad6effee82
Don't hardcode CRCs within Crystal base data
2020-11-30 11:32:19 -05:00
Neil Basu
900dc1b41b
document unused male grunts
2020-11-27 13:36:53 -08:00
Rangi
4613bcfadf
Use STRING_BUFFER_LENGTH for the wStringBuffers
2020-11-24 20:11:17 -05:00
Rangi
4ca9f45db7
Fix tools/free_space.py
2020-11-21 21:14:32 -05:00
Rangi
145e752266
Use assert to ensure correct base data size
2020-11-17 16:14:45 -05:00
Rangi
97e981985b
Correct some filename comments
2020-11-17 11:12:21 -05:00
Rangi
9b3c45b14d
Resolve some "???" comments
2020-11-17 11:09:02 -05:00
Rangi
cd3fb2ca72
sRTCStatusFlags is one byte
2020-11-09 16:38:21 -05:00
Rangi
fa3712ea34
Remove "XXX" comments (various "???+" still mark unclear code)
2020-11-09 16:38:11 -05:00
Rangi
6a5edc98e9
Terser damage calculation constants
2020-11-09 16:12:19 -05:00
Rangi
17894e5f39
Replace $0 with 0 for "ld l, a / ld h, 0" idiom
2020-11-09 15:20:40 -05:00
Rangi
03e149e559
Identify wBattleAnimTemp0-3
2020-11-09 15:05:14 -05:00
Rangi
62b756c46e
Rename "dummy game" to "memory game"
2020-11-08 19:32:57 -05:00
Rangi
7254c10093
Identify remaining uses of wBuffer1-6 as general-purpose HP buffers or mobile
2020-11-03 23:25:22 -05:00
Rangi
a831b34e5c
Identify some uses of wBuffer1-6 in new Crystal code
2020-11-03 22:52:50 -05:00
