Rangi
0345e4fb0e
Add suffixes to some constants to avoid ambiguity
...
- `PSYCHIC` → `PSYCHIC_TYPE` (not the trainer `PSYCHIC_T` or the move `PSYCHIC_M`)
- `BLACKBELT` → `BLACKBELT_I` (not the trainer `BLACKBELT_T`)
- `CURSE_T` → `CURSE_TYPE` (not the move `CURSE`)
- `TOWN_MAP_D` → `TOWN_MAP_POSTER` (not the item `TOWN_MAP`)
This also uncovered a misidentified event: `EVENT_DECO_PLANT_4` → `EVENT_DECO_POSTER_1`. (There are three plants and four posters.)
2020-03-21 17:59:26 -04:00
Rangi
6a6ba10315
rgbds supports 'X - 1' instead of 'X + -1'
2020-03-21 14:01:05 -04:00
Rangi
5a5f5ececd
Miscellaneous fixes from #694
2020-03-21 13:07:18 -04:00
Rangi
624864307e
Combine Celebi frames into one PNG
2020-03-16 08:58:28 -04:00
Rangi
ad50e94b50
Add a LANDMARK_ prefix to landmark constants
...
Resolves #697
2020-03-15 19:50:39 -04:00
Rangi
f09b68d945
Change how some PNG graphics are formatted
2020-03-01 17:00:57 -05:00
Rangi
1d4c1aeef4
'and BANK' -> 'aka BANK'
2020-02-28 11:51:42 -05:00
Rangi
0cce00cb73
Document a bug where Teleport cannot fail for wild Pokémon
2020-02-28 11:17:58 -05:00
Rangi
447da80615
Identify remaining gfx/unknown files
2020-02-28 09:23:41 -05:00
Rangi
81eaf83cd7
Identify gfx/unknown/4985a.asm as gfx/tilesets/forest-tree/unused.png
2020-02-26 15:41:22 -05:00
Rangi
ee622d6ba1
Identify some labels and constants for Battle Tower
2020-02-25 18:13:50 -05:00
mid-kid
e799515931
Fix SRAM references in Function140ae
2020-02-25 19:38:24 +01:00
Rangi
c3f389d615
Replace some "idiotic", "wtf", "stupid interns" comments with more common "useless", "pointless", "could have done X instead"
2020-02-23 18:51:32 -05:00
mid-kid
9a927c1b3e
Merge pull request #685 from mid-kid/master
...
Moshi moshi? minoru enhansumentsu desu
2020-02-21 21:11:36 +01:00
mid-kid
2a8c969bc7
Fix some comments and inmediates
2020-02-21 21:10:55 +01:00
mid-kid
c22e268083
RTC -> UpdateTimeAndPals
...
Rename clear misnomer.
Most of the related functions in that file aren't really aptly named but
I don't know good names right now.
2020-02-21 18:21:29 +01:00
mid-kid
75a6bb5df6
PanicResetClock -> ClearClock
...
Funky name that only exists based on what it's used for, not so much
what it is.
2020-02-16 12:20:20 +01:00
Rangi
88bbdb6a2f
Define TileCollisionTable as a standard 'db' series
2020-02-13 19:07:19 -05:00
mid-kid
26b8bf003e
Standardize on lowercase Tilemap and Attrmap
...
We used to have a mixture of TileMap and and Tilemap, as well as the
similar AttrMap. Standardize on one.
2020-02-13 18:31:10 +01:00
mid-kid
34ceaac71d
Call_LoadTempTileMapToTileMap → SafeLoadTempTileMapToTileMap
...
Stupid name is stupid smh tbh fam.
2020-02-13 18:31:10 +01:00
mid-kid
a241f049df
Remove FarCall prefix from SwapTextboxPalettes and ScrollBGMapPalettes
...
No prefix for the farcall, prefix with an underscore for the farcalled.
This matches what is done for pretty much every other home function.
2020-02-13 18:31:10 +01:00
mid-kid
991d207d86
OWFlash -> FlashFunction
...
Match the other overworld move functions
2020-02-13 18:31:10 +01:00
mid-kid
a094c58f1e
Split up engine/events/misc_scripts_2.asm
...
New files are:
- engine/events/hidden_item.asm
- engine/events/repel.asm
2020-02-13 18:31:10 +01:00
mid-kid
0d81f1c470
InitSpriteAnimStruct <-> _InitSpriteAnimStruct
...
These were the wrong way around, as the function in home should not be
prefixed
2020-02-13 18:31:10 +01:00
Rangi
ceadab8cd1
PnP_HiddenPlaces -> PnP_Places
...
The "Places & People" radio station does not avoid these maps; it only describes these maps.
2020-02-06 11:07:42 -05:00
Rangi
fb9cbe7d1e
Merge pull request #650 from pret/audio-macros
...
Update audio macros and arguments
2020-02-05 18:51:20 -05:00
Rangi
24a23b1922
Use CMDQUEUE constants
2020-02-04 11:11:43 -05:00
mid-kid
44b361c1bb
Merge branch 'master' into audio-macros
2020-02-04 16:03:01 +01:00
Rangi
80cf859cd3
PHONE_DISPLAY_HEIGHT is 4, the number of visible phone entries
2020-01-19 14:10:10 -05:00
dannye
e7be25948d
Merge branch 'master' into audio-macros
2020-01-06 22:07:33 -06:00
Rangi
94ebdab6d3
Merge pull request #660 from mid-kid/master
...
Make the map setup commands match the actual function names better
2020-01-04 20:08:43 -05:00
Colton G. Rushton
5728d01417
Add and simplify bugfixes in bugs_and_glitches.md ( #664 )
...
Add extra fixes for bugs covered on Bulbapedia (and simplify others)
2020-01-04 16:52:08 -05:00
Rangi
fa7261a8ee
Update some labels
2019-12-03 09:17:21 -05:00
Rangi
0e311ad709
Fix miscellaneous points made in #658
2019-11-23 20:56:22 -05:00
mid-kid
739a60b33c
Make the map setup commands match the actual function names better
...
These functions used as map setup commands are used in other places,
too, so I can't prefix them under the same. The names should match
except I won't repeat "map" in a map setup command name.
2019-11-18 18:21:57 +01:00
mid-kid
77803f571f
Fix some constants around wLinkMode
2019-11-18 18:21:57 +01:00
Rangi
d076159745
Don't use colons for local labels in LoadSpecialMapPalette
2019-11-04 17:43:37 -05:00
Rangi
51720e1e3c
Fix #645 : Use English labels for European mail handling functions
2019-11-03 20:34:02 -05:00
Rangi
4d32035d4f
Bit 6 of PrintNum left-aligns numbers
2019-11-03 20:17:04 -05:00
Rangi
0c7b309f7f
Suggested formatting changes
2019-11-03 20:07:25 -05:00
Rangi
fbe2494dc2
Miscellaneous label and comment corrections
2019-11-03 14:47:06 -05:00
Rangi
717cf3f458
Identify PLAYERMOVEMENT_* constants
2019-11-03 14:30:33 -05:00
Rangi
d5e1b5a628
The $C9 byte in page2.tilemap is a ret opcode
2019-11-03 14:18:23 -05:00
Rangi
4211886921
Use constants for quantities when copying SGB border tiles and palettes
2019-11-03 14:15:20 -05:00
Rangi
f511713c86
Identify some move screen functions
2019-11-03 13:46:00 -05:00
Rangi
3e7c7d5fff
Identify intro tilemaps and attrmaps
2019-11-03 13:38:40 -05:00
Rangi
4aeab6b879
Rename buttonsound to promptbutton
2019-11-03 12:48:54 -05:00
Rangi
5134266b9a
Rename OBJECT_LENGTH to MAPOBJECT_LENGTH and OBJECT_STRUCT_LENGTH to OBJECT_LENGTH
2019-11-03 12:26:38 -05:00
Rangi
01f68fcc6a
Rename TILESET_BATTLE_TOWER to TILESET_BATTLE_TOWER_INSIDE
2019-11-03 12:03:37 -05:00
mid-kid
86061d37d2
More mobile SDK documentation
...
Labelled WRAM addresses, added constants for mobile commands, fixed some
mobile lib function names, documented most of the functions for specific
commands.
2019-10-21 00:42:36 +02:00
