Move skip into dom file

This commit is contained in:
Daniel Imms
2025-12-30 06:05:46 -08:00
parent 481431fbc1
commit 595c119404
2 changed files with 3 additions and 6 deletions
+3
View File
@@ -20,6 +20,9 @@ test.beforeAll(async ({ browser }) => {
test.afterAll(async () => await ctx.page.close());
test.describe('DOM Renderer Integration Tests', () => {
// HACK: Skip on WebKit, not clear why it's failing
test.skip(({ browserName }) => browserName === 'webkit', 'Skipped on WebKit');
injectSharedRendererTests(ctxWrapper);
injectSharedRendererTestsStandalone(ctxWrapper, () => {});
});
-6
View File
@@ -14,9 +14,6 @@ export interface ISharedRendererTestContext {
}
export function injectSharedRendererTests(ctx: ISharedRendererTestContext): void {
// HACK: Skip on WebKit, not clear why it's failing
test.skip(({ browserName }) => browserName === 'webkit', 'Skipped on WebKit');
test.beforeEach(async () => {
await ctx.value.proxy.reset();
ctx.value.page.evaluate(`
@@ -1355,9 +1352,6 @@ enum CellColorPosition {
* treatment.
*/
export function injectSharedRendererTestsStandalone(ctx: ISharedRendererTestContext, setupCb: () => Promise<void> | void): void {
// Skip on WebKit because Playwright's WebKit doesn't render identically
test.skip(({ browserName }) => browserName === 'webkit', 'Skipped on WebKit');
const setupTests = ({ shadowDom }: { shadowDom: boolean }): void => {
test.beforeEach(async () => {
// Recreate terminal