From 595c119404b15c3e3aa58a9c266df9008c3e4f66 Mon Sep 17 00:00:00 2001 From: Daniel Imms <2193314+Tyriar@users.noreply.github.com> Date: Tue, 30 Dec 2025 06:05:46 -0800 Subject: [PATCH] Move skip into dom file --- test/playwright/Renderer.test.ts | 3 +++ test/playwright/SharedRendererTests.ts | 6 ------ 2 files changed, 3 insertions(+), 6 deletions(-) diff --git a/test/playwright/Renderer.test.ts b/test/playwright/Renderer.test.ts index 119832d6..30d23271 100644 --- a/test/playwright/Renderer.test.ts +++ b/test/playwright/Renderer.test.ts @@ -20,6 +20,9 @@ test.beforeAll(async ({ browser }) => { test.afterAll(async () => await ctx.page.close()); test.describe('DOM Renderer Integration Tests', () => { + // HACK: Skip on WebKit, not clear why it's failing + test.skip(({ browserName }) => browserName === 'webkit', 'Skipped on WebKit'); + injectSharedRendererTests(ctxWrapper); injectSharedRendererTestsStandalone(ctxWrapper, () => {}); }); diff --git a/test/playwright/SharedRendererTests.ts b/test/playwright/SharedRendererTests.ts index 2230d831..138fba70 100644 --- a/test/playwright/SharedRendererTests.ts +++ b/test/playwright/SharedRendererTests.ts @@ -14,9 +14,6 @@ export interface ISharedRendererTestContext { } export function injectSharedRendererTests(ctx: ISharedRendererTestContext): void { - // HACK: Skip on WebKit, not clear why it's failing - test.skip(({ browserName }) => browserName === 'webkit', 'Skipped on WebKit'); - test.beforeEach(async () => { await ctx.value.proxy.reset(); ctx.value.page.evaluate(` @@ -1355,9 +1352,6 @@ enum CellColorPosition { * treatment. */ export function injectSharedRendererTestsStandalone(ctx: ISharedRendererTestContext, setupCb: () => Promise | void): void { - // Skip on WebKit because Playwright's WebKit doesn't render identically - test.skip(({ browserName }) => browserName === 'webkit', 'Skipped on WebKit'); - const setupTests = ({ shadowDom }: { shadowDom: boolean }): void => { test.beforeEach(async () => { // Recreate terminal