If a `Go On A Ghost Hunt` Boo is killed while it has a gravity of -1 (at the bottom of its oscillation), and does not hit a wall, it will keep the same negative gravity and continue moving until the textbox is closed. Boo Y speed isn't capped in this scenario, so the constant -1 gravity leads to the boo moving upwards at an increasing rate.
This leads to issues in `boo_act_4`. The distance eventually increases to a point where the boo object is too far to be returned in `cur_obj_nearest_object_with_behavior`.
This can have 2 buggy effects:
- the wrong dialog box being brought up if the textbox is delayed (easiest to do by hanging on a ledge).
- the puzzle solved jingle being played incorrectly if you wait in the textbox long enough
This doesn't actually cause issues with King Boo, it just brings up the wrong text box. King Boo spawning is unaffected by this bug.
The fix is to stop the boo after the death animation has finished playing, stopping the boo from accelerating upwards. I don't believe this to cause any other issues (the boo is already dead after all!)
Thanks to Kyman for finding this bug.
* Fixed one or two bugs, cleaned up a few things, put every non vanilla styled change into POLISHED_TRANSITIONS
And renamed set_and_reset_transition_fade_timer
* Undid the renaming of set_and_reset_transition_fade_timer as suggested
* removed extraneous mat stack index decrement in geo_process_camera (#708)
* Fixed typo in FCR enums (#707)
* v2.1.1
---------
Co-authored-by: Matt Pharoah <mtpharoah@gmail.com>
* Cannon render mode fix
Slipped past me.
* Removed sharp transitions
I like the idea but it really isn´t vanilla and causes issues.
Might be worth revisiting but for now lets just get rid of it.
* fixes
Missing render mode set for transitions, reduced display list alloc for cannon
tested more this time
* Added functions to access and manipulate the fcr31 register
* Improved WiiVC emulator check to avoid false positives
* Updated comments
* Moved float.h to include directory
* Track whether the RCP hang timer has started to prevent double setting
* removed single letter struct field
* remove debug lines
---------
Co-authored-by: someone2639 <someone2639@gmail.com>
