17 Commits

Author	SHA1	Message	Date
Andrew Cook	0f5540740b	Some Mobile code labeling and removed magic numbers (#993) ... * Macro loop for EmptyAllSRAMBanks * Many things labeled and magic numbers removed * Conform to the style guide * Rename URLs in mobile_46 * MOBILEAPI_19 -> MOBILEAPI_TELEPHONESTATUS * Update engine/menus/empty_sram.asm Co-authored-by: Rangi <35663410+Rangi42@users.noreply.github.com> * Update ram/wram.asm Co-authored-by: Rangi <35663410+Rangi42@users.noreply.github.com> * Update mobile/mobile_46.asm Co-authored-by: Rangi <35663410+Rangi42@users.noreply.github.com> * Update mobile/mobile_46.asm Co-authored-by: Rangi <35663410+Rangi42@users.noreply.github.com> * Remove underscore from Set*DownloadURL symbols * Begin Labeling TradeCornerHoldMon routines * Add wMobileMon party_struct * Add TRADE_CORNER_REQUEST_LENGTH constant * Name battle tower action functions * Label trade corner send/receive buffer * Label the saved copy of the trade corner pokemon also fix mailmsg_jp * So many copies of decodeBase64Character * Label another buffer * Fix Alignment and use MOBILE_EMAIL_LENGTH * `Function11ad8a` -> `MobileIncJumptableIndex` * Apply Rangi Suggestions pass 1 Co-Authored-By: Rangi <35663410+Rangi42@users.noreply.github.com> * Apply Suggestions 2 Co-authored-by: Rangi <35663410+Rangi42@users.noreply.github.com> Co-authored-by: vulcandth <vulcandth@gmail.com>	2022-09-14 19:49:58 -05:00
Rangi	51bfd31ea8	Use '$' for hex, not '0x'	2022-07-21 19:59:10 -04:00
Rangi	4522162d45	Consistent labels for each nickname in RAM	2021-03-17 16:38:21 -04:00
Rangi	99e66c2557	Rename some labels ... - Remove "Buffer" suffix from some byte and word quantities - Change "Ptr" to "Pointer" Fixes #789	2020-12-23 16:29:30 -05:00
Rangi	c3c18dd196	Comment more ROM labels as unreferenced ... (Some unreferenced labels are above code which is still used via fallthrough!)	2020-06-21 18:33:31 -04:00
Rangi	58b377f25b	Fix #709 miscellaneous issues	2020-04-16 09:30:50 -04:00
Rangi	36ebcdd8fe	MON_NAME_LENGTH -> NAME_LENGTH	2019-01-03 07:30:44 -05:00
Rangi	b975f3e068	Clean up some Odd Egg and Battle Tower code and data ... Fixes #589	2019-01-02 19:04:50 -05:00
Rangi	eb1e3636bb	Use labels instead of constants for HRAM ... Use explicit ldh instruction to access HRAM locations, don't rely on optimizing ld	2018-08-25 14:28:22 -04:00
Rangi	b23f0b2bda	Fewer uses of 'Thing2 - Thing1' for sizeof(Thing)	2018-07-16 15:58:07 -04:00
mid-kid	1d9a68dbdd	Remove all address comments	2018-06-24 16:13:22 +02:00
Rangi	32ed487a47	Merge branch 'master' of https://github.com/pret/pokecrystal ... # Conflicts: # audio/engine.asm # constants/gfx_constants.asm # constants/map_data_constants.asm # constants/pokemon_data_constants.asm # constants/sprite_constants.asm # constants/wram_constants.asm # data/maps/data.asm # engine/battle/ai/scoring.asm # engine/battle/core.asm # engine/battle/effect_commands.asm # engine/battle/misc.asm # engine/battle_anims/getpokeballwobble.asm # engine/breeding.asm # engine/buy_sell_toss.asm # engine/decorations.asm # engine/events/battle_tower/battle_tower.asm # engine/events/battle_tower/rules.asm # engine/events/buena.asm # engine/events/bug_contest/contest_2.asm # engine/events/daycare.asm # engine/events/dratini.asm # engine/events/halloffame.asm # engine/events/happiness_egg.asm # engine/events/kurt.asm # engine/events/lucky_number.asm # engine/events/magnet_train.asm # engine/events/overworld.asm # engine/events/pokerus/pokerus.asm # engine/events/print_unown.asm # engine/events/print_unown_2.asm # engine/events/unown_walls.asm # engine/item_effects.asm # engine/link.asm # engine/mon_menu.asm # engine/player_object.asm # engine/routines/playslowcry.asm # engine/scripting.asm # engine/search.asm # engine/search2.asm # engine/specials.asm # engine/start_menu.asm # engine/timeset.asm # home/battle_vars.asm # home/map.asm # maps/GoldenrodUndergroundSwitchRoomEntrances.asm # maps/IlexForest.asm # maps/KrissHouse2F.asm # maps/Route39Barn.asm # mobile/mobile_12_2.asm # mobile/mobile_40.asm # mobile/mobile_5f.asm # wram.asm	2018-02-03 19:42:56 -05:00
Rangi	6ebe45e41f	Move event data to data/events/	2018-01-25 22:19:24 -05:00
Rangi	132fe46925	Rename some routines to avoid conflicts when removing "Special_" prefixes	2018-01-24 11:12:02 -05:00
luckytyphlosion	a1951cefc0	Prefix wram labels with w, part 2.	2018-01-23 17:39:09 -05:00
Remy Oukaour	05382d3e3c	PARTY_LENGTH; MON_NAME; sgb_border.bin	2018-01-20 12:25:55 -05:00
Remy Oukaour	86fd37af16	Move events/ to engine/events/	2017-12-27 00:09:12 -05:00