Commit Graph

5216 Commits

Author SHA1 Message Date
Rangi
90bec40276 Fix LodePNG to avoid -Wcast-qual warnings
<https://github.com/lvandeve/lodepng/issues/160>
2022-10-14 16:17:52 -04:00
Rangi
89a888277a Revise macros in tools 2022-10-12 21:43:00 -04:00
Rangi
ce004be92c Revise constants in CheckShininess 2022-10-12 21:41:08 -04:00
mid-kid
1222ea7def Fix rgbdscheck running on older rgbds 2022-10-08 19:07:00 +02:00
vulcandth
770d2fc4cb
FAQ.md require 0.6.0 2022-10-02 23:29:47 -05:00
Rangi
c61bd0d5a7 Update tools/unnamed.py for rgbds 0.6.0 object files 2022-10-02 22:34:10 -04:00
Rangi
8e135931a6 Require rgbds 0.6.0 2022-10-02 22:03:53 -04:00
Rangi
70a3ec1acc startswith works with a tuple 2022-09-30 16:55:35 -04:00
Rangi
f76f5c3583 Fix array size 2022-09-30 16:55:09 -04:00
Rangi
38578cc34d
Generate the correct Stadium base data for every ROM (#1010) 2022-09-30 16:42:29 -04:00
Idain
a9869f1896
Replace hardcoded wMonType constants (#1011) 2022-09-28 19:51:39 -05:00
vulcandth
bceeea8e3b
Fix Typo: GoldenrodPokecomCenterSaveBeforeTradeCornetText -> GoldenrodPokecomCenterSaveBeforeTradeCornerText 2022-09-24 20:04:28 -05:00
Rangi
f7507b7782 $f -> BATTLEACTION_FORFEIT
(thanks, Vulcandth)
2022-09-23 23:10:24 -04:00
Rangi
8fc3b8e6e3 Dance Theatre -> Dance Theater
Fixes #1008
2022-09-23 22:06:52 -04:00
Idain
553a272e52
TYPO: NUM_MOVE_EFECTS > NUM_MOVE_EFFECTS (#1009) 2022-09-21 22:01:39 -05:00
Rangi
29fada7d8c Don't use removeprefix in tools/unnamed.py (it worked locally...) 2022-09-18 23:56:11 -04:00
Rangi
55ca2da25a Fix tools/unnamed.py and add tools/consts.py 2022-09-18 23:41:45 -04:00
Rangi
6c26e2617c Update and add more tool scripts 2022-09-18 23:08:56 -04:00
Rangi
711f5c87b3 Comment about the redundant event const_next 1900
Fixes #1006
2022-09-15 18:05:52 -04:00
Andrew Cook
0f5540740b
Some Mobile code labeling and removed magic numbers (#993)
* Macro loop for EmptyAllSRAMBanks

* Many things labeled and magic numbers removed

* Conform to the style guide

* Rename URLs in mobile_46

* MOBILEAPI_19 -> MOBILEAPI_TELEPHONESTATUS

* Update engine/menus/empty_sram.asm

Co-authored-by: Rangi <35663410+Rangi42@users.noreply.github.com>

* Update ram/wram.asm

Co-authored-by: Rangi <35663410+Rangi42@users.noreply.github.com>

* Update mobile/mobile_46.asm

Co-authored-by: Rangi <35663410+Rangi42@users.noreply.github.com>

* Update mobile/mobile_46.asm

Co-authored-by: Rangi <35663410+Rangi42@users.noreply.github.com>

* Remove underscore from Set*DownloadURL symbols

* Begin Labeling TradeCornerHoldMon routines

* Add wMobileMon party_struct

* Add TRADE_CORNER_REQUEST_LENGTH constant

* Name battle tower action functions

* Label trade corner send/receive buffer

* Label the saved copy of the trade corner pokemon

also fix mailmsg_jp

* So many copies of decodeBase64Character

* Label another buffer

* Fix Alignment and use MOBILE_EMAIL_LENGTH

* `Function11ad8a` -> `MobileIncJumptableIndex`

* Apply Rangi Suggestions pass 1

Co-Authored-By: Rangi <35663410+Rangi42@users.noreply.github.com>

* Apply Suggestions 2

Co-authored-by: Rangi <35663410+Rangi42@users.noreply.github.com>
Co-authored-by: vulcandth <vulcandth@gmail.com>
2022-09-14 19:49:58 -05:00
Rangi
41d5ea0482
Rename the object_struct field labels and constants (#1005)
Fixes #990
2022-09-12 09:15:44 -04:00
vulcandth
4c239a6f65
Rename macros/wram.asm to macros/ram.asm (#1003) 2022-09-11 01:05:07 -04:00
Rangi
53e1c48092 Link to the symbols branch 2022-09-10 13:53:53 -04:00
vulcandth
57a23299fb
Use DEF for constants in Music IDs design flaw doc 2022-09-09 10:26:05 -05:00
vulcandth
ae79200b1d
Remove duplicate BUG comment in bug doc diff 2022-09-08 20:33:56 -05:00
mid-kid
cff8aec3a7 mobile/mobile_45.asm -> lib/mobile/mail.asm
This file is part of the official mobile adapter SDK, although unlike
lib/mobile/main.asm, this file was included as source code the
developers could modify.
2022-09-08 12:55:14 +02:00
vulcandth
8ed7c392cd Fix order of parameters in dsprite macro
The parameters of the legacy dsprite macros were in the wrong order.
Fixes #1002

Co-Authored-By: Idain <54337884+Idain@users.noreply.github.com>
Co-Authored-By: Fredrik Ljungdahl <fredde1994@gmail.com>
2022-09-07 19:25:20 -05:00
vulcandth
39ba36cb92 Use RS Group offset constants for slot_reel
Co-Authored-By: Rangi <35663410+Rangi42@users.noreply.github.com>
2022-09-05 10:17:40 +00:00
Rangi
5d629f9b31 Fix diff 2022-08-31 19:14:20 -04:00
Idain
01dffba788
Document fish bug properly (#995) 2022-08-31 18:13:10 -05:00
Rangi
4883950318 Use for loops to generate box pointer tables
Fixes #996
2022-08-31 18:03:49 -04:00
Rangi
c7dee19a48 Match bug docs with source code
Fixes #997
2022-08-31 17:56:00 -04:00
vulcandth
9801b93906 Add Bug comment for fishing/surfing on NPCs
Also this re-orders `FishFunction:` and `SurfFunction:` in the bug doc, since `SurfFunction:` is encountered in the file first.
2022-08-31 00:43:12 -05:00
Rangi
b764a3a84d Document fix for fishing and Surfing on top of NPCs
Fixes #994
2022-08-30 17:06:12 -04:00
Fredrik Ljungdahl
40c899162b Replace numbers with constants in PlayHitSound 2022-08-24 12:17:31 +02:00
Idain
bc4fec0694
Fix AI_Smart_Rage comment (#988) 2022-08-21 22:39:08 -05:00
Rangi
7ef31d9889 Move non-Pokémon graphics out of gfx/icons
Fixes #987
2022-08-17 17:45:26 -04:00
The Void
38cd2155df
Bug Doc: Options menu fails to clear joypad state on initialization (#984) 2022-08-11 23:28:35 -05:00
Rangi
0d5cf5c8b9
Refer to "Rival", not "Silver" (#983)
Fixes #982
2022-08-10 21:24:56 -04:00
Rangi
367a104203 PP must be 40 or less 2022-08-10 21:20:53 -04:00
vulcandth
c3331eb7b1
Rename scene and callback labels (#981)
Co-authored-by: Rangi <35663410+Rangi42@users.noreply.github.com>
2022-08-09 18:04:18 -04:00
vulcandth
134f45b71d
Fix Bug doc Ruins of Alpha Heading Size 2022-08-08 14:28:36 -05:00
Rangi
07e8efee7e Fix some whitespace 2022-08-07 00:38:08 -04:00
Rangi
7cac5b787b Assert that there are NUM_FRAMES textbox frames 2022-08-06 12:24:40 -04:00
Rangi
8826d97ee4
Define scene constants alongside scene_scripts (#979)
Generic SCENE_DEFAULT and SCENE_FINISHED are legacy values
2022-07-29 17:43:10 -04:00
Rangi
51bfd31ea8 Use '$' for hex, not '0x' 2022-07-21 19:59:10 -04:00
Colton G. Rushton
78d93a6246
urlencode special characters like 'é' in documentation link anchors (#976) 2022-07-21 18:48:28 -05:00
vulcandth
d9dbc13701
Basic Issue Template with Discord Link (#974)
Co-authored-by: Rangi <35663410+Rangi42@users.noreply.github.com>
2022-07-19 19:16:35 -05:00
Rangi
974bb7bf33 Only use "; BUG:" comments for documented bugs 2022-07-17 14:08:56 -04:00
Colton G. Rushton
145d8dd5c2
wVirtualOAM -> wShadowOAM and hTransferVirtualOAM -> hTransferShadowOAM (#971) 2022-07-09 17:18:22 -04:00