285 Commits

Author	SHA1	Message	Date
Andrew Cook	0f5540740b	Some Mobile code labeling and removed magic numbers (#993) ... * Macro loop for EmptyAllSRAMBanks * Many things labeled and magic numbers removed * Conform to the style guide * Rename URLs in mobile_46 * MOBILEAPI_19 -> MOBILEAPI_TELEPHONESTATUS * Update engine/menus/empty_sram.asm Co-authored-by: Rangi <35663410+Rangi42@users.noreply.github.com> * Update ram/wram.asm Co-authored-by: Rangi <35663410+Rangi42@users.noreply.github.com> * Update mobile/mobile_46.asm Co-authored-by: Rangi <35663410+Rangi42@users.noreply.github.com> * Update mobile/mobile_46.asm Co-authored-by: Rangi <35663410+Rangi42@users.noreply.github.com> * Remove underscore from Set*DownloadURL symbols * Begin Labeling TradeCornerHoldMon routines * Add wMobileMon party_struct * Add TRADE_CORNER_REQUEST_LENGTH constant * Name battle tower action functions * Label trade corner send/receive buffer * Label the saved copy of the trade corner pokemon also fix mailmsg_jp * So many copies of decodeBase64Character * Label another buffer * Fix Alignment and use MOBILE_EMAIL_LENGTH * `Function11ad8a` -> `MobileIncJumptableIndex` * Apply Rangi Suggestions pass 1 Co-Authored-By: Rangi <35663410+Rangi42@users.noreply.github.com> * Apply Suggestions 2 Co-authored-by: Rangi <35663410+Rangi42@users.noreply.github.com> Co-authored-by: vulcandth <vulcandth@gmail.com>	2022-09-14 19:49:58 -05:00
Rangi	41d5ea0482	Rename the object_struct field labels and constants (#1005) ... Fixes #990	2022-09-12 09:15:44 -04:00
Idain	01dffba788	Document fish bug properly (#995)	2022-08-31 18:13:10 -05:00
Rangi	4883950318	Use for loops to generate box pointer tables ... Fixes #996	2022-08-31 18:03:49 -04:00
vulcandth	9801b93906	Add Bug comment for fishing/surfing on NPCs ... Also this re-orders `FishFunction:` and `SurfFunction:` in the bug doc, since `SurfFunction:` is encountered in the file first.	2022-08-31 00:43:12 -05:00
Rangi	0d5cf5c8b9	Refer to "Rival", not "Silver" (#983) ... Fixes #982	2022-08-10 21:24:56 -04:00
vulcandth	c3331eb7b1	Rename scene and callback labels (#981) ... Co-authored-by: Rangi <35663410+Rangi42@users.noreply.github.com>	2022-08-09 18:04:18 -04:00
Rangi	07e8efee7e	Fix some whitespace	2022-08-07 00:38:08 -04:00
Rangi	8826d97ee4	Define scene constants alongside scene_scripts (#979) ... Generic SCENE_DEFAULT and SCENE_FINISHED are legacy values	2022-07-29 17:43:10 -04:00
Rangi	51bfd31ea8	Use '$' for hex, not '0x'	2022-07-21 19:59:10 -04:00
Colton G. Rushton	145d8dd5c2	wVirtualOAM -> wShadowOAM and hTransferVirtualOAM -> hTransferShadowOAM (#971)	2022-07-09 17:18:22 -04:00
vulcandth	ef9b9bb437	Clean up bugs commented in the source code (#912) ... Co-authored-by: Rangi <remy.oukaour+rangi42@gmail.com>	2022-07-09 16:12:02 -05:00
vulcandth	73c020074e	Remove redundant comments referencing labels (#921)	2022-06-06 17:34:54 -04:00
vulcandth	3648afda16	RGBDS syntax updates (#905) ... New MACRO and DEF syntax	2022-06-06 17:25:42 -04:00
vulcandth	a4d346cc8c	Improved Virtual Console patch identifiers (#907)	2022-06-06 17:22:48 -04:00
vulcandth	31c3c94d64	Build the Virtual Console patch with make crystal11_vc (#882) ... Fixes #813	2022-03-12 18:34:04 -05:00
Rangi	3a562f9896	Identify some wMenuJoypad-related button constants	2022-03-09 19:42:26 -05:00
Rangi	e56a9f7962	Clear however many bytes are needed for wFruitTreeFlags	2022-02-14 17:28:08 -05:00
Rangi	69185e1657	Identify some overworld movement data	2021-12-22 21:38:26 -05:00
Rangi	e706b878d9	Use ~X instead of $ff ^ X	2021-11-23 20:37:18 -05:00
Rangi	f59f1bdb88	Standardize capitalization of ".Jumptable"	2021-06-19 19:52:05 -04:00
TheFakeMateo	7a03fecc38	Fix incorrectly swapped Players PC menu constants	2021-06-09 19:31:54 -04:00
Rangi	efd1006917	Use {interpolation} to generate sequences of RAM labels ... This makes the table_width/assert_table_length usages unnecessary, and also keeps the labels automatically up to date if the length constants change.	2021-04-27 12:11:39 -04:00
Rangi	316fa4b695	Use rgbds 0.5.0	2021-04-19 16:31:37 -04:00
Rangi	90ce126139	Use numeric constants in text strings with "{d:interpolation}"	2021-03-21 18:14:31 -04:00