Rangi
50ea6d6e22
WALKS_ON_WATER → SWIMMING
2018-05-23 19:10:15 -04:00
Rangi
c85b32ed80
More sprite movement data flag constants
2018-05-23 19:06:04 -04:00
Rangi
c5d18de8ff
Use known sprite movement data flag constants
2018-05-23 13:15:07 -04:00
Rangi
32b92ca51c
Start improving sprite movement engine (to do: identify bit flags)
...
Introduce maskbits N[, S]: optionally shift the bitmask
2018-05-23 12:48:14 -04:00
Rangi
4e776d4fa6
Use constants
2018-05-23 11:14:15 -04:00
Rangi
d2880d1981
Factor out GetHPPals and SetHPPals from home.asm
...
The remaining code in home.asm is almost all "generic", unrelated to Pokémon-specific game logic, so leaving it as-is might be neater than little home/*.asm files for each routine.
2018-05-23 11:08:23 -04:00
Rangi
ad5337863d
Use SPRITE_VARS
2018-05-23 00:05:07 -04:00
Rangi
5c064746f6
Gme → Game
2018-05-21 21:54:56 -04:00
Rangi
846e3e65de
adc a, 0 → adc 0; fix comments
2018-05-20 17:55:27 -04:00
Rangi
9afacc7842
Use REGISTERED_* constants
...
128px wide pack_menu.png matches BGB VRAM viewer, and rows+cols match hex tile IDs (e.g. $24 = row 3 col 5)
2018-05-20 17:50:53 -04:00
Rangi
03570a514e
Correct comment
2018-05-19 13:16:18 -04:00
Rangi
ae50b1148a
1 << FRZ == $20
2018-05-19 13:11:50 -04:00
Rangi
d5fff8aa96
Constants for PC menu indexes
...
'db ' -> 'db '
2018-05-18 22:18:00 -04:00
Rangi
e1fabcfbff
Fix comments
2018-05-18 19:36:22 -04:00
yenatch
53bcd8f46c
Merge pull request #512 from pret/warnings
...
fix lb/ln and "left shift of negative value" warning
2018-05-11 00:45:12 -04:00
yenatch
9b0ca7b8c2
Merge pull request #510 from Rangi42/master
...
Use explicit HELD_NONE and NO_LIMITS, not 0s; also fix #511
2018-05-11 00:45:00 -04:00
yenatch
6e91c3a293
Revert "Fix #511 : eliminate "Left shift of negative value" warnings"
...
This reverts commit aa51dbc612
2018-05-11 00:42:44 -04:00
Rangi
e01a86fe84
Fix doc links
2018-05-09 12:10:50 -04:00
Rangi
8acc8d6e30
Merge branch 'master' of https://github.com/pret/pokecrystal
2018-05-06 22:45:07 -04:00
yenatch
59c4d824e6
Merge pull request #509 from mid-kid/master
...
A fix-various-little-things PR
2018-05-06 22:27:22 -04:00
yenatch
47379235f8
fix lb/ln and "left shift of negative value" warning
...
fixes #511
2018-05-06 21:35:55 -04:00
Rangi
aa51dbc612
Fix #511 : eliminate "Left shift of negative value" warnings
2018-05-06 21:27:47 -04:00
Rangi
e5d4f741ee
Keep macros near relevant data
2018-05-06 15:56:42 -04:00
Rangi
1c92cb8b48
'rept' is not indented
2018-05-06 12:16:57 -04:00
mid-kid
acdb302035
Fix rest of the givepokeitem/checkpokeitem references
2018-05-06 13:48:04 +02:00
Rangi
d31ba05aeb
Combine bit flags with | not +
2018-05-05 19:27:10 -04:00
Rangi
de0b344be4
Explicit NO_LIMITS instead of 0
2018-05-05 19:19:51 -04:00
Rangi
5a9975c541
Use explicit HELD_NONE, not 0
2018-05-05 15:36:04 -04:00
mid-kid
c82deab86f
fix-various-little-things
...
A compilation of suggestions from the discord that don't deserve
separate commits and are not questionable at all™.
2018-05-05 09:19:04 +02:00
yenatch
a63d9dfd4f
Merge pull request #507 from yenatch/master
...
fix label from the wrong bank in the title screen
2018-04-11 23:40:29 -04:00
yenatch
436f4829b5
fix label from the wrong bank in the title screen
2018-04-10 22:42:25 -04:00
yenatch
40b537d45b
Merge pull request #503 from Rangi42/master
...
Factor wMisc into meaningful parts; move most code out of home.asm
2018-04-09 21:30:24 -04:00
yenatch
e4b41fad4f
Merge pull request #495 from mid-kid/master
...
Use stadium 2 egg group names
2018-04-09 21:19:51 -04:00
Rangi
53ff57ca66
Correct map constant comments
2018-04-09 18:58:10 -04:00
Rangi
7307fc8dce
Use constants for bit/set/res more
2018-04-05 11:44:02 -04:00
mid-kid
1b12109cb0
HanleDefrost -> HandleDefrost
2018-04-05 11:41:06 +02:00
mid-kid
2d8f3a0654
Use Stadium 2 Egg Group names
...
Out of the current two most prevalent official conventions, this one was
chosen, because they're used in a direct counterpart to this game, and
thus feel more accurate.
2018-04-05 07:54:20 +02:00
mid-kid
80d437d565
Fix some uses of EFFECTIVE
2018-04-05 07:54:20 +02:00
mid-kid
28c6eb8341
Use data/items/pocket_names.asm
2018-04-05 07:54:20 +02:00
mid-kid
1891879b62
GENDERLESS -> GENDER_UNKNOWN
...
This is how they're called in official sources, and it fits better with
the other `GENDER_` constants.
2018-04-05 07:54:20 +02:00
Rangi
99df17d571
Move more code from home.asm into home/
2018-04-05 00:35:14 -04:00
Rangi
1e1bbbbf8c
check_nick_errors → correct_nick_errors; matches correct_party_errors
2018-04-05 00:04:53 -04:00
Rangi
81306889e3
Merge branch 'master' of https://github.com/pret/pokecrystal
2018-04-04 23:56:40 -04:00
yenatch
f750d4f418
Merge pull request #505 from mid-kid/battlecommands
...
Battle command fixes
2018-04-04 21:18:15 -04:00
yenatch
fe4377ce53
Merge pull request #501 from mid-kid/reorg
...
Organize the engine/ directory
2018-04-04 21:04:14 -04:00
mid-kid
38107209a6
Update docs and comments to reflect renames
2018-04-04 23:44:24 +02:00
mid-kid
d4025863cf
Rename some battle commands
...
`hittarget` was misleading, as it doesn't actually "hit" the target, it
only plays the animation. As such, I've renamed it to `moveanim`.
`checkfaint` has nothing to do with checking if the user or target has
fainted, instead, it applies wCurDamage onto the target's HP, hitting
the substitute if applicable. I've renamed the command to `applydamage`
and all of its subfunctions accordingly.
2018-04-04 23:27:40 +02:00
mid-kid
2958188fc6
Document more Beat Up-related bugs
...
Two bugs related to not raising the substitute when it should, one bug
related to not running king's rock when it should, and the other related
to running king's rock when it shouldn't. Fun.
2018-04-04 22:41:18 +02:00
mid-kid
800f948914
Label BattleCommand_BeatUpFailText
2018-04-04 22:40:35 +02:00
mid-kid
c1e3d17769
endloop loops back to critical itself
...
The comments seemed to specify that `endloop` loops back to the command
before `critical` and executes that, which simply isn't true. It loops
back to `critical` itself, and executes `critical`, before continuing on
with the remaining commands.
2018-04-04 22:40:26 +02:00
