pokehacks/pokecrystal-board
0
0
Fork 0
mirror of https://gitlab.com/xCrystal/pokecrystal-board.git synced 2025-04-09 05:44:44 -07:00
Code Issues Packages Projects Releases Wiki Activity

Move NUM_BUENA_PRIZES to event/buena.asm (still hard-coded)

Browse Source 
Buena_PrizeMenu has "rept NUM_BUENA_PRIZES", which needs NUM_BUENA_PRIZES to be already defined. BuenaPrizeItems and BuenaPrizeItemsEnd are needed to define NUM_BUENA_PRIZES; but BuenaPrizeItems is defined after Buena_PrizeMenu. I don't see a way to avoid hard-coding its value of 9.

Contrast that with the NUM_MOM_ITEMS constants, which are not used as "rept" arguments and so can be defined within their code file.
This commit is contained in:
Remy Oukaour
2017-12-23 00:31:04 -05:00
parent daa071451d
commit aa97752efe
4 changed files with 10 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
data/items/buena_prizes.asm
View File

@@ -1,5 +1,5 @@
BuenaPrizeItems: ; 8b15e
; there are NUM_BUENA_PRIZES entries
; there are NUM_BUENA_PRIZES items (see event/buena.asm)
db ULTRA_BALL, 2
db FULL_RESTORE, 2
db NUGGET, 3
@@ -9,4 +9,5 @@ BuenaPrizeItems: ; 8b15e
db CARBOS, 5
db CALCIUM, 5
db HP_UP, 5
BuenaPrizeItemsEnd:
; 8b170