pokehacks/pokecrystal-board
0
0
Fork 0
mirror of https://gitlab.com/xCrystal/pokecrystal-board.git synced 2025-09-08 08:13:02 -07:00
Code Issues Packages Projects Releases Wiki Activity

Move NUM_BUENA_PRIZES to event/buena.asm (still hard-coded)

Browse Source 
Buena_PrizeMenu has "rept NUM_BUENA_PRIZES", which needs NUM_BUENA_PRIZES to be already defined. BuenaPrizeItems and BuenaPrizeItemsEnd are needed to define NUM_BUENA_PRIZES; but BuenaPrizeItems is defined after Buena_PrizeMenu. I don't see a way to avoid hard-coding its value of 9.

Contrast that with the NUM_MOM_ITEMS constants, which are not used as "rept" arguments and so can be defined within their code file.
This commit is contained in:
Remy Oukaour
2017-12-23 00:31:04 -05:00
parent daa071451d
commit aa97752efe
4 changed files with 10 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
constants/radio_constants.asm
View File

@@ -123,6 +123,3 @@ NUM_PASSWORDS_PER_CATEGORY EQU 3
const BUENA_ITEM
const BUENA_MOVE
const BUENA_STRING
; BuenaPrizeItems table length (see data/items/buena_prizes.asm)
NUM_BUENA_PRIZES EQU 9