Commit Graph

  • 9284113867 Fixing more whitespace Jonathan Thomas 2022-10-13 10:21:40 -05:00
  • 032ff77602 Fixing more whitespace Jonathan Thomas 2022-10-13 10:21:00 -05:00
  • 4e12ceb51f Fixing more whitespace Jonathan Thomas 2022-10-13 10:20:23 -05:00
  • 9eb5d6f903 Fixing more whitespace Jonathan Thomas 2022-10-13 10:19:05 -05:00
  • 5cdf42784c Updating default cache settings to 24 (min preroll), 48 (max preroll), 300 (max frames), and 0.7 (percent ahead) Jonathan Thomas 2022-10-13 10:04:48 -05:00
  • 87052b5a35 Fixing whitespace issues Jonathan Thomas 2022-10-13 10:02:56 -05:00
  • 31566a192a Protection for ClearAllCache method, to prevent messing with closed clips. Added a multi-threaded unit tests for Timeline::GetFrame access - to verify nothing crashes. Jonathan Thomas 2022-10-13 00:01:03 -05:00
  • 8fcdbc9d03 Timeline now checks cache 2nd time, after mutex - incase previous call generated the same frame Jonathan Thomas 2022-10-11 23:01:26 -05:00
  • 5f9c4e06d8 Large performance regression fixed by moving mutex further into the Timeline::GetFrame method - only when generating a new frame (allowing cache to actually work freely). Adding mutex back to FFmpegReader::GetFrame. Removing redundant mutex from ReaderBase.h. Adding mutex to all methods that call shrink_to_fit(). Jonathan Thomas 2022-10-11 18:14:36 -05:00
  • 245186f2a0 Fixing some small memory related issues - uninitialized variable, RESVG initialization only for svg files, Close QtImageReader on destructor, erase allocated_effects and allocated_clips. Jonathan Thomas 2022-10-10 11:17:53 -05:00
  • 32a89cfce9 Add lock to new Clear() method to prevent crashes Jonathan Thomas 2022-10-06 21:59:11 -05:00
  • 934ca786ed Adding new Clear() method to Timeline, to delete all allocated clips, effects, and frame mapeprs (freeing memory). Also, keep track of allocated clips and effects on timeline (when using SetJson to create them), so we can clean them up correctly on Clear() or RemoveClip()/RemoveEffect(). Added new test case for Clear(). Jonathan Thomas 2022-10-06 15:07:31 -05:00
  • 8ac1589b2d Optimizing caching thread to exclude frames where no clips exist, and simplify some of the caching loop logic Jonathan Thomas 2022-10-04 18:35:16 -05:00
  • 23da61bf84 Merge pull request #851 from OpenShot/fix-hasvideo-override Jonathan Thomas 2022-09-27 17:59:06 -05:00
  • ec79c92f12 Refactor of packet counting and EOF detection. Instead of tracking overall packets read & decoded, we now track per stream (video and audio), so we can more accurately know when a packet is still pending for one of those streams (i.e. async decoding) Jonathan Thomas 2022-09-26 19:06:03 -05:00
  • a37ca4a376 Bump codecov/codecov-action from 3.1.0 to 3.1.1 dependabot[bot] 2022-09-26 11:04:00 +00:00
  • 01900819bb Merge pull request #849 from OpenShot/fix-hasvideo-override Jonathan Thomas 2022-09-24 15:06:48 -05:00
  • 5f6998d933 Fixing whitespace Jonathan Thomas 2022-09-24 14:49:53 -05:00
  • 906a5af9b0 Increasing max_attempts to prevent failures on Seeking from far away positions Jonathan Thomas 2022-09-24 14:36:26 -05:00
  • 285b4952fe Fixing behavior of manual override of has_video or has_audio, to remove unused packets, and not get stuck in an endless loop due to 1 or 2 pending packets that are no longer needed after the override. Jonathan Thomas 2022-09-24 14:06:36 -05:00
  • 87da5db84a Merge pull request #848 from OpenShot/multi-line-captions JacksonRG 2022-09-22 16:03:27 -05:00
  • 239444ac4a Merge pull request #847 from OpenShot/improved-caching Jonathan Thomas 2022-09-22 14:43:28 -05:00
  • c023d29bed Allow intentional line breaks jackson 2022-09-22 01:30:06 -05:00
  • 969a2015bf Increasing max video cache frames, moving percentage-ahead caching to a setting, fixing a calculation error on bytes per frame Jonathan Thomas 2022-09-20 16:55:07 -05:00
  • 16dc5408cc Fixing white space issue Jonathan Thomas 2022-09-16 10:34:30 -05:00
  • 95100f2ac4 Fixing white space issue Jonathan Thomas 2022-09-16 10:32:38 -05:00
  • 6ecc8b8998 Fixing white space issue Jonathan Thomas 2022-09-16 10:21:54 -05:00
  • 5d6441542b Fixing white space issue Jonathan Thomas 2022-09-16 10:12:48 -05:00
  • 8c7b463e38 Improvements to the ClearAllCache() function, allowing both shallow and deep clearing. Lots of bug fixes in VideoCacheThread, to correctly pre-roll and cache the correct frames, and a new method of disabling/enabling the cache thread. Jonathan Thomas 2022-09-15 18:33:06 -05:00
  • 8a3e2eb2d0 Refactor of cache code, and fixed a crash generating Json from an empty cache object. Jonathan Thomas 2022-09-15 18:29:43 -05:00
  • 7c2a205d5e Adding new settings, to control how video caching works, and how many frames to pre-roll and cache Jonathan Thomas 2022-09-15 17:53:44 -05:00
  • 5b6d3ce891 Merge pull request #846 from OpenShot/correct-timeline-frame-numbers JacksonRG 2022-09-15 17:12:34 -05:00
  • af1117b244 Subtract the start value from the timeline frame number. jackson 2022-09-14 13:37:20 -05:00
  • cfca6e77f7 Merge pull request #845 from OpenShot/invalid-number-frames Jonathan Thomas 2022-09-02 23:07:07 -05:00
  • 5f692f18d6 Protect video_length from being overwritten if CheckFPS overwrites it first Jonathan Thomas 2022-09-02 09:36:06 -05:00
  • 60805beec3 Adding support for detecting video_length (i.e. # of video frames) from the metadata, instead of calculating from duration * fps. This is occasionally different by a small amount, and in my testing, the metadata is more accurate. Jonathan Thomas 2022-09-02 01:09:00 -05:00
  • 61b2221898 Merge pull request #844 from OpenShot/snapping-precision Jonathan Thomas 2022-08-27 19:47:25 -05:00
  • d0a3002808 Fixing transition end frame calculation Jonathan Thomas 2022-08-27 16:59:14 -05:00
  • c23a9b1b54 Merge pull request #843 from OpenShot/improved-caption-background Jonathan Thomas 2022-08-24 17:12:47 -05:00
  • fd1043be5a Fixing many caption related issues: - background color now sticks to the text - background border now scales correctly (at different resolutions) - background padding now scales correctly - stroke size now scales correctly - margins are now defaulted to 15% on left/right - text caption area now centers between available left/right margins - background color can now be faded in and out, animated - new property: line_spacing, a % from 1.0 (100%) to affect how much space are between lines - Use each font's default lineSpacing, instead of a fixed distance between lines. This property can be adjusted with the new line_spacing keyframe. Jonathan Thomas 2022-08-23 23:21:38 -05:00
  • 02bd896681 Merge pull request #837 from OpenShot/improved-pts-support Jonathan Thomas 2022-08-17 22:57:32 -05:00
  • 0419f2c2a7 Fixing some whitespace issues Jonathan Thomas 2022-08-17 22:14:36 -05:00
  • 4ffa700377 Bump fsfe/reuse-action from 1.1.1 to 1.2.0 dependabot[bot] 2022-08-08 11:03:03 +00:00
  • 02c256cda5 Fixed FrameMapper::info::video_length after calling FrameMapper::ChangeMapping(). Added some unit tests to verify. Jonathan Thomas 2022-08-03 16:14:00 -05:00
  • 2f145234da Fixing more whitespace and wrapping issues. Also removed some audio pts debug code. Jonathan Thomas 2022-07-27 16:54:59 -05:00
  • c5f166a472 Removing debug log lines and more whitespace issues Jonathan Thomas 2022-07-27 16:44:01 -05:00
  • 7c6e20d551 Removing test code from CMaketest Jonathan Thomas 2022-07-27 16:37:04 -05:00
  • 694d86a41b Cleanup of debug logs and other whitespace issues Jonathan Thomas 2022-07-27 16:33:01 -05:00
  • 5ee38518da Experimental: Adding some fsanitize flags, a new example exe, a mutex on FFmpegReader::Close, and some additional clean-up code on AddImage (when a previous image exists) Jonathan Thomas 2022-07-27 15:33:40 -05:00
  • 01d16fe04a Experimental: Adding more QImage clean-up logging, to track buffer addresses Jonathan Thomas 2022-07-26 21:40:28 -05:00
  • 2c193463ce Experimental: No QImage cleanup Jonathan Thomas 2022-07-26 17:07:54 -05:00
  • 0164bd28be Experimental: Change method of copying QImage from previous frames to use qimage.copy method. Jonathan Thomas 2022-07-26 15:40:57 -05:00
  • f2852e8c34 Experimental: additional logging around AddImage() calls Jonathan Thomas 2022-07-26 15:21:25 -05:00
  • 89321d3bae Experimental: adding debug logging to Frame destructor and QImage cleanup. Also, preventing processing of empty samples Jonathan Thomas 2022-07-26 15:09:57 -05:00
  • 285059baad Experimental: adding debug symbols Jonathan Thomas 2022-07-25 17:24:35 -05:00
  • 297349033e Experimental FFmpegReader::Close changes, adding new drain decoder logic on Close Jonathan Thomas 2022-07-25 16:27:31 -05:00
  • 68f273d9d1 Experimental FFmpegReader::Close changes Jonathan Thomas 2022-07-23 19:44:01 -05:00
  • 3883d2d8aa Experimental FFmpegReader::Close changes Jonathan Thomas 2022-07-23 18:47:42 -05:00
  • 70bf0ade98 Refactoring FFmpegReader::Close, trying to prevent a crash on Windows Jonathan Thomas 2022-07-22 18:00:28 -05:00
  • 54971bac84 Removing some logic in FFmpegReader::Close which clears the video and audio stream - which can cause a crash if the decoder is still working on a packet. Reverting this code. Jonathan Thomas 2022-07-22 17:04:52 -05:00
  • 156fed2f49 Adding debugging to FFmpegReader::Close and removing a discard property that is probably unneeded Jonathan Thomas 2022-07-22 16:50:02 -05:00
  • 671e8ce455 Clean up of whitespace, and removal of unneeded logic on CheckWorkingFrames() method. It is okay to finalize a frame from a stream that has not decoded a packet yet... although it would be unlikely. Jonathan Thomas 2022-07-21 16:50:23 -05:00
  • dd25b7835d Removing failing macos from our GitHub build CI Jonathan Thomas 2022-07-21 15:25:26 -05:00
  • 9202d94ee6 Fixing whitespace issues (converting spaces back to tabs... for now) Jonathan Thomas 2022-07-21 15:00:08 -05:00
  • f200c00e4c Fixing Codacy issues Jonathan Thomas 2022-07-21 14:21:44 -05:00
  • f4966b2567 Large refactor of timestamps on FFmpegReader (PTS / presentation time stamps): - Improved PTS offset logic (to offset our streams so that at least one of them starts at position 0.0) - Removed missing frame detection (no needed anymore) - Use timestamps to reason about missing frames - Fixed many async decoding issues (jumbled frames, missing beginning or ending frames) - Much improved support for video/audio files with missing chunks/gaps (i.e. missing timestamps) - Improved CheckWorkingFrames() method, to determine when working frames are ready to be finalized - Improved FPS detection for invalid or missing FPS Jonathan Thomas 2022-07-21 13:56:29 -05:00
  • d093004dcf Fixing timeline tests. Recent FrameMapper bug fixes changed the mapping slightly, for certain tests Jonathan Thomas 2022-07-21 10:07:34 -05:00
  • cba676463d Fixing invalid frame mapping calculation (when using a linear algorithm to map framerates). We were accidentally adding +1 to the video_length, causing a slight rounding error, causing some random frames to be skipped. Jonathan Thomas 2022-06-25 17:42:30 -05:00
  • d2c7e856bb Fixing invalid "end frame" calculation for clips (we were accidentally adding +1) to the last frame of every clip, causing a repeat of the clip's last frame. Jonathan Thomas 2022-06-25 17:39:48 -05:00
  • d243db8aaa Adding new GetFrames method to CacheBase, to return an ordered vector of Frame objects. Useful when needing to iterate through the current cached frames. Jonathan Thomas 2022-06-25 17:32:36 -05:00
  • 5776efd71c Merge pull request #834 from OpenShot/fix-object-detector-class-name Jonathan Thomas 2022-06-22 14:27:01 -05:00
  • 7355ac3c55 Fix regression caused by https://github.com/OpenShot/libopenshot/pull/827, where we changed the class_name of Object Detector Jonathan Thomas 2022-06-21 11:30:30 -05:00
  • 7c6fcb0c51 Merge pull request #828 from ferdnyc/catch-upgrade Frank Dana 2022-06-18 05:53:35 -04:00
  • 54c9650599 Bump actions/cache from 2 to 3.0.1 (#821) dependabot[bot] 2022-06-18 05:28:07 -04:00
  • 6c5ffe1c1d HACK: 'using namespace Catch' in v3 header FeRD (Frank Dana) 2022-06-18 04:45:50 -04:00
  • 190bd915be Catch2v3: Use catch_all header FeRD (Frank Dana) 2022-06-17 15:49:52 -04:00
  • 677ed5f591 Tests: Switch test files to openshot_catch.h FeRD (Frank Dana) 2022-06-17 15:07:16 -04:00
  • 159d4fc629 tests/CMakeLists: Handle Catch2 v2 vs. v3 FeRD (Frank Dana) 2022-06-17 15:09:16 -04:00
  • 6db5f14139 Update catch_main.cpp (only for Catch2v2) FeRD (Frank Dana) 2022-06-17 15:08:50 -04:00
  • 5ae7112494 Catch2: Header templates for tests FeRD (Frank Dana) 2022-06-17 15:05:06 -04:00
  • 957d4f6a06 Fix class_name for Tracker and ObjectDetection (#827) Frank Dana 2022-06-17 15:30:08 -04:00
  • 664c5db821 Merge pull request #825 from OpenShot/fix-boosting-tracker Jonathan Thomas 2022-05-13 16:08:15 -05:00
  • eced60545a Update CVTracker unit test, since we've rounded bounding coordinates, we need to update the expected value in our unit test. Seems close enough to be a rounding error onw. Jonathan Thomas 2022-05-13 14:55:58 -05:00
  • 8ffcc36cfc Ensure CVTracker bbox uses INT values for it's Rect2d bounding box, and not float. The floats are killing the BOOSTING detector. Jonathan Thomas 2022-05-12 23:55:32 -05:00
  • 50a9a648c5 Merge pull request #819 from OpenShot/time-keyframes-mk2 JacksonRG 2022-05-02 13:33:37 -05:00
  • 7ebe9a9b75 Adding comment for clarity. jackson 2022-03-29 01:46:17 -05:00
  • 5ac659a16f Correct the frame number after mapping frame jackson 2022-03-29 01:31:51 -05:00
  • 7b6df2093d Apply keyframes based on the frame of the clip, rather than frame of the file. jackson 2022-03-26 02:25:30 -05:00
  • a956c1a98b Bump codecov/codecov-action from 2.1.0 to 3.1.0 (#823) dependabot[bot] 2022-04-27 13:18:39 -04:00
  • d909eccdf6 python/openshot.i: Convert to 4-space indents (#820) Frank Dana 2022-04-03 00:45:08 -04:00
  • 04db6ce801 Merge pull request #817 from OpenShot/revert-815-fix-time-keyframes JacksonRG 2022-03-21 22:43:05 -05:00
  • 0bf991601d Revert "Only map key numbers to time once" JacksonRG 2022-03-21 19:23:35 -05:00
  • a505443283 Merge pull request #815 from OpenShot/fix-time-keyframes JacksonRG 2022-03-21 17:58:29 -05:00
  • 08b4975600 Replace av_init_packet in FFmpeg 3.2+ (#784) Frank Dana 2022-03-16 23:58:06 -04:00
  • aee76211ac Merge pull request #809 from ferdnyc/drop-ffmpegw-fmt Frank Dana 2022-03-16 23:03:26 -04:00
  • 132c2df270 Only map key numbers to time once jackson 2022-03-16 21:58:09 -05:00
  • 9adb94c384 Add CODEOWNERS file (#806) Frank Dana 2022-03-13 20:23:24 -04:00
  • 98d247563b Bump actions/checkout from 2 to 3 (#813) dependabot[bot] 2022-03-13 20:22:18 -04:00
  • 6c546408ca src/FFmpegWriter.cpp: Fix indents Frank Dana 2022-03-13 20:00:43 -04:00
  • f29ce40861 Merge pull request #812 from OpenShot/clip-silence-past-reader-length Jonathan Thomas 2022-03-03 16:10:20 -06:00