Commit Graph

1381 Commits

Author SHA1 Message Date
Frank Dana
c04dc94cc8 Wrap assignment in conditional with () (#379) 2019-12-02 10:45:06 -05:00
Frank Dana
5e1b6fd740 Minor adjustments to Doxygen API docs (#376)
- Define `USE_IMAGEMAGICK` and `USE_BLACKMAGIC` unconditionally when
  building docs, so that the classes will be documented.
- Improve handling of `std::`-prefixed types in doxygen output.
2019-11-29 22:08:09 -05:00
chad3814
27bfbbc24a FFmpegWriter: match option 'rc_buffer_size' (#377) 2019-11-29 19:07:09 -05:00
Frank Dana
18811f40fe Merge pull request #375 from musteresel/avoid-unnecessary-image-copy
Frame.cpp: Explicitly use QImage const accessors
2019-11-27 18:13:00 -05:00
Daniel Jour
7e2846039e More traditional placement of const specifier, matching casts
As suggested in the code review:

 - More traditional placment of the const specifier, e.g. const unsigned char * instead of unsigned char const *
 - Matching casts to also cast to const unsigned char * instead of of unsigned char *

Co-Authored-By: Frank Dana <ferdnyc@gmail.com>
2019-11-27 23:57:58 +01:00
Daniel Jour
4b76c1eadc Frame.cpp: Avoid unnecessary copy of image data
As mentioned in issue #202 QImage::bits() and QImage::scanLine() make
a deep copy of the source image.  This is completely unnecessary when
read-only access to the pixel data is required.  Changing to
QImage::constBits() and QImage::constScanLine() solves this.  Both
functions were introduced in Qt 4.7.

https://doc.qt.io/qt-5/qimage.html#constBits
2019-11-26 00:56:13 +01:00
Jonathan Thomas
d539e468ca Merge pull request #366 from OpenShot/high-quality-scaling-bi-cubic
Change high quality scaling to use SWS_BICUBIC
2019-11-17 16:58:35 -06:00
Jonathan Thomas
099c8cbb6d Fixing missing impementation of high quality scale mode in FFmpegWriter 2019-11-17 16:36:31 -06:00
Jonathan Thomas
d6a4cb1dec Moving back to SWS_BICUBIC for high quality mode (during export mostly). This provides a sharper image when enlarging images than SWS_LANCZOS, and only has a slight performance disadvantage. 2019-11-17 16:34:50 -06:00
Jonathan Thomas
23ee6eb36f Merge pull request #360 from OpenShot/qt-targets
CMake: Use targets for QT, AUTOMOC sources, eliminate source globbing
2019-11-17 16:22:11 -06:00
Jonathan Thomas
272f004c0e Merge pull request #296 from OpenShot/std-prefixes
Remove all 'using namespace' directives from headers
2019-11-17 16:18:14 -06:00
Frank Dana
458c0be919 Merge pull request #365 from ferdnyc/reader-doc-fixes
Fix documentation for Qt(Text/Html)Reader
2019-11-17 02:16:42 -05:00
FeRD (Frank Dana)
7bbec4c51c Fix documentation for Qt(Text/Html)Reader
- Some parameters were changed from documented list
- Hash signs need to be escaped if they're not references (links)
2019-11-17 01:49:49 -05:00
Frank Dana
cfcbd800fb Merge pull request #364 from ferdnyc/find-python-order
Reverse order of Python detection
2019-11-17 01:43:54 -05:00
FeRD (Frank Dana)
c131c82be3 Reverse order of Python detection
Detecting PythonLibs before PythonInterp can cause a non-default Python
library to be picked up, which then won't match the PythonInterp version
(which always matches the version of the `python3` command).
2019-11-16 23:52:36 -05:00
Frank Dana
c2713520b9 Merge pull request #361 from ferdnyc/travis-clang
Add Clang compilation to Travis build matrix
2019-11-04 07:14:04 -05:00
FeRD (Frank Dana)
c002e2b4c9 Add libomp-dev package for Clang 2019-11-04 05:44:47 -05:00
FeRD (Frank Dana)
59e5e6b0aa Add clang compiling to Travis matrix 2019-11-04 05:30:52 -05:00
FeRD (Frank Dana)
e7a9c11fd6 Merge branch 'develop' into qt-targets 2019-11-04 04:58:57 -05:00
FeRD (Frank Dana)
6947f6625d Merge branch 'qt-targets' of https://github.com/OpenShot/libopenshot into qt-targets 2019-11-04 04:40:50 -05:00
FeRD (Frank Dana)
bc12995115 Lose the generator expressions 2019-11-04 04:38:57 -05:00
FeRD (Frank Dana)
c7ec690c55 CMake: Update linking, no more REQUIRED_LIBRARIES
- All linking is done after target creation
- Use BOOL generator expressions for conditional linking
2019-11-04 04:30:41 -05:00
FeRD (Frank Dana)
8f77a78c6f CMake: Update linking, no more REQUIRED_LIBRARIES
- All linking is done after target creation
- Use BOOL generator expressions for conditional linking
2019-11-04 04:13:44 -05:00
FeRD (Frank Dana)
750677c0c5 CMake: Manage sources and includes better
- Switch to AUTOMOC for Qt classes
- Eliminate globbing of source subdirs
- Call `include_directories()` in top-level CMakeLists
- Make header files PUBLIC library sources
- Make other sources PRIVATE
2019-11-04 03:59:34 -05:00
FeRD (Frank Dana)
42daa20056 FindFFmpeg: Expand duplicate-removal
Repeated invocations (e.g. `cmake .` in an already-configured dir) might 
cause variables to collect duplicates.
2019-11-04 03:33:19 -05:00