Wrap assignment in conditional with () (#379)

This commit is contained in:
Frank Dana
2019-12-02 10:45:06 -05:00
committed by GitHub
parent 5e1b6fd740
commit c04dc94cc8
2 changed files with 3 additions and 3 deletions

View File

@@ -914,7 +914,7 @@ void Clip::SetJsonValue(Json::Value root) {
if (!existing_effect["type"].isNull()) {
// Create instance of effect
if (e = EffectInfo().CreateEffect(existing_effect["type"].asString())) {
if ( (e = EffectInfo().CreateEffect(existing_effect["type"].asString())) ) {
// Load Json into Effect
e->SetJsonValue(existing_effect);

View File

@@ -1098,7 +1098,7 @@ void Timeline::SetJsonValue(Json::Value root) {
if (!existing_effect["type"].isNull()) {
// Create instance of effect
if (e = EffectInfo().CreateEffect(existing_effect["type"].asString())) {
if ( (e = EffectInfo().CreateEffect(existing_effect["type"].asString())) ) {
// Load Json into Effect
e->SetJsonValue(existing_effect);
@@ -1364,7 +1364,7 @@ void Timeline::apply_json_to_effects(Json::Value change, EffectBase* existing_ef
EffectBase *e = NULL;
// Init the matching effect object
if (e = EffectInfo().CreateEffect(effect_type)) {
if ( (e = EffectInfo().CreateEffect(effect_type)) ) {
// Load Json into Effect
e->SetJsonValue(change["value"]);