www/web-proxy-sso: more style/safety; closes #42

This commit is contained in:
Franco Fichtner
2016-10-21 20:16:03 +02:00
parent 9fdc7145b2
commit e3e44cfb27
3 changed files with 14 additions and 2 deletions
@@ -44,7 +44,12 @@ class ServiceController extends ApiControllerBase
$mdlSSOProxyAD = new SSOProxyAD();
if ((string)$mdlSSOProxyAD->general->UpdateCron == "") {
$mdlCron = new Cron();
$mdlSSOProxyAD->general->UpdateCron = $mdlCron->newDailyJob("SSOProyAD", "ssoproxyad updateDomain", "SSOProxyAD updateDomain cron", "1");
$mdlSSOProxyAD->general->UpdateCron = $mdlCron->newDailyJob(
"SSOProyAD",
"ssoproxyad updateDomain",
"SSOProxyAD updateDomain cron",
"1"
);
if ($mdlCron->performValidation()->count() == 0) {
$mdlCron->serializeToConfig();
$mdlMymodule->serializeToConfig($validateFullModel = false, $disable_validation = true);
@@ -69,5 +69,6 @@ class SSOProxyAD implements IAuthConnector
public function authenticate($username, $password)
{
return false;
}
}
@@ -49,7 +49,13 @@ if (isset($configObj->OPNsense->ssoproxyad)) {
if ($enabled == 1) {
$keytab = '/usr/local/etc/ssoproxyad/PROXY.keytab';
if (file_exists($keytab)) {
$cmd = '/usr/local/sbin/msktutil --auto-update --computer-name ' . strtolower($hostname) . ' --keytab ' . $keytab . ' 2>&1';
$cmd = exec_safe('/usr/local/sbin/msktutil %s %s %s %s %s 2>&1', array(
'--auto-update',
'--computer-name',
strtolower($hostname),
' --keytab',
$keytab
));
exec($cmd, $output_msktutil, $error_msktutil);
$out = implode($output_msktutil);
if ($error_msktutil > 0) {